Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94263/?format=api
{ "id": 94263, "url": "https://patches.dpdk.org/api/patches/94263/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210616025459.22717-5-joyce.kong@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210616025459.22717-5-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210616025459.22717-5-joyce.kong@arm.com", "date": "2021-06-16T02:54:55", "name": "[v2,4/8] test/mcslock: use GCC atomic builtins for lcores sync", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "da822663518fd8186f61dac1888c863dfb9c8e4d", "submitter": { "id": 970, "url": "https://patches.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210616025459.22717-5-joyce.kong@arm.com/mbox/", "series": [ { "id": 17343, "url": "https://patches.dpdk.org/api/series/17343/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17343", "date": "2021-06-16T02:54:51", "name": "use GCC's C11 atomic builtins for test", "version": 2, "mbox": "https://patches.dpdk.org/series/17343/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94263/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4A6ECA0C45;\n\tWed, 16 Jun 2021 04:56:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 81F1F410F5;\n\tWed, 16 Jun 2021 04:55:53 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 3F786410FA\n for <dev@dpdk.org>; Wed, 16 Jun 2021 04:55:52 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDB0613A1;\n Tue, 15 Jun 2021 19:55:51 -0700 (PDT)", "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.222])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A580D3F694;\n Tue, 15 Jun 2021 19:55:48 -0700 (PDT)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "thomas@monjalon.net, david.marchand@redhat.com,\n stephen@networkplumber.org,\n olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru,\n harry.van.haaren@intel.com, honnappa.nagarahalli@arm.com,\n ruifeng.wang@arm.com", "Cc": "dev@dpdk.org,\n\tnd@arm.com", "Date": "Tue, 15 Jun 2021 21:54:55 -0500", "Message-Id": "<20210616025459.22717-5-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210616025459.22717-1-joyce.kong@arm.com>", "References": "<20210604094624.31308-1-joyce.kong@arm.com>\n <20210616025459.22717-1-joyce.kong@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 4/8] test/mcslock: use GCC atomic builtins for\n lcores sync", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Convert rte_atomic usages to GCC atomic builtins for lcores sync\nin mcslock testcases.\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_mcslock.c | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test/test_mcslock.c b/app/test/test_mcslock.c\nindex 80eaecc90..52e45e7e2 100644\n--- a/app/test/test_mcslock.c\n+++ b/app/test/test_mcslock.c\n@@ -17,7 +17,6 @@\n #include <rte_lcore.h>\n #include <rte_cycles.h>\n #include <rte_mcslock.h>\n-#include <rte_atomic.h>\n \n #include \"test.h\"\n \n@@ -43,7 +42,7 @@ rte_mcslock_t *p_ml_perf;\n \n static unsigned int count;\n \n-static rte_atomic32_t synchro;\n+static uint32_t synchro;\n \n static int\n test_mcslock_per_core(__rte_unused void *arg)\n@@ -76,8 +75,7 @@ load_loop_fn(void *func_param)\n \trte_mcslock_t ml_perf_me;\n \n \t/* wait synchro */\n-\twhile (rte_atomic32_read(&synchro) == 0)\n-\t\t;\n+\trte_wait_until_equal_32(&synchro, 1, __ATOMIC_RELAXED);\n \n \tbegin = rte_get_timer_cycles();\n \twhile (lcount < MAX_LOOP) {\n@@ -102,15 +100,15 @@ test_mcslock_perf(void)\n \tconst unsigned int lcore = rte_lcore_id();\n \n \tprintf(\"\\nTest with no lock on single core...\\n\");\n-\trte_atomic32_set(&synchro, 1);\n+\t__atomic_store_n(&synchro, 1, __ATOMIC_RELAXED);\n \tload_loop_fn(&lock);\n \tprintf(\"Core [%u] Cost Time = %\"PRIu64\" us\\n\",\n \t\t\tlcore, time_count[lcore]);\n \tmemset(time_count, 0, sizeof(time_count));\n \n \tprintf(\"\\nTest with lock on single core...\\n\");\n+\t__atomic_store_n(&synchro, 1, __ATOMIC_RELAXED);\n \tlock = 1;\n-\trte_atomic32_set(&synchro, 1);\n \tload_loop_fn(&lock);\n \tprintf(\"Core [%u] Cost Time = %\"PRIu64\" us\\n\",\n \t\t\tlcore, time_count[lcore]);\n@@ -118,11 +116,11 @@ test_mcslock_perf(void)\n \n \tprintf(\"\\nTest with lock on %u cores...\\n\", (rte_lcore_count()));\n \n-\trte_atomic32_set(&synchro, 0);\n+\t__atomic_store_n(&synchro, 0, __ATOMIC_RELAXED);\n \trte_eal_mp_remote_launch(load_loop_fn, &lock, SKIP_MAIN);\n \n \t/* start synchro and launch test on main */\n-\trte_atomic32_set(&synchro, 1);\n+\t__atomic_store_n(&synchro, 1, __ATOMIC_RELAXED);\n \tload_loop_fn(&lock);\n \n \trte_eal_mp_wait_lcore();\n", "prefixes": [ "v2", "4/8" ] }