Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94258/?format=api
{ "id": 94258, "url": "https://patches.dpdk.org/api/patches/94258/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210616012053.201105-2-dapengx.yu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210616012053.201105-2-dapengx.yu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210616012053.201105-2-dapengx.yu@intel.com", "date": "2021-06-16T01:20:53", "name": "[2/2] net/ice: fix VXLAN flow director creation error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8d636e04e22792b0132c5a4515e2ae52e0aaa92e", "submitter": { "id": 2042, "url": "https://patches.dpdk.org/api/people/2042/?format=api", "name": "Yu, DapengX", "email": "dapengx.yu@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210616012053.201105-2-dapengx.yu@intel.com/mbox/", "series": [ { "id": 17342, "url": "https://patches.dpdk.org/api/series/17342/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17342", "date": "2021-06-16T01:20:52", "name": "[1/2] net/ice/base: fix VXLAN flow director creation error", "version": 1, "mbox": "https://patches.dpdk.org/series/17342/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94258/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94258/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C6C71A034F;\n\tWed, 16 Jun 2021 03:21:17 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B49E8410E2;\n\tWed, 16 Jun 2021 03:21:17 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id E71F540140;\n Wed, 16 Jun 2021 03:21:15 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Jun 2021 18:21:14 -0700", "from unknown (HELO localhost.localdomain) ([10.240.183.93])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Jun 2021 18:21:12 -0700" ], "IronPort-SDR": [ "\n GwwCSS55vD0GvDxs8sCoH/LpB3FbFu5u4We6Gs6m4/ZxNUQ/sbSiuD3v7kTucbEnVP94IfiI1w\n ayCBbjYumfAg==", "\n 6W9GHcZ3mx/RxI4R0YBEHm3eKQ989dM4Wput/cL4jgA7bhbmtTxn7QmgTGTYHaAD1UlxHTGXxb\n MQo/cSGinTtQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10016\"; a=\"227583132\"", "E=Sophos;i=\"5.83,276,1616482800\"; d=\"scan'208\";a=\"227583132\"", "E=Sophos;i=\"5.83,276,1616482800\"; d=\"scan'208\";a=\"450447825\"" ], "From": "dapengx.yu@intel.com", "To": "Qiming Yang <qiming.yang@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org, junfeng.guo@intel.com, zhirun.yan@intel.com,\n Dapeng Yu <dapengx.yu@intel.com>, stable@dpdk.org", "Date": "Wed, 16 Jun 2021 09:20:53 +0800", "Message-Id": "<20210616012053.201105-2-dapengx.yu@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210616012053.201105-1-dapengx.yu@intel.com>", "References": "<20210616012053.201105-1-dapengx.yu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] net/ice: fix VXLAN flow director creation\n error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dapeng Yu <dapengx.yu@intel.com>\n\nIn original implementation, error returned when creating VXLAN flow\ndirector with SCTP or TCP as layer 4 protocol of inner segment.\n\nThere are several root causes for the error:\n1. ice_fdir_input_set_hdrs() set ICE_FLOW_SEG_HDR_UDP into protocol\nheader flag of inner segment of VXLAN FDIR rule, even if it shall be\nICE_FLOW_SEG_HDR_TCP or ICE_FLOW_SEG_HDR_SCTP\n2. ice_fdir_input_set_hdrs() set ICE_FLOW_SEG_HDR_VXLAN into protocol\nheader flag of segments of VXLAN FDIR rule, it not necessary, and can\nbe set automatically by ice_flow_set_fld() later\n3. flow type: ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN hides the flow type of\ninner segment of VXLAN FDIR rule, then further causes function:\nice_fdir_get_gen_prgm_pkt() cannot write correct protocol id into inner\nsegment of training packet.\n\nThis patch fixes those defects described above.\n\nFixes: 855d23a07b36 (\"net/ice: support VXLAN VNI field in flow director\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dapeng Yu <dapengx.yu@intel.com>\n---\n drivers/net/ice/ice_fdir_filter.c | 47 ++++++++++++++++++++++++++-----\n 1 file changed, 40 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c\nindex 092c704503..29128c5e1b 100644\n--- a/drivers/net/ice/ice_fdir_filter.c\n+++ b/drivers/net/ice/ice_fdir_filter.c\n@@ -786,6 +786,28 @@ ice_fdir_cross_prof_conflict(struct ice_pf *pf,\n \t\t\t(pf, cflct_ptype, is_tunnel))\n \t\t\tgoto err;\n \t\tbreak;\n+\tcase ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_UDP:\n+\tcase ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_TCP:\n+\tcase ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_SCTP:\n+\t\tcflct_ptype = ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_OTHER;\n+\t\tif (!ice_fdir_prof_resolve_conflict\n+\t\t\t(pf, cflct_ptype, is_tunnel))\n+\t\t\tgoto err;\n+\t\tbreak;\n+\tcase ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_OTHER:\n+\t\tcflct_ptype = ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_UDP;\n+\t\tif (!ice_fdir_prof_resolve_conflict\n+\t\t\t(pf, cflct_ptype, is_tunnel))\n+\t\t\tgoto err;\n+\t\tcflct_ptype = ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_TCP;\n+\t\tif (!ice_fdir_prof_resolve_conflict\n+\t\t\t(pf, cflct_ptype, is_tunnel))\n+\t\t\tgoto err;\n+\t\tcflct_ptype = ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_SCTP;\n+\t\tif (!ice_fdir_prof_resolve_conflict\n+\t\t\t(pf, cflct_ptype, is_tunnel))\n+\t\t\tgoto err;\n+\t\tbreak;\n \tdefault:\n \t\tbreak;\n \t}\n@@ -968,11 +990,12 @@ ice_fdir_input_set_hdrs(enum ice_fltr_ptype flow, struct ice_flow_seg_info *seg)\n \t\tICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV6 |\n \t\t\t\t ICE_FLOW_SEG_HDR_IPV_FRAG);\n \t\tbreak;\n-\tcase ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN:\n-\t\tICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_UDP |\n-\t\t\t\tICE_FLOW_SEG_HDR_IPV4 |\n-\t\t\t\tICE_FLOW_SEG_HDR_VXLAN |\n-\t\t\t\tICE_FLOW_SEG_HDR_IPV_OTHER);\n+\tcase ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_UDP:\n+\tcase ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_TCP:\n+\tcase ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_SCTP:\n+\t\tbreak;\n+\tcase ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_OTHER:\n+\t\tICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV_OTHER);\n \t\tbreak;\n \tcase ICE_FLTR_PTYPE_NONF_IPV4_GTPU:\n \t\tICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_IP |\n@@ -2073,8 +2096,18 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,\n \telse if (tunnel_type == ICE_FDIR_TUNNEL_TYPE_GTPU_EH &&\n \t\tflow_type == ICE_FLTR_PTYPE_NONF_IPV6_UDP)\n \t\tflow_type = ICE_FLTR_PTYPE_NONF_IPV6_GTPU_EH;\n-\telse if (tunnel_type == ICE_FDIR_TUNNEL_TYPE_VXLAN)\n-\t\tflow_type = ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN;\n+\telse if (tunnel_type == ICE_FDIR_TUNNEL_TYPE_VXLAN &&\n+\t\tflow_type == ICE_FLTR_PTYPE_NONF_IPV4_UDP)\n+\t\tflow_type = ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_UDP;\n+\telse if (tunnel_type == ICE_FDIR_TUNNEL_TYPE_VXLAN &&\n+\t\tflow_type == ICE_FLTR_PTYPE_NONF_IPV4_TCP)\n+\t\tflow_type = ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_TCP;\n+\telse if (tunnel_type == ICE_FDIR_TUNNEL_TYPE_VXLAN &&\n+\t\tflow_type == ICE_FLTR_PTYPE_NONF_IPV4_SCTP)\n+\t\tflow_type = ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_SCTP;\n+\telse if (tunnel_type == ICE_FDIR_TUNNEL_TYPE_VXLAN &&\n+\t\tflow_type == ICE_FLTR_PTYPE_NONF_IPV4_OTHER)\n+\t\tflow_type = ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN_IPV4_OTHER;\n \n \tfilter->tunnel_type = tunnel_type;\n \tfilter->input.flow_type = flow_type;\n", "prefixes": [ "2/2" ] }