Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94206/?format=api
{ "id": 94206, "url": "https://patches.dpdk.org/api/patches/94206/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/CAOuQ8vXP3Gn_Zxa0q8HM_tJYn5qpWhcnVHz6540_eTKdLa02fA@mail.gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<CAOuQ8vXP3Gn_Zxa0q8HM_tJYn5qpWhcnVHz6540_eTKdLa02fA@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAOuQ8vXP3Gn_Zxa0q8HM_tJYn5qpWhcnVHz6540_eTKdLa02fA@mail.gmail.com", "date": "2021-06-15T09:58:59", "name": "net/ice: fix integer overflow when computing max_pkt_len", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "27763c408fd6c237853441b1f84af99cbafb8723", "submitter": { "id": 2247, "url": "https://patches.dpdk.org/api/people/2247/?format=api", "name": "Tudor Cornea", "email": "tudor.cornea@gmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/CAOuQ8vXP3Gn_Zxa0q8HM_tJYn5qpWhcnVHz6540_eTKdLa02fA@mail.gmail.com/mbox/", "series": [ { "id": 17331, "url": "https://patches.dpdk.org/api/series/17331/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17331", "date": "2021-06-15T09:58:59", "name": "net/ice: fix integer overflow when computing max_pkt_len", "version": 1, "mbox": "https://patches.dpdk.org/series/17331/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94206/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/94206/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D876CA0C47;\n\tTue, 15 Jun 2021 11:59:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 613494067A;\n\tTue, 15 Jun 2021 11:59:12 +0200 (CEST)", "from mail-ed1-f49.google.com (mail-ed1-f49.google.com\n [209.85.208.49]) by mails.dpdk.org (Postfix) with ESMTP id 680DF40140\n for <dev@dpdk.org>; Tue, 15 Jun 2021 11:59:11 +0200 (CEST)", "by mail-ed1-f49.google.com with SMTP id ba2so48496306edb.2\n for <dev@dpdk.org>; Tue, 15 Jun 2021 02:59:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=mime-version:from:date:message-id:subject:to;\n bh=MfvJSczjbDRNEiudQaiXoaIJ43bdHu3eRFrvmoWlNwQ=;\n b=JCaAoCMlUdSO5ksBEguhLOI6ke9ZBgCPhmzoKPcBBtnY33sLv01kwe6TWZHtULsjf2\n pbVdYxOIgaRKxa3K9KJ01OE3kIHHzaVscpZF3+u/uZq4NU8hGU5o1aWO1z+Rw0agCUwT\n PRThaKj+OZoWDQ65sPfc5wiPHvP2r07QwpAUy/1mkwcheap0FoGWPTESB191udgnBk6d\n Kw2nYGlPmE3MGbwlWeJY6HOW9L829JAAo5oAZwtWrhx2Lj8McPyYx+32O9GDXsckgg1o\n W8dq9eO4AYjZq9iAqLQJwyQfRy0Su90dhUWX7uJR4Ve1yYcDGX+PD/gdnO0qCKIbwYEc\n L5vA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:from:date:message-id:subject:to;\n bh=MfvJSczjbDRNEiudQaiXoaIJ43bdHu3eRFrvmoWlNwQ=;\n b=S1WrjOJWUyjtGUxQikQzWjhRPWI5UhPlHJGvG28Qp/1SysJHLVVpB/ViXnefgSBAf6\n 8Q0D0Iirr9eSosKqnNhXkSKlmXEe+v5W12UApzEtYVTeE9mEPe3hNJrkExibhYbJ2Pzz\n OktDEV5/xXPVFVH82ANwQhDjb10X9srKaozi40MushsI6K5XPCpfoHnvDTJ0jwifSIXW\n GRzNbHK9jx+ccnoNbQ1Rg3K37M/CzxucSFRbpBqpy7km2qBQt+9ack7V8ECJ1oJfQXwh\n +epm+SL0nSKNmGfGcp2+KhldurXwJ9zT4CWcpgzk3eW/LY1T1gNgWnOLb14yN8iaSef1\n Yjxw==", "X-Gm-Message-State": "AOAM5302oj+eTT86KUR5oiiZpIZvx3k+KKDutjGkDjNKmGMx0+FA0sMB\n sGjr647iRLv4asM+CEkDpegdC1e7+8g1zkMLEyI/QkSHZ0l8jg==", "X-Google-Smtp-Source": "\n ABdhPJz9TQxfKrvoLsExSKrDT09BQ7Gotu5YBsNKj98ugnTzkNEmPp+ToAZLfFz7oWjSE9zBiRO4FI4etPZf9EUJSbM=", "X-Received": "by 2002:a05:6402:40c3:: with SMTP id\n z3mr21981924edb.187.1623751150851;\n Tue, 15 Jun 2021 02:59:10 -0700 (PDT)", "MIME-Version": "1.0", "From": "Tudor Cornea <tudor.cornea@gmail.com>", "Date": "Tue, 15 Jun 2021 12:58:59 +0300", "Message-ID": "\n <CAOuQ8vXP3Gn_Zxa0q8HM_tJYn5qpWhcnVHz6540_eTKdLa02fA@mail.gmail.com>", "To": "dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH] net/ice: fix integer overflow when computing\n max_pkt_len", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Greetings,\n\nPlease review the following patch for the dpdk-next-net-intel branch.\n\nThe len variable, used in the computation of max_pkt_len could overflow,\nif used to store the result of the following computation:\n\nICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len\n\nSince, we could define the mbuf size to have a large value (i.e 13312),\nand ICE_SUPPORT_CHAIN_NUM is defined as 5, the computation mentioned\nabove could potentially result in a value which might be bigger than\nMAX_USHORT.\n\nThe result will be that Jumbo Frames will not work properly\n\nSigned-off-by: Tudor Cornea <tudor.cornea@keysight.com>\n---\n drivers/net/ice/ice_dcf_ethdev.c | 7 ++++---\n drivers/net/ice/ice_rxtx.c | 6 +++---\n 2 files changed, 7 insertions(+), 6 deletions(-)\n\n if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {", "diff": "diff --git a/drivers/net/ice/ice_dcf_ethdev.c\nb/drivers/net/ice/ice_dcf_ethdev.c\nindex b937cbb..f73dc80 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -54,13 +54,14 @@ ice_dcf_init_rxq(struct rte_eth_dev *dev, struct\nice_rx_queue *rxq)\n struct ice_dcf_adapter *dcf_ad = dev->data->dev_private;\n struct rte_eth_dev_data *dev_data = dev->data;\n struct iavf_hw *hw = &dcf_ad->real_hw.avf;\n- uint16_t buf_size, max_pkt_len, len;\n+ uint16_t buf_size, max_pkt_len;\n\n buf_size = rte_pktmbuf_data_room_size(rxq->mp) -\nRTE_PKTMBUF_HEADROOM;\n rxq->rx_hdr_len = 0;\n rxq->rx_buf_len = RTE_ALIGN(buf_size, (1 << ICE_RLAN_CTX_DBUF_S));\n- len = ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len;\n- max_pkt_len = RTE_MIN(len,\ndev->data->dev_conf.rxmode.max_rx_pkt_len);\n+ max_pkt_len = RTE_MIN((uint32_t)\n+ ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len,\n+ dev->data->dev_conf.rxmode.max_rx_pkt_len);\n\n /* Check if the jumbo frame and maximum packet length are set\n * correctly.\ndiff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex fc9bb5a..20352b0 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -258,7 +258,7 @@ ice_program_hw_rx_queue(struct ice_rx_queue *rxq)\n struct rte_eth_dev_data *dev_data = rxq->vsi->adapter->pf.dev_data;\n struct ice_rlan_ctx rx_ctx;\n enum ice_status err;\n- uint16_t buf_size, len;\n+ uint16_t buf_size;\n struct rte_eth_rxmode *rxmode = &dev_data->dev_conf.rxmode;\n uint32_t rxdid = ICE_RXDID_COMMS_OVS;\n uint32_t regval;\n@@ -268,8 +268,8 @@ ice_program_hw_rx_queue(struct ice_rx_queue *rxq)\n RTE_PKTMBUF_HEADROOM);\n rxq->rx_hdr_len = 0;\n rxq->rx_buf_len = RTE_ALIGN(buf_size, (1 << ICE_RLAN_CTX_DBUF_S));\n- len = ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len;\n- rxq->max_pkt_len = RTE_MIN(len,\n+ rxq->max_pkt_len = RTE_MIN((uint32_t)\n+ ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len,\n\n dev_data->dev_conf.rxmode.max_rx_pkt_len);\n\n", "prefixes": [] }