Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94198/?format=api
{ "id": 94198, "url": "https://patches.dpdk.org/api/patches/94198/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210615084241.139097-4-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210615084241.139097-4-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210615084241.139097-4-maxime.coquelin@redhat.com", "date": "2021-06-15T08:42:38", "name": "[v2,3/6] vhost: fix missing cache logging NUMA realloc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "42e9946c0cd400442ea10d04b6640b0ebb5401ce", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210615084241.139097-4-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 17329, "url": "https://patches.dpdk.org/api/series/17329/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17329", "date": "2021-06-15T08:42:35", "name": "vhost: Fix and improve NUMA reallocation", "version": 2, "mbox": "https://patches.dpdk.org/series/17329/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94198/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94198/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 31673A0C49;\n\tTue, 15 Jun 2021 10:43:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9CA4541125;\n\tTue, 15 Jun 2021 10:43:00 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 1E81D40140\n for <dev@dpdk.org>; Tue, 15 Jun 2021 10:42:58 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-375-DMVsm9EYPKCMeftrCe0KbA-1; Tue, 15 Jun 2021 04:42:57 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A59B107ACF6;\n Tue, 15 Jun 2021 08:42:56 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.45])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 4A63860613;\n Tue, 15 Jun 2021 08:42:55 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1623746578;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ChwUlThbHfFzZ91px8E/6E27SMFCt+z7hNlONUcROCk=;\n b=ZrmbjGT3f/2zxVohxgZid7gpbj0RFeoxisXQf3r57pSpYlMcoUxNWp3ineYv5sWugaBAR1\n TaLQ03exf2aGIdPNsB/zl8w041Cyz+jALZqZ0dzer0Afsswm487l9iau0TpcjMkCamt+IE\n duTTrQJmAl4dcCbDA/PgCZCRsOk7VuU=", "X-MC-Unique": "DMVsm9EYPKCMeftrCe0KbA-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 15 Jun 2021 10:42:38 +0200", "Message-Id": "<20210615084241.139097-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20210615084241.139097-1-maxime.coquelin@redhat.com>", "References": "<20210615084241.139097-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v2 3/6] vhost: fix missing cache logging NUMA\n realloc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the guest allocates virtqueues on a different NUMA node\nthan the one the Vhost metadata are allocated, both the Vhost\ndevice struct and the virtqueues struct are reallocated.\n\nHowever, reallocating the log cache on the new NUMA node was\nnot done. This patch fixes this by reallocating it if it has\nbeen allocated already, which means a live-migration is\non-going.\n\nFixes: 1818a63147fb (\"vhost: move dirty logging cache out of virtqueue\")\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost_user.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex cbfdf1b4d8..0e9e26ebe0 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -545,6 +545,16 @@ numa_realloc(struct virtio_net *dev, int index)\n \t\t\tvq->batch_copy_elems = new_batch_copy_elems;\n \t\t}\n \n+\t\tif (vq->log_cache) {\n+\t\t\tstruct log_cache_entry *log_cache;\n+\n+\t\t\tlog_cache = rte_realloc_socket(vq->log_cache,\n+\t\t\t\t\tsizeof(struct log_cache_entry) * VHOST_LOG_CACHE_NR,\n+\t\t\t\t\t0, newnode);\n+\t\t\tif (log_cache)\n+\t\t\t\tvq->log_cache = log_cache;\n+\t\t}\n+\n \t\trte_free(old_vq);\n \t}\n \n", "prefixes": [ "v2", "3/6" ] }