Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94161/?format=api
{ "id": 94161, "url": "https://patches.dpdk.org/api/patches/94161/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210613125139.17998-1-xuemingl@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210613125139.17998-1-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210613125139.17998-1-xuemingl@nvidia.com", "date": "2021-06-13T12:51:39", "name": "vdpa/mlx5: fix TSO offload without CSUM", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "10ae12c0de09fc428d4cd64f04981b5c8b1eb2df", "submitter": { "id": 1904, "url": "https://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210613125139.17998-1-xuemingl@nvidia.com/mbox/", "series": [ { "id": 17312, "url": "https://patches.dpdk.org/api/series/17312/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17312", "date": "2021-06-13T12:51:39", "name": "vdpa/mlx5: fix TSO offload without CSUM", "version": 1, "mbox": "https://patches.dpdk.org/series/17312/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94161/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94161/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4E0B7A0A0C;\n\tSun, 13 Jun 2021 14:52:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 879B74014F;\n\tSun, 13 Jun 2021 14:52:06 +0200 (CEST)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2043.outbound.protection.outlook.com [40.107.243.43])\n by mails.dpdk.org (Postfix) with ESMTP id E8B344003E;\n Sun, 13 Jun 2021 14:52:04 +0200 (CEST)", "from DM6PR06CA0091.namprd06.prod.outlook.com (2603:10b6:5:336::24)\n by DM6PR12MB3337.namprd12.prod.outlook.com (2603:10b6:5:118::13) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.25; Sun, 13 Jun\n 2021 12:52:02 +0000", "from DM6NAM11FT052.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:336:cafe::9e) by DM6PR06CA0091.outlook.office365.com\n (2603:10b6:5:336::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend\n Transport; Sun, 13 Jun 2021 12:52:02 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT052.mail.protection.outlook.com (10.13.172.111) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4219.21 via Frontend Transport; Sun, 13 Jun 2021 12:52:02 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 13 Jun\n 2021 12:52:00 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FtWtJMkTno5ieJ8YQaHranbxi2OpW7WDDEPGpMj1tFwb+T14FIvNM43uj1Igkb7eGJQbgwGVr+MBDmBux0LBWcA0IQj8umDOpKkEEyPwfoeCketmdzcReobSp8AZCvTnDBd0LyUUSdIiDTiQg2UmO3S8R2VXjOHIrLpBF3pP+Hm6urkFkmvKx9/x6H1NVJDUx4WGCdu6ZZDIOAfelIxQptHqD+D5i7yLQJ7ZRDZctMGC3RS9XM/vQHzEF+QVOHiNYWXJVpPoYjynYmwAY8audTZfW5McXEm1IspYgynFifL0/azjw/5UhKTs4/u/D89GR511K4oLSCIZI0CZlaGchQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=untqXqnSfTwmpEQRuQbvN8CWFJeRsc2stG1L/OE+cWY=;\n b=oaX2Jg56Yvy6+3jNCJlBJZxBlIhIJGPNKfOvErEd1Ug4AFMgdArQWt0akj1MaLm3I4KPDkIxzaUsb3rMII82QCPNSHdmfIz4b4vNo+Xg9TQTT2/CCGQqT/CPwWjfU/YPyuoMpg0waTkDwJkb+h7nTnWH6QTPXxmsjuiH1lZb4EY/IytX/lFvCXjYIcW8EgmD9grpf2SB3nOw5j70OeBbK59KktJUN86NidIYMAyWq5KZhyJBGVX3typPKe6CX1oFuGF3zKIrv4/woWplwvf69IpyuGSR0oWCEHyz5v33jIySccgNDSERIsxPdMXQQQggN74fHw/jqfCrhkAh9v+ddg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=untqXqnSfTwmpEQRuQbvN8CWFJeRsc2stG1L/OE+cWY=;\n b=UX2oFjVxRZvWeJaWn8Iwz2kKTlrxE6hHOE+FXP+g8u5rNs0ni8v4uzZ3CXZFNbTzCE2uhw8lSeYu8yvJvLW99XjqCPzrja0Bw4y6vGN2Wra40HdcsGzmZvgnQtxvqGQUxtrSITXLtvRpMBL8KtX9ZHfUIenpCwJYmVBO/XIlHafhA2CDfUwl5UTnHLT5hCK3iM35akhac4lTnOQwYdXQGiwxcJd+B7WAlq0owP2zVDGEHQ/5EIFPwCDH/EJgR31+p5k1dQDfDzwEzvCSCeBLhRIcDQmvdv4CXT9BsPH4WebSiLwTxfc4SiX+ss5emPU7J+7Nm6Kp0gKXGHCFEmSK4g==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed)\n header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Xueming Li <xuemingl@nvidia.com>", "To": "", "CC": "<dev@dpdk.org>, <xuemingl@nvidia.com>, <matan@nvidia.com>,\n <stable@dpdk.org>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, \"Maxime\n Coquelin\" <maxime.coquelin@redhat.com>", "Date": "Sun, 13 Jun 2021 20:51:39 +0800", "Message-ID": "<20210613125139.17998-1-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL111.nvidia.com (172.20.187.18) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "77395910-e18c-4e9e-c801-08d92e6a0a75", "X-MS-TrafficTypeDiagnostic": "DM6PR12MB3337:", "X-Microsoft-Antispam-PRVS": "\n <DM6PR12MB33379281824538E999B914F0A1329@DM6PR12MB3337.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4502;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 7QQZ7ucmhpRB/7yk/+JHO4xYFc1at7L92+RghbFxnJKe8S/kbKFK5H2AWKTZvT3Vg2kivqZrVeLUlIgnc6CKhlauPcfJt2jNSW6D/hKYOu4UP30wwomyCrpcdcwFJ7Z0cd0eqVClp1e5R6JzM0ERr26QoQuRE3QdeIT2wva1ynmXBrCJaJfO7YRUQTYRx292h6i27exRQWKxFlgKlTexfoYD72+RS+CdtnxzjxPt4NcoeO2GCdEHih/oCjjNLSPYoiVFhpfSMqOF2E/kGPo8pkyMRzZhuCyY87UG7QNAPjVnt4k2Ufm6mLjZxDd4y66/fpOzEg492MdL0LxyZubrPXJRFvYzEDglNDwnbO3wG2I+HEuiaDphuCzruujmnRIuxjyePxV2Qdb8qbGYQ+u389PXn3HNezoZxW3CjZKOLiTcICiBZ6Un1bI+ubIgzsdTwwO6tmf3NCGFZNbeXhRQIH2TIcq7nnyv0rgwZ+9BeaHHGkLfdhtT37E+4Pmef2YITUa9k0k0zrOF6TdMA9A7LKujR7E/A7SDQeFkvwyb0SC+RYhintXGHy/mUFD/NXNPAIQmPt6tOt1x8348HvyQmQP4gwwej27n18Slugm+MXj1estpz5VhV04P3d/fG8RpHnr2ECUGwGEvcB7NASzoBqV5zYNK4oa1vUV10ZJfsSM=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(376002)(136003)(346002)(396003)(39860400002)(36840700001)(46966006)(54906003)(82310400003)(26005)(7696005)(36906005)(16526019)(336012)(82740400003)(186003)(55016002)(1076003)(2616005)(356005)(83380400001)(109986005)(6666004)(426003)(5660300002)(7636003)(316002)(36756003)(47076005)(4326008)(70586007)(70206006)(8676002)(478600001)(86362001)(6286002)(36860700001)(8936002)(2906002)(266003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Jun 2021 12:52:02.5448 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 77395910-e18c-4e9e-c801-08d92e6a0a75", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT052.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB3337", "Subject": "[dpdk-dev] [PATCH] vdpa/mlx5: fix TSO offload without CSUM", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Packet was corrupted when TSO requested without CSUM update.\n\nEnables CSUM automatically if only TSO requested.\n\nFixes: 2aa8444b0084 (\"vdpa/mlx5: support stateless offloads\")\nCc: matan@nvidia.com\nCc: stable@dpdk.org\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\nindex 024c5c4180..f530646058 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n@@ -442,6 +442,13 @@ mlx5_vdpa_virtqs_prepare(struct mlx5_vdpa_priv *priv)\n \t\tDRV_LOG(ERR, \"Failed to configure negotiated features.\");\n \t\treturn -1;\n \t}\n+\tif ((priv->features & (1ULL << VIRTIO_NET_F_CSUM)) == 0 &&\n+\t ((priv->features & (1ULL << VIRTIO_NET_F_HOST_TSO4)) > 0 ||\n+\t (priv->features & (1ULL << VIRTIO_NET_F_HOST_TSO6)) > 0)) {\n+\t\t/* Packet may be corrupted if TSO is enabled without CSUM. */\n+\t\tDRV_LOG(INFO, \"TSO is enabled without CSUM, force CSUM.\");\n+\t\tpriv->features |= (1ULL << VIRTIO_NET_F_CSUM);\n+\t}\n \tif (nr_vring > priv->caps.max_num_virtio_queues * 2) {\n \t\tDRV_LOG(ERR, \"Do not support more than %d virtqs(%d).\",\n \t\t\t(int)priv->caps.max_num_virtio_queues * 2,\n", "prefixes": [] }