Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94158/?format=api
{ "id": 94158, "url": "https://patches.dpdk.org/api/patches/94158/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210613081917.24306-1-xuemingl@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210613081917.24306-1-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210613081917.24306-1-xuemingl@nvidia.com", "date": "2021-06-13T08:19:16", "name": "[v3,1/2] devargs: add common key definition", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "afd4ea19a3b33d9687cc5ba0688ffc546d650a29", "submitter": { "id": 1904, "url": "https://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210613081917.24306-1-xuemingl@nvidia.com/mbox/", "series": [ { "id": 17310, "url": "https://patches.dpdk.org/api/series/17310/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17310", "date": "2021-06-13T08:19:16", "name": "[v3,1/2] devargs: add common key definition", "version": 3, "mbox": "https://patches.dpdk.org/series/17310/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94158/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94158/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86129A0A0C;\n\tSun, 13 Jun 2021 10:20:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4D7804003F;\n\tSun, 13 Jun 2021 10:20:02 +0200 (CEST)", "from NAM04-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam08on2060.outbound.protection.outlook.com [40.107.102.60])\n by mails.dpdk.org (Postfix) with ESMTP id 9B0454003E\n for <dev@dpdk.org>; Sun, 13 Jun 2021 10:20:01 +0200 (CEST)", "from BN0PR04CA0091.namprd04.prod.outlook.com (2603:10b6:408:ec::6)\n by SN6PR12MB2846.namprd12.prod.outlook.com (2603:10b6:805:70::33) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Sun, 13 Jun\n 2021 08:19:59 +0000", "from BN8NAM11FT015.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:ec:cafe::1f) by BN0PR04CA0091.outlook.office365.com\n (2603:10b6:408:ec::6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend\n Transport; Sun, 13 Jun 2021 08:19:59 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT015.mail.protection.outlook.com (10.13.176.90) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4219.21 via Frontend Transport; Sun, 13 Jun 2021 08:19:59 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 13 Jun\n 2021 08:19:53 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Nago/TKimCgHVtwGG3BUhPn76oPKsuG9jY2lvXnrym9+x3+HgkA57iD27dfSCAajIVmvkjDiLCIXhHssiuuiQh+1xMbybv2cFdW1iK73dyUPVx0SqWbBm5gAOS8CiUVljZj6W3gP4FCPHITqUqP8oXCUCM18bvADgrjXTxnaaxtA7d+2S3tH/7ASBjGCwGvIRXvJ8r7ZbCUtDSrUx+awxhPFUP4iL14Go+JCNau09INrbI/Ei04AsoJ6mAMmQ469HVvmr1IkVu8bvCK1fZqtfQUJ56FmdKZCD9VIeQLlBl5jIdcF8eBCyQdX6mmnPTnT47Rl0hyy0CDeJ/RuuGkv2w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=e0/RHEmqHHOPGYf3BHKfE3OesSI1AMfdIZMceYTPczE=;\n b=FRK9i1aCNfRtLinwlF6fVP8F/VRk74j1We7GUXzyC+F/Oow8U5pGOQO0JnjSUFupMW0gF06uEvCXHL6yQII40qML0so5h90oKUm+3Xt8MMA3X4lgk/B2Sm9no1Pq604DHWjSHldGdM78AcAetr0LKvzQHUru8y7ZmWUEn7jqtaoUNV/ApiiFtsalXLrMj3C8PJUBoeCkMDw/kw27a77tLJjJSCWBBG92ErZHasaEv0Rm7bG/PyQH2pAYtACjJjt6XvJ2g1xTSvTYkSQUBh2g01Srs8eHu84ZcF3HvFTuBF5WxfVVYtkql7ayKNjbzF1fgXNPGK3QFck4Ug/i9sR4fw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=e0/RHEmqHHOPGYf3BHKfE3OesSI1AMfdIZMceYTPczE=;\n b=YQkbsraSZSTD0m9BCWbP0haotIfIGeYLu18fzO1ujSL7uDd/x5ERN3zpAehrtgz9R78czUgRhq2wzSdWPeeE7oRdhjQ3L+ZETZ0/Qyyb6rstjYUX+8Js2pp0veKLQcF4S0g/xVRcITp1UL93BKwilbPzqy+BXsbg82J3A3mmMywIfw5vExXpUmMQA8O3ZWbypPksBPAGbPv5Un37c4lY337zrIwl3F9aOlpSNX6YNZ+MnSN3O46hM0qfhQQbSxxaj+nnkFEyJf5VKTACZeA9uhwXb3m22GllRbHkXkUwxGYiJ+vPOEUx2MgxbNnBPXcVpGIx4C4y6qX4ONzun7cXHA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; huawei.com; dkim=none (message not signed)\n header.d=none;huawei.com; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Xueming Li <xuemingl@nvidia.com>", "To": "", "CC": "<dev@dpdk.org>, <xuemingl@nvidia.com>, Matan Azrad <matan@nvidia.com>,\n Shahaf Shuler <shahafs@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Chas Williams <chas3@att.com>, \"Min Hu (Connor)\" <humin29@huawei.com>,\n \"Beilei Xing\" <beilei.xing@intel.com>, Jingjing Wu <jingjing.wu@intel.com>", "Date": "Sun, 13 Jun 2021 16:19:16 +0800", "Message-ID": "<20210613081917.24306-1-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210510134732.2174-1-xuemingl@nvidia.com>", "References": "<20210510134732.2174-1-xuemingl@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "4a2527f9-a9eb-4b6c-7dbc-08d92e4408fb", "X-MS-TrafficTypeDiagnostic": "SN6PR12MB2846:", "X-Microsoft-Antispam-PRVS": "\n <SN6PR12MB284610740C03C9E328614178A1329@SN6PR12MB2846.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:49;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n IkMZCFj/ia1KPJt66/SEqSDB607JeB65rrecWxzxmSWvD1VhwZgmIWTQJC9mi0Zjr+pYXIO9W3PlTznHnKFrVNapc/kiTC7Un6KneLU/ueuT4BDO3/x0mGWB8sVp+CmZqb4i0HB4DL0xoxsMTUzrCWqsw0+nkKAMc/+PwWdxLojMhQ1/lfOFM03i2GlW8nJQTym9YxW4Zh4ErHpkOUcLIYtFDPPkVUQYXf5fqAABGIwqNpFyr2pdgveVWF3AY9WAYKAK6ZenLwKp4jkVNCo2NHOMdSeo2+j7UjrN/jMww4CO1g2iTaX/crqSCJdnkTtIebWaFmt5gVLHxclySvsxeJLE4rz6x7WGksHsXRWWUfrEa6MDZGOJHJ7gMuu61pePrdmCVy4KPwgCLnK23uyeHWdGKdw/V+YdtaX9v/EssMGcSnEfT25JPHG7YUT12gtvSNmozrXmGxT2gYXRORcwXg+8XrRqXY6D+1eeOgcZ3pVvW/PS9iI/B0mG1CgyqhFtzP+9KnVBAKLEbHVh80KlZXRjUC1YA8BLpuphnmoiGszQHb9YIBph/aEQ80XtviS2n95YVhM7L/ff2GlKnnanAM7dXB+dTddib+KSiKsbOHEsBRY1I6I9iOm+K3Zf256rdxIabVs5cXRK9lxpiQk22VLvqfHRetLZLk2XPvgF3hw=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(396003)(346002)(136003)(39860400002)(376002)(46966006)(36840700001)(8676002)(82310400003)(6666004)(336012)(82740400003)(109986005)(5660300002)(86362001)(70206006)(54906003)(4326008)(426003)(70586007)(7696005)(186003)(16526019)(6286002)(55016002)(36860700001)(478600001)(26005)(8936002)(36906005)(47076005)(2616005)(36756003)(1076003)(2906002)(316002)(83380400001)(7636003)(356005)(266003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Jun 2021 08:19:59.1270 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4a2527f9-a9eb-4b6c-7dbc-08d92e4408fb", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT015.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN6PR12MB2846", "Subject": "[dpdk-dev] [PATCH v3 1/2] devargs: add common key definition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adds common devargs key definition for \"bus\", \"class\" and \"driver\".\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\n---\n drivers/common/mlx5/mlx5_common.h | 2 --\n drivers/common/mlx5/mlx5_common_pci.c | 2 +-\n drivers/common/sfc_efx/sfc_efx.h | 2 --\n drivers/net/bonding/rte_eth_bond_args.c | 2 +-\n drivers/net/i40e/i40e_ethdev_vf.c | 5 ++---\n drivers/net/iavf/iavf_ethdev.c | 5 ++---\n drivers/net/mlx5/mlx5.c | 4 ++--\n drivers/net/sfc/sfc_kvargs.c | 2 +-\n drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +-\n lib/eal/common/eal_common_devargs.c | 12 ++++++------\n lib/eal/include/rte_devargs.h | 4 ++++\n 11 files changed, 20 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h\nindex 1fbefe0fa6..306f2f1ab7 100644\n--- a/drivers/common/mlx5/mlx5_common.h\n+++ b/drivers/common/mlx5/mlx5_common.h\n@@ -208,8 +208,6 @@ __rte_internal\n int mlx5_get_ifname_sysfs(const char *ibdev_path, char *ifname);\n \n \n-#define MLX5_CLASS_ARG_NAME \"class\"\n-\n enum mlx5_class {\n \tMLX5_CLASS_INVALID,\n \tMLX5_CLASS_NET = RTE_BIT64(0),\ndiff --git a/drivers/common/mlx5/mlx5_common_pci.c b/drivers/common/mlx5/mlx5_common_pci.c\nindex 3f16cd21cf..34747c4e07 100644\n--- a/drivers/common/mlx5/mlx5_common_pci.c\n+++ b/drivers/common/mlx5/mlx5_common_pci.c\n@@ -118,7 +118,7 @@ bus_cmdline_options_handler(__rte_unused const char *key,\n static int\n parse_class_options(const struct rte_devargs *devargs)\n {\n-\tconst char *key = MLX5_CLASS_ARG_NAME;\n+\tconst char *key = RTE_DEVARGS_KEY_CLASS;\n \tstruct rte_kvargs *kvlist;\n \tint ret = 0;\n \ndiff --git a/drivers/common/sfc_efx/sfc_efx.h b/drivers/common/sfc_efx/sfc_efx.h\nindex 6b6164cb1f..c16eca60f3 100644\n--- a/drivers/common/sfc_efx/sfc_efx.h\n+++ b/drivers/common/sfc_efx/sfc_efx.h\n@@ -19,8 +19,6 @@\n extern \"C\" {\n #endif\n \n-#define SFC_EFX_KVARG_DEV_CLASS\t\"class\"\n-\n enum sfc_efx_dev_class {\n \tSFC_EFX_DEV_CLASS_INVALID = 0,\n \tSFC_EFX_DEV_CLASS_NET,\ndiff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c\nindex 764b1b8c8e..5406e1c934 100644\n--- a/drivers/net/bonding/rte_eth_bond_args.c\n+++ b/drivers/net/bonding/rte_eth_bond_args.c\n@@ -18,7 +18,7 @@ const char *pmd_bond_init_valid_arguments[] = {\n \tPMD_BOND_SOCKET_ID_KVARG,\n \tPMD_BOND_MAC_ADDR_KVARG,\n \tPMD_BOND_AGG_MODE_KVARG,\n-\t\"driver\",\n+\tRTE_DEVARGS_KEY_DRIVER,\n \tNULL\n };\n \ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex cb898bdb68..1d8ca42a0f 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1660,7 +1660,6 @@ static int\n i40evf_driver_selected(struct rte_devargs *devargs)\n {\n \tstruct rte_kvargs *kvlist;\n-\tconst char *key = \"driver\";\n \tint ret = 0;\n \n \tif (devargs == NULL)\n@@ -1670,13 +1669,13 @@ i40evf_driver_selected(struct rte_devargs *devargs)\n \tif (kvlist == NULL)\n \t\treturn 0;\n \n-\tif (!rte_kvargs_count(kvlist, key))\n+\tif (!rte_kvargs_count(kvlist, RTE_DEVARGS_KEY_DRIVER))\n \t\tgoto exit;\n \n \t/* i40evf driver selected when there's a key-value pair:\n \t * driver=i40evf\n \t */\n-\tif (rte_kvargs_process(kvlist, key,\n+\tif (rte_kvargs_process(kvlist, RTE_DEVARGS_KEY_DRIVER,\n \t\t\t i40evf_check_driver_handler, NULL) < 0)\n \t\tgoto exit;\n \ndiff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex d688c31cfb..4e79319017 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -2440,7 +2440,6 @@ static int\n iavf_drv_i40evf_selected(struct rte_devargs *devargs, uint16_t device_id)\n {\n \tstruct rte_kvargs *kvlist;\n-\tconst char *key = \"driver\";\n \tint ret = 0;\n \n \tif (device_id != IAVF_DEV_ID_VF &&\n@@ -2456,13 +2455,13 @@ iavf_drv_i40evf_selected(struct rte_devargs *devargs, uint16_t device_id)\n \tif (kvlist == NULL)\n \t\treturn 0;\n \n-\tif (!rte_kvargs_count(kvlist, key))\n+\tif (!rte_kvargs_count(kvlist, RTE_DEVARGS_KEY_DRIVER))\n \t\tgoto exit;\n \n \t/* i40evf driver selected when there's a key-value pair:\n \t * driver=i40evf\n \t */\n-\tif (rte_kvargs_process(kvlist, key,\n+\tif (rte_kvargs_process(kvlist, RTE_DEVARGS_KEY_DRIVER,\n \t\t\t iavf_drv_i40evf_check_handler, NULL) < 0)\n \t\tgoto exit;\n \ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex cf1815cb74..d0faa45944 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -1931,7 +1931,7 @@ mlx5_args_check(const char *key, const char *val, void *opaque)\n \t\tconfig->max_dump_files_num = tmp;\n \t} else if (strcmp(MLX5_LRO_TIMEOUT_USEC, key) == 0) {\n \t\tconfig->lro.timeout = tmp;\n-\t} else if (strcmp(MLX5_CLASS_ARG_NAME, key) == 0) {\n+\t} else if (strcmp(RTE_DEVARGS_KEY_CLASS, key) == 0) {\n \t\tDRV_LOG(DEBUG, \"class argument is %s.\", val);\n \t} else if (strcmp(MLX5_HP_BUF_SIZE, key) == 0) {\n \t\tconfig->log_hp_size = tmp;\n@@ -2002,7 +2002,7 @@ mlx5_args(struct mlx5_dev_config *config, struct rte_devargs *devargs)\n \t\tMLX5_REPRESENTOR,\n \t\tMLX5_MAX_DUMP_FILES_NUM,\n \t\tMLX5_LRO_TIMEOUT_USEC,\n-\t\tMLX5_CLASS_ARG_NAME,\n+\t\tRTE_DEVARGS_KEY_CLASS,\n \t\tMLX5_HP_BUF_SIZE,\n \t\tMLX5_RECLAIM_MEM,\n \t\tMLX5_SYS_MEM_EN,\ndiff --git a/drivers/net/sfc/sfc_kvargs.c b/drivers/net/sfc/sfc_kvargs.c\nindex 0efa92ed28..974c05e68e 100644\n--- a/drivers/net/sfc/sfc_kvargs.c\n+++ b/drivers/net/sfc/sfc_kvargs.c\n@@ -28,7 +28,7 @@ sfc_kvargs_parse(struct sfc_adapter *sa)\n \t\tSFC_KVARG_TX_DATAPATH,\n \t\tSFC_KVARG_FW_VARIANT,\n \t\tSFC_KVARG_RXD_WAIT_TIMEOUT_NS,\n-\t\tSFC_EFX_KVARG_DEV_CLASS,\n+\t\tRTE_DEVARGS_KEY_CLASS,\n \t\tNULL,\n \t};\n \ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex e5e03e6582..8b5bfd8c3d 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -588,7 +588,7 @@ mlx5_vdpa_args_check_handler(const char *key, const char *val, void *opaque)\n \tunsigned long tmp;\n \tint n_cores = sysconf(_SC_NPROCESSORS_ONLN);\n \n-\tif (strcmp(key, \"class\") == 0)\n+\tif (strcmp(key, RTE_DEVARGS_KEY_CLASS) == 0)\n \t\treturn 0;\n \terrno = 0;\n \ttmp = strtoul(val, NULL, 0);\ndiff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c\nindex b31ac879a9..23aaf8b7e4 100644\n--- a/lib/eal/common/eal_common_devargs.c\n+++ b/lib/eal/common/eal_common_devargs.c\n@@ -49,9 +49,9 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\tconst char *str;\n \t\tstruct rte_kvargs *kvlist;\n \t} layers[] = {\n-\t\t{ \"bus=\", NULL, NULL, },\n-\t\t{ \"class=\", NULL, NULL, },\n-\t\t{ \"driver=\", NULL, NULL, },\n+\t\t{ RTE_DEVARGS_KEY_BUS \"=\", NULL, NULL, },\n+\t\t{ RTE_DEVARGS_KEY_CLASS \"=\", NULL, NULL, },\n+\t\t{ RTE_DEVARGS_KEY_DRIVER \"=\", NULL, NULL, },\n \t};\n \tstruct rte_kvargs_pair *kv = NULL;\n \tstruct rte_class *cls = NULL;\n@@ -118,7 +118,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\tif (layers[i].kvlist == NULL)\n \t\t\tcontinue;\n \t\tkv = &layers[i].kvlist->pairs[0];\n-\t\tif (strcmp(kv->key, \"bus\") == 0) {\n+\t\tif (strcmp(kv->key, RTE_DEVARGS_KEY_BUS) == 0) {\n \t\t\tbus = rte_bus_find_by_name(kv->value);\n \t\t\tif (bus == NULL) {\n \t\t\t\tRTE_LOG(ERR, EAL, \"Could not find bus \\\"%s\\\"\\n\",\n@@ -126,7 +126,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\t\t\tret = -EFAULT;\n \t\t\t\tgoto get_out;\n \t\t\t}\n-\t\t} else if (strcmp(kv->key, \"class\") == 0) {\n+\t\t} else if (strcmp(kv->key, RTE_DEVARGS_KEY_CLASS) == 0) {\n \t\t\tcls = rte_class_find_by_name(kv->value);\n \t\t\tif (cls == NULL) {\n \t\t\t\tRTE_LOG(ERR, EAL, \"Could not find class \\\"%s\\\"\\n\",\n@@ -134,7 +134,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\t\t\tret = -EFAULT;\n \t\t\t\tgoto get_out;\n \t\t\t}\n-\t\t} else if (strcmp(kv->key, \"driver\") == 0) {\n+\t\t} else if (strcmp(kv->key, RTE_DEVARGS_KEY_DRIVER) == 0) {\n \t\t\t/* Ignore */\n \t\t\tcontinue;\n \t\t}\ndiff --git a/lib/eal/include/rte_devargs.h b/lib/eal/include/rte_devargs.h\nindex 1e595b3c51..14fe7f70b6 100644\n--- a/lib/eal/include/rte_devargs.h\n+++ b/lib/eal/include/rte_devargs.h\n@@ -25,6 +25,10 @@ extern \"C\" {\n #include <rte_compat.h>\n #include <rte_bus.h>\n \n+#define RTE_DEVARGS_KEY_BUS \"bus\"\n+#define RTE_DEVARGS_KEY_CLASS \"class\"\n+#define RTE_DEVARGS_KEY_DRIVER \"driver\"\n+\n /**\n * Type of generic device\n */\n", "prefixes": [ "v3", "1/2" ] }