Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94150/?format=api
{ "id": 94150, "url": "https://patches.dpdk.org/api/patches/94150/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1623551516-49635-3-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1623551516-49635-3-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1623551516-49635-3-git-send-email-humin29@huawei.com", "date": "2021-06-13T02:31:52", "name": "[2/6] net/hns3: fix delay time for waiting to stop rxtx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b89a0d0969f2de8b119fef344785234d2c6a6dc4", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1623551516-49635-3-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 17308, "url": "https://patches.dpdk.org/api/series/17308/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17308", "date": "2021-06-13T02:31:54", "name": "bugfixes for hns3 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/17308/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94150/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94150/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2BB38A0C47;\n\tSun, 13 Jun 2021 04:32:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5837E4111C;\n\tSun, 13 Jun 2021 04:32:29 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 7613740E03\n for <dev@dpdk.org>; Sun, 13 Jun 2021 04:32:23 +0200 (CEST)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.57])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G2dng4pwYzZdwY\n for <dev@dpdk.org>; Sun, 13 Jun 2021 10:29:27 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2176.2; Sun, 13 Jun 2021 10:32:20 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Sun, 13 Jun 2021 10:31:52 +0800", "Message-ID": "<1623551516-49635-3-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1623551516-49635-1-git-send-email-humin29@huawei.com>", "References": "<1623551516-49635-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 2/6] net/hns3: fix delay time for waiting to stop\n rxtx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nWhen the primary process executes dev_stop or is being reset, the packet\nsending and receiving functions is changed. In this moment, the primary\nprocess requests secondary processes to change their Rx/Tx functions, and\ndelays a period of time in case of crashes when queues are still in use.\nThe delay time depends on the number of queues actually used, instead of\nthe maximum number of queues supported by the device.\n\nFixes: 23d4b61fee5d (\"net/hns3: support multiple process\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 4 ++--\n drivers/net/hns3/hns3_ethdev_vf.c | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 467d770..32719ff 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -5897,7 +5897,7 @@ hns3_dev_stop(struct rte_eth_dev *dev)\n \t/* Disable datapath on secondary process. */\n \thns3_mp_req_stop_rxtx(dev);\n \t/* Prevent crashes when queues are still in use. */\n-\trte_delay_ms(hw->tqps_num);\n+\trte_delay_ms(hw->cfg_max_queues);\n \n \trte_spinlock_lock(&hw->lock);\n \tif (__atomic_load_n(&hw->reset.resetting, __ATOMIC_RELAXED) == 0) {\n@@ -6513,7 +6513,7 @@ hns3_stop_service(struct hns3_adapter *hns)\n \trte_wmb();\n \t/* Disable datapath on secondary process. */\n \thns3_mp_req_stop_rxtx(eth_dev);\n-\trte_delay_ms(hw->tqps_num);\n+\trte_delay_ms(hw->cfg_max_queues);\n \n \trte_spinlock_lock(&hw->lock);\n \tif (hns->hw.adapter_state == HNS3_NIC_STARTED ||\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 1e94a1e..a198d07 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -2109,7 +2109,7 @@ hns3vf_dev_stop(struct rte_eth_dev *dev)\n \t/* Disable datapath on secondary process. */\n \thns3_mp_req_stop_rxtx(dev);\n \t/* Prevent crashes when queues are still in use. */\n-\trte_delay_ms(hw->tqps_num);\n+\trte_delay_ms(hw->cfg_max_queues);\n \n \trte_spinlock_lock(&hw->lock);\n \tif (__atomic_load_n(&hw->reset.resetting, __ATOMIC_RELAXED) == 0) {\n@@ -2560,7 +2560,7 @@ hns3vf_stop_service(struct hns3_adapter *hns)\n \trte_wmb();\n \t/* Disable datapath on secondary process. */\n \thns3_mp_req_stop_rxtx(eth_dev);\n-\trte_delay_ms(hw->tqps_num);\n+\trte_delay_ms(hw->cfg_max_queues);\n \n \trte_spinlock_lock(&hw->lock);\n \tif (hw->adapter_state == HNS3_NIC_STARTED ||\n", "prefixes": [ "2/6" ] }