Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94114/?format=api
{ "id": 94114, "url": "https://patches.dpdk.org/api/patches/94114/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210613000652.28191-20-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210613000652.28191-20-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210613000652.28191-20-ajit.khaparde@broadcom.com", "date": "2021-06-13T00:06:13", "name": "[v2,19/58] net/bnxt: cleanup logs in session handling paths", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d89b6eaeb6299753bb46beedd1f98916b2076b49", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210613000652.28191-20-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 17305, "url": "https://patches.dpdk.org/api/series/17305/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17305", "date": "2021-06-13T00:05:54", "name": "enhancements to host based flow table management", "version": 2, "mbox": "https://patches.dpdk.org/series/17305/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94114/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94114/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E015A0C41;\n\tSun, 13 Jun 2021 02:10:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1EF5A411B7;\n\tSun, 13 Jun 2021 02:07:30 +0200 (CEST)", "from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n by mails.dpdk.org (Postfix) with ESMTP id EAB9E410FF\n for <dev@dpdk.org>; Sun, 13 Jun 2021 02:07:24 +0200 (CEST)", "by mail-pl1-f178.google.com with SMTP id u18so4061274plc.0\n for <dev@dpdk.org>; Sat, 12 Jun 2021 17:07:24 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id gg22sm12774609pjb.17.2021.06.12.17.07.22\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Sat, 12 Jun 2021 17:07:23 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=Cq9O0uBpnsqYYFz/lkRN9xslA2MSs+zWQwARbdLTVT8=;\n b=VOGFe/049e7DRAoa6wRywnqWiLKFi+3TUouuloGxkHqjgi/P6VpRQMMSWqAV4aWU4N\n Y03PoaZZzqwyC0uKiphyh/EygaTXQRpf8yVNsVqaVvcIlWEZ/ZnYJ/qYAjhuIh71jw7l\n Mmm2s71EFVJ4N5EsO4CHgC9wd+7OWe2mHHJdw=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=Cq9O0uBpnsqYYFz/lkRN9xslA2MSs+zWQwARbdLTVT8=;\n b=EGB8k+dkkZ2DqTItJ+Kj+KR8B8InSSDLA+lhtGaulr9Op33q81vI7GHx+kMXosex39\n MqdzSYjsGZ7b95iRC7G068x5jcrEQd6vsE1xglRJtJZA6jqGDAyf/SrHL3nMMIIyX2yg\n blj6ItGI/3QSk64wwMv2n7fw7QepiQFICTf3YI+FNwO8cWYTtryt/0Fq1H6dYxavDj1A\n +wKdbrweCDIFvRJjmky8/h8aY8f/FKwAS5Rg+UAuTsrFlJsvHT3iK7m1N/4HT7xh9AnZ\n ChLVWsghUwy5pUXkW15dSdo4Bp7u4fQqyMsfRW733TsU4VwoPtFmpITJBUw7DkvYz2cx\n ia+Q==", "X-Gm-Message-State": "AOAM530iamhJWMvPbW3hMpsyQY8hI45+NBPhkG5o81RNnmq1lsDjc/+0\n Kpe4Scgfg/jnhdQ+s3be/HPctSFm46RvYz00fVNmNc99KjVW+uEt9hi8+ZtIaoMvHgM2lzlYB2o\n ToM8aSXjWC5cddniPq/PbeNDtvxPz1utRCPGFXfVWOxCmwPHkAIj1lV313zKY4WE=", "X-Google-Smtp-Source": "\n ABdhPJz9EMhT9H+2jJaDyN8goaZREKtY13lFLsDuIzfXgvvrDbPfmzHjINqFLfi1mLjBaAACPtN/vg==", "X-Received": "by 2002:a17:902:b609:b029:118:8a66:6963 with SMTP id\n b9-20020a170902b609b02901188a666963mr8643718pls.65.1623542843530;\n Sat, 12 Jun 2021 17:07:23 -0700 (PDT)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Farah Smith <farah.smith@broadcom.com>, Jay Ding <jay.ding@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n Randy Schacher <stuart.schacher@broadcom.com>,\n Peter Spreadborough <peter.spreadborough@broadcom.com>", "Date": "Sat, 12 Jun 2021 17:06:13 -0700", "Message-Id": "<20210613000652.28191-20-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20210613000652.28191-1-ajit.khaparde@broadcom.com>", "References": "<20210530085929.29695-1-venkatkumar.duvvuru@broadcom.com>\n <20210613000652.28191-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"0000000000007f875505c49a8697\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH v2 19/58] net/bnxt: cleanup logs in session\n handling paths", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Farah Smith <farah.smith@broadcom.com>\n\nCleanup some of the log messages in the session open and close paths.\n\nSigned-off-by: Farah Smith <farah.smith@broadcom.com>\nSigned-off-by: Jay Ding <jay.ding@broadcom.com>\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Randy Schacher <stuart.schacher@broadcom.com>\nReviewed-by: Peter Spreadborough <peter.spreadborough@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/tf_core/tf_device.c | 90 ++++++++++++-----------\n drivers/net/bnxt/tf_core/tf_em_internal.c | 13 +---\n drivers/net/bnxt/tf_core/tf_identifier.c | 15 +---\n drivers/net/bnxt/tf_core/tf_if_tbl.c | 18 +----\n drivers/net/bnxt/tf_core/tf_session.c | 18 +++--\n drivers/net/bnxt/tf_core/tf_tbl.c | 18 ++---\n drivers/net/bnxt/tf_core/tf_tcam.c | 12 +--\n 7 files changed, 77 insertions(+), 107 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/tf_device.c b/drivers/net/bnxt/tf_core/tf_device.c\nindex 55cf55886a..498e668b16 100644\n--- a/drivers/net/bnxt/tf_core/tf_device.c\n+++ b/drivers/net/bnxt/tf_core/tf_device.c\n@@ -216,20 +216,20 @@ tf_dev_bind_p4(struct tf *tfp,\n \t\treturn -ENOMEM;\n \t}\n \n-\tif (!tf_session_is_shared_session(tfs)) {\n-\t\t/*\n-\t\t * IF_TBL\n-\t\t */\n-\t\tif_tbl_cfg.num_elements = TF_IF_TBL_TYPE_MAX;\n-\t\tif_tbl_cfg.cfg = tf_if_tbl_p4;\n-\t\tif_tbl_cfg.shadow_copy = shadow_copy;\n-\t\trc = tf_if_tbl_bind(tfp, &if_tbl_cfg);\n-\t\tif (rc) {\n-\t\t\tTFP_DRV_LOG(ERR,\n-\t\t\t\t \"IF Table initialization failure\\n\");\n-\t\t\tgoto fail;\n-\t\t}\n+\t/*\n+\t * IF_TBL\n+\t */\n+\tif_tbl_cfg.num_elements = TF_IF_TBL_TYPE_MAX;\n+\tif_tbl_cfg.cfg = tf_if_tbl_p4;\n+\tif_tbl_cfg.shadow_copy = shadow_copy;\n+\trc = tf_if_tbl_bind(tfp, &if_tbl_cfg);\n+\tif (rc) {\n+\t\tTFP_DRV_LOG(ERR,\n+\t\t\t \"IF Table initialization failure\\n\");\n+\t\tgoto fail;\n+\t}\n \n+\tif (!tf_session_is_shared_session(tfs)) {\n \t\t/*\n \t\t * GLOBAL_CFG\n \t\t */\n@@ -271,6 +271,12 @@ tf_dev_unbind_p4(struct tf *tfp)\n {\n \tint rc = 0;\n \tbool fail = false;\n+\tstruct tf_session *tfs;\n+\n+\t/* Retrieve the session information */\n+\trc = tf_session_get_session_internal(tfp, &tfs);\n+\tif (rc)\n+\t\treturn rc;\n \n \t/* Unbind all the support modules. As this is only done on\n \t * close we only report errors as everything has to be cleaned\n@@ -318,18 +324,20 @@ tf_dev_unbind_p4(struct tf *tfp)\n \t\tfail = true;\n \t}\n \n-\trc = tf_if_tbl_unbind(tfp);\n-\tif (rc) {\n-\t\tTFP_DRV_LOG(INFO,\n-\t\t\t \"Device unbind failed, IF Table Type\\n\");\n-\t\tfail = true;\n-\t}\n+\tif (!tf_session_is_shared_session(tfs)) {\n+\t\trc = tf_if_tbl_unbind(tfp);\n+\t\tif (rc) {\n+\t\t\tTFP_DRV_LOG(INFO,\n+\t\t\t\t \"Device unbind failed, IF Table Type\\n\");\n+\t\t\tfail = true;\n+\t\t}\n \n-\trc = tf_global_cfg_unbind(tfp);\n-\tif (rc) {\n-\t\tTFP_DRV_LOG(INFO,\n-\t\t\t \"Device unbind failed, Global Cfg Type\\n\");\n-\t\tfail = true;\n+\t\trc = tf_global_cfg_unbind(tfp);\n+\t\tif (rc) {\n+\t\t\tTFP_DRV_LOG(INFO,\n+\t\t\t\t \"Device unbind failed, Global Cfg Type\\n\");\n+\t\t\tfail = true;\n+\t\t}\n \t}\n \n \tif (fail)\n@@ -472,17 +480,17 @@ tf_dev_bind_p58(struct tf *tfp,\n \t/*\n \t * IF_TBL\n \t */\n-\tif (!tf_session_is_shared_session(tfs)) {\n-\t\tif_tbl_cfg.num_elements = TF_IF_TBL_TYPE_MAX;\n-\t\tif_tbl_cfg.cfg = tf_if_tbl_p58;\n-\t\tif_tbl_cfg.shadow_copy = shadow_copy;\n-\t\trc = tf_if_tbl_bind(tfp, &if_tbl_cfg);\n-\t\tif (rc) {\n-\t\t\tTFP_DRV_LOG(ERR,\n-\t\t\t\t \"IF Table initialization failure\\n\");\n-\t\t\tgoto fail;\n-\t\t}\n+\tif_tbl_cfg.num_elements = TF_IF_TBL_TYPE_MAX;\n+\tif_tbl_cfg.cfg = tf_if_tbl_p58;\n+\tif_tbl_cfg.shadow_copy = shadow_copy;\n+\trc = tf_if_tbl_bind(tfp, &if_tbl_cfg);\n+\tif (rc) {\n+\t\tTFP_DRV_LOG(ERR,\n+\t\t\t \"IF Table initialization failure\\n\");\n+\t\tgoto fail;\n+\t}\n \n+\tif (!tf_session_is_shared_session(tfs)) {\n \t\t/*\n \t\t * GLOBAL_CFG\n \t\t */\n@@ -571,14 +579,14 @@ tf_dev_unbind_p58(struct tf *tfp)\n \t\tfail = true;\n \t}\n \n-\tif (!tf_session_is_shared_session(tfs)) {\n-\t\trc = tf_if_tbl_unbind(tfp);\n-\t\tif (rc) {\n-\t\t\tTFP_DRV_LOG(ERR,\n-\t\t\t\t \"Device unbind failed, IF Table Type\\n\");\n-\t\t\tfail = true;\n-\t\t}\n+\trc = tf_if_tbl_unbind(tfp);\n+\tif (rc) {\n+\t\tTFP_DRV_LOG(ERR,\n+\t\t\t \"Device unbind failed, IF Table Type\\n\");\n+\t\tfail = true;\n+\t}\n \n+\tif (!tf_session_is_shared_session(tfs)) {\n \t\trc = tf_global_cfg_unbind(tfp);\n \t\tif (rc) {\n \t\t\tTFP_DRV_LOG(ERR,\ndiff --git a/drivers/net/bnxt/tf_core/tf_em_internal.c b/drivers/net/bnxt/tf_core/tf_em_internal.c\nindex 93de513989..28ffbd5876 100644\n--- a/drivers/net/bnxt/tf_core/tf_em_internal.c\n+++ b/drivers/net/bnxt/tf_core/tf_em_internal.c\n@@ -412,17 +412,13 @@ tf_em_int_bind(struct tf *tfp,\n \t\t\tdb_rc[i] = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n \t\telse\n \t\t\tdb_rc[i] = tf_rm_create_db(tfp, &db_cfg);\n-\t\tif (db_rc[i]) {\n-\t\t\tTFP_DRV_LOG(ERR,\n-\t\t\t\t \"%s: EM Int DB creation failed\\n\",\n-\t\t\t\t tf_dir_2_str(i));\n-\n-\t\t}\n \t}\n \n \t/* No db created */\n-\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX])\n+\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX]) {\n+\t\tTFP_DRV_LOG(ERR, \"EM Int DB creation failed\\n\");\n \t\treturn db_rc[TF_DIR_RX];\n+\t}\n \n \n \tif (!tf_session_is_shared_session(tfs)) {\n@@ -514,9 +510,6 @@ tf_em_int_unbind(struct tf *tfp)\n \n \trc = tf_session_get_db(tfp, TF_MODULE_TYPE_EM, &em_db_ptr);\n \tif (rc) {\n-\t\tTFP_DRV_LOG(INFO,\n-\t\t\t \"Em_db is not initialized, rc:%s\\n\",\n-\t\t\t strerror(-rc));\n \t\treturn 0;\n \t}\n \tem_db = (struct em_rm_db *)em_db_ptr;\ndiff --git a/drivers/net/bnxt/tf_core/tf_identifier.c b/drivers/net/bnxt/tf_core/tf_identifier.c\nindex 3575c3e1a0..9f27a41fcf 100644\n--- a/drivers/net/bnxt/tf_core/tf_identifier.c\n+++ b/drivers/net/bnxt/tf_core/tf_identifier.c\n@@ -74,11 +74,6 @@ tf_ident_bind(struct tf *tfp,\n \t\t\tdb_rc[i] = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n \t\telse\n \t\t\tdb_rc[i] = tf_rm_create_db(tfp, &db_cfg);\n-\t\tif (db_rc[i]) {\n-\t\t\tTFP_DRV_LOG(INFO,\n-\t\t\t\t \"%s: No Identifier DB required\\n\",\n-\t\t\t\t tf_dir_2_str(i));\n-\t\t}\n \n \t\tif (parms->shadow_copy) {\n \t\t\tshadow_cfg.alloc_cnt =\n@@ -99,8 +94,10 @@ tf_ident_bind(struct tf *tfp,\n \t}\n \n \t/* No db created */\n-\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX])\n+\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX]) {\n+\t\tTFP_DRV_LOG(ERR, \"No Identifier DB created\\n\");\n \t\treturn db_rc[TF_DIR_RX];\n+\t}\n \n \tTFP_DRV_LOG(INFO,\n \t\t \"Identifier - initialized\\n\");\n@@ -121,12 +118,8 @@ tf_ident_unbind(struct tf *tfp)\n \tTF_CHECK_PARMS1(tfp);\n \n \trc = tf_session_get_db(tfp, TF_MODULE_TYPE_IDENTIFIER, &ident_db_ptr);\n-\tif (rc) {\n-\t\tTFP_DRV_LOG(INFO,\n-\t\t\t \"Ident_db is not initialized, rc:%s\\n\",\n-\t\t\t strerror(-rc));\n+\tif (rc)\n \t\treturn 0;\n-\t}\n \tident_db = (struct ident_rm_db *)ident_db_ptr;\n \n \tfor (i = 0; i < TF_DIR_MAX; i++) {\ndiff --git a/drivers/net/bnxt/tf_core/tf_if_tbl.c b/drivers/net/bnxt/tf_core/tf_if_tbl.c\nindex f58fa79b63..762dac0473 100644\n--- a/drivers/net/bnxt/tf_core/tf_if_tbl.c\n+++ b/drivers/net/bnxt/tf_core/tf_if_tbl.c\n@@ -16,24 +16,16 @@ struct tf;\n \n /**\n * IF Table DBs.\n+ * TODO: Store this data in session db\n */\n static void *if_tbl_db[TF_DIR_MAX];\n \n-/**\n- * IF Table Shadow DBs\n- */\n-/* static void *shadow_if_tbl_db[TF_DIR_MAX]; */\n-\n /**\n * Init flag, set on bind and cleared on unbind\n+ * TODO: Store this data in session db\n */\n static uint8_t init;\n \n-/**\n- * Shadow init flag, set on bind and cleared on unbind\n- */\n-/* static uint8_t shadow_init; */\n-\n /**\n * Convert if_tbl_type to hwrm type.\n *\n@@ -70,12 +62,6 @@ tf_if_tbl_bind(struct tf *tfp __rte_unused,\n {\n \tTF_CHECK_PARMS2(tfp, parms);\n \n-\tif (init) {\n-\t\tTFP_DRV_LOG(ERR,\n-\t\t\t \"IF TBL DB already initialized\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n \tif_tbl_db[TF_DIR_RX] = parms->cfg;\n \tif_tbl_db[TF_DIR_TX] = parms->cfg;\n \ndiff --git a/drivers/net/bnxt/tf_core/tf_session.c b/drivers/net/bnxt/tf_core/tf_session.c\nindex 93876d8e5d..e6ab518121 100644\n--- a/drivers/net/bnxt/tf_core/tf_session.c\n+++ b/drivers/net/bnxt/tf_core/tf_session.c\n@@ -425,9 +425,11 @@ tf_session_open_session(struct tf *tfp,\n \t\t}\n \n \t\tTFP_DRV_LOG(INFO,\n-\t\t \"Session created, session_client_id:%d, session_id:%d\\n\",\n+\t\t \"Session created, session_client_id:%d,\"\n+\t\t \"session_id:0x%08x, fw_session_id:%d\\n\",\n \t\t parms->open_cfg->session_client_id.id,\n-\t\t parms->open_cfg->session_id.id);\n+\t\t parms->open_cfg->session_id.id,\n+\t\t parms->open_cfg->session_id.internal.fw_session_id);\n \t} else {\n \t\tscparms.ctrl_chan_name = parms->open_cfg->ctrl_chan_name;\n \t\tscparms.session_client_id = &parms->open_cfg->session_client_id;\n@@ -438,16 +440,16 @@ tf_session_open_session(struct tf *tfp,\n \t\trc = tf_session_client_create(tfp, &scparms);\n \t\tif (rc) {\n \t\t\tTFP_DRV_LOG(ERR,\n-\t\t\t \"Failed to create client on session %d, rc:%s\\n\",\n+\t\t\t \"Failed to create client on session 0x%x, rc:%s\\n\",\n \t\t\t parms->open_cfg->session_id.id,\n \t\t\t strerror(-rc));\n \t\t\treturn rc;\n \t\t}\n \n \t\tTFP_DRV_LOG(INFO,\n-\t\t\t \"Session Client:%d created on session:%d\\n\",\n-\t\t\t parms->open_cfg->session_client_id.id,\n-\t\t\t parms->open_cfg->session_id.id);\n+\t\t\t\"Session Client:%d registered on session:0x%8x\\n\",\n+\t\t\tscparms.session_client_id->internal.fw_session_client_id,\n+\t\t\ttfp->session->session_id.id);\n \t}\n \n \treturn 0;\n@@ -541,7 +543,7 @@ tf_session_close_session(struct tf *tfp,\n \t\t\t client->session_client_id.id);\n \n \t\tTFP_DRV_LOG(INFO,\n-\t\t\t \"session_id:%d, ref_count:%d\\n\",\n+\t\t\t \"session_id:0x%08x, ref_count:%d\\n\",\n \t\t\t tfs->session_id.id,\n \t\t\t tfs->ref_count);\n \n@@ -587,7 +589,7 @@ tf_session_close_session(struct tf *tfp,\n \ttfs->ref_count--;\n \n \tTFP_DRV_LOG(INFO,\n-\t\t \"Closed session, session_id:%d, ref_count:%d\\n\",\n+\t\t \"Closed session, session_id:0x%08x, ref_count:%d\\n\",\n \t\t tfs->session_id.id,\n \t\t tfs->ref_count);\n \ndiff --git a/drivers/net/bnxt/tf_core/tf_tbl.c b/drivers/net/bnxt/tf_core/tf_tbl.c\nindex 295204ac87..6842291adf 100644\n--- a/drivers/net/bnxt/tf_core/tf_tbl.c\n+++ b/drivers/net/bnxt/tf_core/tf_tbl.c\n@@ -83,17 +83,15 @@ tf_tbl_bind(struct tf *tfp,\n \t\t\tdb_rc[d] = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n \t\telse\n \t\t\tdb_rc[d] = tf_rm_create_db(tfp, &db_cfg);\n-\t\tif (db_rc[d]) {\n-\t\t\tTFP_DRV_LOG(ERR,\n-\t\t\t\t \"%s: No Table DB creation required\\n\",\n-\t\t\t\t tf_dir_2_str(d));\n-\n-\t\t}\n \t}\n \n \t/* No db created */\n-\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX])\n+\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX]) {\n+\t\tTFP_DRV_LOG(ERR,\n+\t\t\t \"%s: No Table DB created\\n\",\n+\t\t\t tf_dir_2_str(d));\n \t\treturn db_rc[TF_DIR_RX];\n+\t}\n \n \tTFP_DRV_LOG(INFO,\n \t\t \"Table Type - initialized\\n\");\n@@ -112,12 +110,8 @@ tf_tbl_unbind(struct tf *tfp)\n \tTF_CHECK_PARMS1(tfp);\n \n \trc = tf_session_get_db(tfp, TF_MODULE_TYPE_TABLE, &tbl_db_ptr);\n-\tif (rc) {\n-\t\tTFP_DRV_LOG(INFO,\n-\t\t\t \"Tbl_db is not initialized, rc:%s\\n\",\n-\t\t\t strerror(-rc));\n+\tif (rc)\n \t\treturn 0;\n-\t}\n \ttbl_db = (struct tbl_rm_db *)tbl_db_ptr;\n \n \tfor (i = 0; i < TF_DIR_MAX; i++) {\ndiff --git a/drivers/net/bnxt/tf_core/tf_tcam.c b/drivers/net/bnxt/tf_core/tf_tcam.c\nindex 5c018f7003..7878f8727a 100644\n--- a/drivers/net/bnxt/tf_core/tf_tcam.c\n+++ b/drivers/net/bnxt/tf_core/tf_tcam.c\n@@ -113,16 +113,13 @@ tf_tcam_bind(struct tf *tfp,\n \t\t\tdb_rc[d] = tf_rm_create_db_no_reservation(tfp, &db_cfg);\n \t\telse\n \t\t\tdb_rc[d] = tf_rm_create_db(tfp, &db_cfg);\n-\t\tif (db_rc[d]) {\n-\t\t\tTFP_DRV_LOG(INFO,\n-\t\t\t\t \"%s: no TCAM DB required\\n\",\n-\t\t\t\t tf_dir_2_str(d));\n-\t\t}\n \t}\n \n \t/* No db created */\n-\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX])\n+\tif (db_rc[TF_DIR_RX] && db_rc[TF_DIR_TX]) {\n+\t\tTFP_DRV_LOG(ERR, \"No TCAM DB created\\n\");\n \t\treturn db_rc[TF_DIR_RX];\n+\t}\n \n \t/* check if reserved resource for WC is multiple of num_slices */\n \tfor (d = 0; d < TF_DIR_MAX; d++) {\n@@ -227,9 +224,6 @@ tf_tcam_unbind(struct tf *tfp)\n \n \trc = tf_session_get_db(tfp, TF_MODULE_TYPE_TCAM, &tcam_db_ptr);\n \tif (rc) {\n-\t\tTFP_DRV_LOG(INFO,\n-\t\t\t \"Tcam_db is not initialized, rc:%s\\n\",\n-\t\t\t strerror(-rc));\n \t\treturn 0;\n \t}\n \ttcam_db = (struct tcam_rm_db *)tcam_db_ptr;\n", "prefixes": [ "v2", "19/58" ] }