Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93901/?format=api
{ "id": 93901, "url": "https://patches.dpdk.org/api/patches/93901/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210604144225.287678-2-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210604144225.287678-2-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210604144225.287678-2-andrew.rybchenko@oktetlabs.ru", "date": "2021-06-04T14:42:15", "name": "[01/11] net/sfc: fix get xstats by ID callback to use MAC stats lock", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c7f159ae801c65f39bf66451698b6588840ce320", "submitter": { "id": 2013, "url": "https://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210604144225.287678-2-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 17239, "url": "https://patches.dpdk.org/api/series/17239/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17239", "date": "2021-06-04T14:42:14", "name": "net/sfc: provide Rx/Tx doorbells stats", "version": 1, "mbox": "https://patches.dpdk.org/series/17239/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93901/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/93901/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3E100A0A0F;\n\tFri, 4 Jun 2021 16:42:47 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8AE6A410E8;\n\tFri, 4 Jun 2021 16:42:42 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id E64AC4068F;\n Fri, 4 Jun 2021 16:42:40 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 87C2D7F68D; Fri, 4 Jun 2021 17:42:40 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id C43587F567;\n Fri, 4 Jun 2021 17:42:34 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C43587F567", "Authentication-Results": "shelob.oktetlabs.ru/C43587F567; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>, stable@dpdk.org,\n Andy Moreton <amoreton@xilinx.com>, Ivan Malov <ivan.malov@oktetlabs.ru>,\n Remy Horton <remy.horton@intel.com>", "Date": "Fri, 4 Jun 2021 17:42:15 +0300", "Message-Id": "<20210604144225.287678-2-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/11] net/sfc: fix get xstats by ID callback to\n use MAC stats lock", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nAdd MAC stats lock in get xstats by id callback before reading\nnumber of supported MAC stats.\n\nFixes: 73280c1e4ff (\"net/sfc: support xstats retrieval by ID\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 88896db1f8..d4ac61ff76 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -789,12 +789,14 @@ sfc_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n \tint ret;\n \tint rc;\n \n-\tif (unlikely(values == NULL) ||\n-\t unlikely((ids == NULL) && (n < port->mac_stats_nb_supported)))\n-\t\treturn port->mac_stats_nb_supported;\n-\n \trte_spinlock_lock(&port->mac_stats_lock);\n \n+\tif (unlikely(values == NULL) ||\n+\t unlikely(ids == NULL && n < port->mac_stats_nb_supported)) {\n+\t\tret = port->mac_stats_nb_supported;\n+\t\tgoto unlock;\n+\t}\n+\n \trc = sfc_port_update_mac_stats(sa);\n \tif (rc != 0) {\n \t\tSFC_ASSERT(rc > 0);\n", "prefixes": [ "01/11" ] }