Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9374/?format=api
{ "id": 9374, "url": "https://patches.dpdk.org/api/patches/9374/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1449427566-15782-2-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449427566-15782-2-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449427566-15782-2-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-06T18:46:06", "name": "[dpdk-dev,v2,2/2] mk: fix shared library dependencies of drivers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "45630962372745123a5a19675f2e6666afada703", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1449427566-15782-2-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/9374/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/9374/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 64883935A;\n\tSun, 6 Dec 2015 19:47:31 +0100 (CET)", "from mail-wm0-f44.google.com (mail-wm0-f44.google.com\n\t[74.125.82.44]) by dpdk.org (Postfix) with ESMTP id A6B7C9269\n\tfor <dev@dpdk.org>; Sun, 6 Dec 2015 19:47:30 +0100 (CET)", "by wmww144 with SMTP id w144so116288983wmw.1\n\tfor <dev@dpdk.org>; Sun, 06 Dec 2015 10:47:30 -0800 (PST)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by smtp.gmail.com with ESMTPSA id\n\tvr10sm21850853wjc.38.2015.12.06.10.47.29\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tSun, 06 Dec 2015 10:47:29 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=jwVz6W9zfe0pKHWyRWcQC8KR7Mavinrc0kxvk8uKT6w=;\n\tb=x7yg8gCAhdgIGbsYkjaFkiTo90W6eUEAOQLA+ek4N99qKwpM13sBWGvIxptNLPShI1\n\tEo49ipppGqHwdF+6oRK/0W+ma+0WZ2LS9qx+7Zb5NlZ7MWeSOPNQOVJGDffOG59nB1kz\n\tAhMAOLoztTzvpW+76vNRb30Mik2c1p5qHJqLFyGy94g0FgP55AhM6mU2XB+G18r+ZzGv\n\tpz1reT+YA7lo4mdiQa3Vqk+GV71OzjYEe2ghfRSja9iJ997+SyL/Y/LhVqMRKsCdpWWf\n\tlIjQIw+4pu0VxPBl0mmrSHYIfmQR25eyowys20HLu3NztP4eIsDjAU12YyYTLcsqiYsl\n\tNUfg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=jwVz6W9zfe0pKHWyRWcQC8KR7Mavinrc0kxvk8uKT6w=;\n\tb=JQstZc5+IQoiLUHCZKdFYxU0j+RqzKKGJuYEcIrNf70D/R1D/X/WOGA/06VqCBiYux\n\tPHgDJA+vb5q/TAyoaEz2IJcMWbAbDv/2mTJT4OQT8ERuHx3PoDHZX0XYPqRUqTnYjT3t\n\t2gNkWr7M8ejzmyD4XqOcP2lgzY01N+cUBAhOYK7OuNxSCRu9QWOHxxYHug+qdntWE4MK\n\tv57kUvDbgWC1tqmLagk+9vKYG/zpNKQM7F8ZwqBAHuoQw7zClxODALngs1TbSFIyoh3s\n\thQPiDCxZOdL2p26/BeLMhWhxUC67VlFK6mcLiH5MWVXU6gWktTdY+JR4AjtJdOvgAH6C\n\tKARQ==", "X-Gm-Message-State": "ALoCoQlgz28zINjdVyHssh+CTocp7XQATKsrmM9YgGe9BGxpwFXVAgGRZj4KgvkjWIdEwYZexoz8", "X-Received": "by 10.194.178.70 with SMTP id cw6mr28907071wjc.73.1449427650488; \n\tSun, 06 Dec 2015 10:47:30 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Panu Matilainen <pmatilai@redhat.com>", "Date": "Sun, 6 Dec 2015 19:46:06 +0100", "Message-Id": "<1449427566-15782-2-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "In-Reply-To": "<1449427566-15782-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<ee5b1caf719262b06bbf0b8b134b250abd0865d3.1445437070.git.pmatilai@redhat.com>\n\t<1449427566-15782-1-git-send-email-thomas.monjalon@6wind.com>", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH v2 2/2] mk: fix shared library dependencies of\n\tdrivers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Panu Matilainen <pmatilai@redhat.com>\n\nSimilar to commit 113c8e13c4201eee207723571f83aaf285277d75, but\nfor bnx2x, pcap, sze2data and xenvirt PMDs.\n\nRequiring applications to know about library internal details like\ndependencies to external helper libraries is a limitation of\nstatic linkage, shared libraries should always know their own\ndependencies for sane operation. This is especially highlighted\nwith dlopen()'ed items, having applications link against about plugin\ninternal dependencies goes on the side of absurd.\n\nNote that linking with a shared combined library still requires to\nknow the internal dependencies.\n\nSigned-off-by: Panu Matilainen <pmatilai@redhat.com>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n drivers/net/bnx2x/Makefile | 1 +\n drivers/net/pcap/Makefile | 1 +\n drivers/net/szedata2/Makefile | 1 +\n drivers/net/xenvirt/Makefile | 1 +\n mk/rte.app.mk | 12 ++++--------\n 5 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile\nindex 87f31b6..d895d8c 100644\n--- a/drivers/net/bnx2x/Makefile\n+++ b/drivers/net/bnx2x/Makefile\n@@ -8,6 +8,7 @@ LIB = librte_pmd_bnx2x.a\n CFLAGS += -O3 -g\n CFLAGS += $(WERROR_FLAGS)\n CFLAGS += -DZLIB_CONST\n+LDLIBS += -lz\n \n EXPORT_MAP := rte_pmd_bnx2x_version.map\n \ndiff --git a/drivers/net/pcap/Makefile b/drivers/net/pcap/Makefile\nindex 48be913..b41d8a2 100644\n--- a/drivers/net/pcap/Makefile\n+++ b/drivers/net/pcap/Makefile\n@@ -39,6 +39,7 @@ LIB = librte_pmd_pcap.a\n \n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n+LDLIBS += -lpcap\n \n EXPORT_MAP := rte_pmd_pcap_version.map\n \ndiff --git a/drivers/net/szedata2/Makefile b/drivers/net/szedata2/Makefile\nindex c3c42e5..963a8d6 100644\n--- a/drivers/net/szedata2/Makefile\n+++ b/drivers/net/szedata2/Makefile\n@@ -38,6 +38,7 @@ LIB = librte_pmd_szedata2.a\n \n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n+LDLIBS += -lsze2\n \n EXPORT_MAP := rte_pmd_szedata2_version.map\n \ndiff --git a/drivers/net/xenvirt/Makefile b/drivers/net/xenvirt/Makefile\nindex 9c521d5..1d05b71 100644\n--- a/drivers/net/xenvirt/Makefile\n+++ b/drivers/net/xenvirt/Makefile\n@@ -38,6 +38,7 @@ LIB = librte_pmd_xenvirt.a\n \n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n+LDLIBS += -lxenstore\n \n EXPORT_MAP := rte_eth_xenvirt_version.map\n \ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 3f56852..90ec33d 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -90,10 +90,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lrte_vhost\n \n endif # ! CONFIG_RTE_BUILD_COMBINE_LIBS\n \n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lpcap\n-\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) += -lsze2\n-\n ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lnuma\n endif\n@@ -106,13 +102,13 @@ endif\n # The combined library fails also to store this information.\n # So linking with static or combined library requires explicit dependencies.\n ifneq ($(CONFIG_RTE_BUILD_COMBINE_LIBS)$(CONFIG_RTE_BUILD_SHARED_LIB),ny)\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lpcap\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz\n _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -libverbs\n _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -libverbs\n-endif # CONFIG_RTE_BUILD_COMBINE_LIBS or not CONFIG_RTE_BUILD_SHARED_LIBS\n-\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz\n-\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) += -lsze2\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lxenstore\n+endif # CONFIG_RTE_BUILD_COMBINE_LIBS or not CONFIG_RTE_BUILD_SHARED_LIBS\n \n _LDLIBS-y += --start-group\n \n", "prefixes": [ "dpdk-dev", "v2", "2/2" ] }