Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93608/?format=api
{ "id": 93608, "url": "https://patches.dpdk.org/api/patches/93608/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210531072644.24656-2-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210531072644.24656-2-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210531072644.24656-2-kalesh-anakkur.purayil@broadcom.com", "date": "2021-05-31T07:26:36", "name": "[1/9] net/bnxt: fix error message when VNIC prepare fails", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3ff0d4b59a5d54a999e9d1e6bc1d159c886b4cb3", "submitter": { "id": 1479, "url": "https://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210531072644.24656-2-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 17167, "url": "https://patches.dpdk.org/api/series/17167/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17167", "date": "2021-05-31T07:26:35", "name": "bnxt PMD fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/17167/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93608/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/93608/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AED42A0524;\n\tMon, 31 May 2021 09:05:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5926340E50;\n\tMon, 31 May 2021 09:05:23 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (lpdvacalvio01.broadcom.com\n [192.19.229.182])\n by mails.dpdk.org (Postfix) with ESMTP id 989BA40040\n for <dev@dpdk.org>; Mon, 31 May 2021 09:05:20 +0200 (CEST)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id A755422591;\n Mon, 31 May 2021 00:05:18 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com A755422591", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1622444719;\n bh=yMJYusSgvbpR+xQwlOL1cs6wkSSgbUXnw6yH+K7bbJ8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=KBmqMTsHIES+qGV/HooV9IXHsCfrx1yxfV4+l0iuK0LNBuKdyc5g/8xpsXXc+XGfv\n aPdS4EdCsdm4Ak3lWiwdv7oYvhy0UimcwMaBFFFOajWnz+o6rmp8e9fLRcj86Do9qt\n +djzZnm5c+gLyQ+TRrZvf/Mn+QsHfS+ODoRXmkI8=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Mon, 31 May 2021 12:56:36 +0530", "Message-Id": "<20210531072644.24656-2-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20210531072644.24656-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20210531072644.24656-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 1/9] net/bnxt: fix error message when VNIC\n prepare fails", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nThe bnxt_vnic_prep() can fail due to multiple reasons.\nBut when bnxt_vnic_prep() fails, PMD is not returning\nthe actual error/string to the application.\n\nFix it by moving the \"rte_flow_error_set\" to bnxt_vnic_prep()\nto set the actual error code.\n\nFixes: d24610f7bfda (\"net/bnxt: allow flow creation when RSS is enabled\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 66 +++++++++++++++++++++++++++-----------------\n 1 file changed, 40 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 73fd24c..66012b8 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -919,32 +919,46 @@ bnxt_get_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,\n \treturn l2_filter;\n }\n \n-static int bnxt_vnic_prep(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n+static int bnxt_vnic_prep(struct bnxt *bp, struct bnxt_vnic_info *vnic,\n+\t\t\t const struct rte_flow_action *act,\n+\t\t\t struct rte_flow_error *error)\n {\n \tstruct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;\n \tuint64_t rx_offloads = dev_conf->rxmode.offloads;\n \tint rc;\n \n \tif (bp->nr_vnics > bp->max_vnics - 1)\n-\t\treturn -ENOMEM;\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_GROUP,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"Group id is invalid\");\n \n \trc = bnxt_vnic_grp_alloc(bp, vnic);\n \tif (rc)\n-\t\tgoto ret;\n+\t\treturn rte_flow_error_set(error, -rc,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"Failed to alloc VNIC group\");\n \n \trc = bnxt_hwrm_vnic_alloc(bp, vnic);\n \tif (rc) {\n-\t\tPMD_DRV_LOG(ERR, \"HWRM vnic alloc failure rc: %x\\n\", rc);\n+\t\trte_flow_error_set(error, -rc,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t act,\n+\t\t\t\t \"Failed to alloc VNIC\");\n \t\tgoto ret;\n \t}\n+\n \tbp->nr_vnics++;\n \n \t/* RSS context is required only when there is more than one RSS ring */\n \tif (vnic->rx_queue_cnt > 1) {\n \t\trc = bnxt_hwrm_vnic_ctx_alloc(bp, vnic, 0 /* ctx_idx 0 */);\n \t\tif (rc) {\n-\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t \"HWRM vnic ctx alloc failure: %x\\n\", rc);\n+\t\t\trte_flow_error_set(error, -rc,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t act,\n+\t\t\t\t\t \"Failed to alloc VNIC context\");\n \t\t\tgoto ret;\n \t\t}\n \t} else {\n@@ -957,10 +971,24 @@ static int bnxt_vnic_prep(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n \t\tvnic->vlan_strip = false;\n \n \trc = bnxt_hwrm_vnic_cfg(bp, vnic);\n-\tif (rc)\n+\tif (rc) {\n+\t\trte_flow_error_set(error, -rc,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t act,\n+\t\t\t\t \"Failed to configure VNIC\");\n \t\tgoto ret;\n+\t}\n \n-\tbnxt_hwrm_vnic_plcmode_cfg(bp, vnic);\n+\trc = bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);\n+\tif (rc) {\n+\t\trte_flow_error_set(error, -rc,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t act,\n+\t\t\t\t \"Failed to configure VNIC plcmode\");\n+\t\tgoto ret;\n+\t}\n+\n+\treturn 0;\n \n ret:\n \treturn rc;\n@@ -1142,16 +1170,9 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \n \t\tPMD_DRV_LOG(DEBUG, \"VNIC found\\n\");\n \n-\t\trc = bnxt_vnic_prep(bp, vnic);\n-\t\tif (rc) {\n-\t\t\trte_flow_error_set(error,\n-\t\t\t\t\t EINVAL,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n-\t\t\t\t\t act,\n-\t\t\t\t\t \"VNIC prep fail\");\n-\t\t\trc = -rte_errno;\n+\t\trc = bnxt_vnic_prep(bp, vnic, act, error);\n+\t\tif (rc)\n \t\t\tgoto ret;\n-\t\t}\n \n \t\tPMD_DRV_LOG(DEBUG,\n \t\t\t \"vnic[%d] = %p vnic->fw_grp_ids = %p\\n\",\n@@ -1362,16 +1383,9 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\tvnic->end_grp_id = rss->queue[rss->queue_num - 1];\n \t\tvnic->func_default = 0;\t//This is not a default VNIC.\n \n-\t\trc = bnxt_vnic_prep(bp, vnic);\n-\t\tif (rc) {\n-\t\t\trte_flow_error_set(error,\n-\t\t\t\t\t EINVAL,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n-\t\t\t\t\t act,\n-\t\t\t\t\t \"VNIC prep fail\");\n-\t\t\trc = -rte_errno;\n+\t\trc = bnxt_vnic_prep(bp, vnic, act, error);\n+\t\tif (rc)\n \t\t\tgoto ret;\n-\t\t}\n \n \t\tPMD_DRV_LOG(DEBUG,\n \t\t\t \"vnic[%d] = %p vnic->fw_grp_ids = %p\\n\",\n", "prefixes": [ "1/9" ] }