Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93524/?format=api
{ "id": 93524, "url": "https://patches.dpdk.org/api/patches/93524/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1622189463-392610-2-git-send-email-jiayu.hu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1622189463-392610-2-git-send-email-jiayu.hu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1622189463-392610-2-git-send-email-jiayu.hu@intel.com", "date": "2021-05-28T08:11:02", "name": "[1/2] vhost: fix lock on device readiness notification", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1b53d7198327b9d592b4eded6f55886da680e2b1", "submitter": { "id": 539, "url": "https://patches.dpdk.org/api/people/539/?format=api", "name": "Hu, Jiayu", "email": "jiayu.hu@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1622189463-392610-2-git-send-email-jiayu.hu@intel.com/mbox/", "series": [ { "id": 17148, "url": "https://patches.dpdk.org/api/series/17148/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17148", "date": "2021-05-28T08:11:01", "name": "provide thread unsafe async registration functions", "version": 1, "mbox": "https://patches.dpdk.org/series/17148/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93524/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/93524/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9CDA7A0547;\n\tFri, 28 May 2021 03:42:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BC0F9410F2;\n\tFri, 28 May 2021 03:42:46 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 7912140040;\n Fri, 28 May 2021 03:42:43 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 May 2021 18:42:42 -0700", "from npg_dpdk_virtio_jiayuhu_07.sh.intel.com ([10.67.118.193])\n by orsmga001.jf.intel.com with ESMTP; 27 May 2021 18:42:40 -0700" ], "IronPort-SDR": [ "\n ivxOOgJYXjlnf/4KJvZ4CTivdKcXdTV3+VQZJzKgLA8SptIYqKmZKrY5qo38quGawwSBS7y99c\n GO5a0lQiBCYg==", "\n i0Wdutpn4Sl4wttMIPYf09MS8UlwvEQT6epkblYSSSZ1bd2sgW7MVSlbeoDiblyszqUgHZzD11\n cErRd7HKtOxA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9997\"; a=\"266760003\"", "E=Sophos;i=\"5.83,228,1616482800\"; d=\"scan'208\";a=\"266760003\"", "E=Sophos;i=\"5.83,228,1616482800\"; d=\"scan'208\";a=\"477732985\"" ], "X-ExtLoop1": "1", "From": "Jiayu Hu <jiayu.hu@intel.com>", "To": "dev@dpdk.org", "Cc": "maxime.coquelin@redhat.com, chenbo.xia@intel.com, yinan.wang@intel.com,\n Jiayu Hu <jiayu.hu@intel.com>, stable@dpdk.org", "Date": "Fri, 28 May 2021 04:11:02 -0400", "Message-Id": "<1622189463-392610-2-git-send-email-jiayu.hu@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1622189463-392610-1-git-send-email-jiayu.hu@intel.com>", "References": "<1622189463-392610-1-git-send-email-jiayu.hu@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/2] vhost: fix lock on device readiness\n notification", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The vhost notifies the application of device readiness via\nvhost_user_notify_queue_state(), but calling this function\nis not protected by the lock. This patch is to make this\nfunction call lock protected.\n\nFixes: d0fcc38f5fa4 (\"vhost: improve device readiness notifications\")\nCc: stable@dpdk.org\nSigned-off-by: Jiayu Hu <jiayu.hu@intel.com>\n---\n lib/vhost/vhost_user.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 8f0eba6..dabce26 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -2915,9 +2915,6 @@ vhost_user_msg_handler(int vid, int fd)\n \t\t}\n \t}\n \n-\tif (unlock_required)\n-\t\tvhost_user_unlock_all_queue_pairs(dev);\n-\n \t/* If message was not handled at this stage, treat it as an error */\n \tif (!handled) {\n \t\tVHOST_LOG_CONFIG(ERR,\n@@ -2952,6 +2949,8 @@ vhost_user_msg_handler(int vid, int fd)\n \t\t}\n \t}\n \n+\tif (unlock_required)\n+\t\tvhost_user_unlock_all_queue_pairs(dev);\n \n \tif (!virtio_is_ready(dev))\n \t\tgoto out;\n", "prefixes": [ "1/2" ] }