Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93506/?format=api
{ "id": 93506, "url": "https://patches.dpdk.org/api/patches/93506/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210527152510.1551026-8-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210527152510.1551026-8-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210527152510.1551026-8-andrew.rybchenko@oktetlabs.ru", "date": "2021-05-27T15:24:57", "name": "[07/20] common/sfc_efx/base: add ingress m-port RxQ flag", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3afb972dfa29c63d0dd402844c0b5d9615e81246", "submitter": { "id": 2013, "url": "https://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210527152510.1551026-8-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 17144, "url": "https://patches.dpdk.org/api/series/17144/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17144", "date": "2021-05-27T15:24:50", "name": "net/sfc: support flow API COUNT action", "version": 1, "mbox": "https://patches.dpdk.org/series/17144/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93506/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/93506/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 33921A0546;\n\tThu, 27 May 2021 17:26:40 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A1F6841122;\n\tThu, 27 May 2021 17:26:02 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 6D6FD41111\n for <dev@dpdk.org>; Thu, 27 May 2021 17:26:00 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 43CD27F5FC; Thu, 27 May 2021 18:26:00 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 584937F600;\n Thu, 27 May 2021 18:25:42 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 584937F600", "Authentication-Results": "shelob.oktetlabs.ru/584937F600; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Igor Romanov <igor.romanov@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>, Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Thu, 27 May 2021 18:24:57 +0300", "Message-Id": "<20210527152510.1551026-8-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210527152510.1551026-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210527152510.1551026-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 07/20] common/sfc_efx/base: add ingress m-port\n RxQ flag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nAdd a flag to request support for ingress m-port on an RxQ.\nImplement it only for Riverhead, other families will return an error\nif the flag is set.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\nReviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/common/sfc_efx/base/ef10_rx.c | 9 ++++++++-\n drivers/common/sfc_efx/base/efx.h | 5 +++++\n drivers/common/sfc_efx/base/efx_rx.c | 14 +++++++++-----\n drivers/common/sfc_efx/base/rhead_rx.c | 3 +++\n 4 files changed, 25 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_rx.c b/drivers/common/sfc_efx/base/ef10_rx.c\nindex cfa60bd324..0e140645a5 100644\n--- a/drivers/common/sfc_efx/base/ef10_rx.c\n+++ b/drivers/common/sfc_efx/base/ef10_rx.c\n@@ -1031,6 +1031,11 @@ ef10_rx_qcreate(\n \tEFSYS_ASSERT(params.es_bufs_per_desc == 0);\n #endif /* EFSYS_OPT_RX_ES_SUPER_BUFFER */\n \n+\tif (flags & EFX_RXQ_FLAG_INGRESS_MPORT) {\n+\t\trc = ENOTSUP;\n+\t\tgoto fail12;\n+\t}\n+\n \t/* Scatter can only be disabled if the firmware supports doing so */\n \tif (flags & EFX_RXQ_FLAG_SCATTER)\n \t\tparams.disable_scatter = B_FALSE;\n@@ -1044,7 +1049,7 @@ ef10_rx_qcreate(\n \n \tif ((rc = efx_mcdi_init_rxq(enp, ndescs, eep, label, index,\n \t\t esmp, ¶ms)) != 0)\n-\t\tgoto fail12;\n+\t\tgoto fail13;\n \n \terp->er_eep = eep;\n \terp->er_label = label;\n@@ -1057,6 +1062,8 @@ ef10_rx_qcreate(\n \n \treturn (0);\n \n+fail13:\n+\tEFSYS_PROBE(fail13);\n fail12:\n \tEFSYS_PROBE(fail12);\n #if EFSYS_OPT_RX_ES_SUPER_BUFFER\ndiff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex 6a99099ad2..72ab4af01c 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -2925,6 +2925,7 @@ typedef enum efx_rx_prefix_field_e {\n \tEFX_RX_PREFIX_FIELD_USER_MARK_VALID,\n \tEFX_RX_PREFIX_FIELD_CSUM_FRAME,\n \tEFX_RX_PREFIX_FIELD_INGRESS_VPORT,\n+\tEFX_RX_PREFIX_FIELD_INGRESS_MPORT = EFX_RX_PREFIX_FIELD_INGRESS_VPORT,\n \tEFX_RX_PREFIX_NFIELDS\n } efx_rx_prefix_field_t;\n \n@@ -2998,6 +2999,10 @@ typedef enum efx_rxq_type_e {\n * the driver.\n */\n #define\tEFX_RXQ_FLAG_RSS_HASH\t\t0x4\n+/*\n+ * Request ingress mport field in the Rx prefix of a queue.\n+ */\n+#define\tEFX_RXQ_FLAG_INGRESS_MPORT\t0x8\n \n LIBEFX_API\n extern\t__checkReturn\tefx_rc_t\ndiff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c\nindex 7c6fecf925..7e63363be7 100644\n--- a/drivers/common/sfc_efx/base/efx_rx.c\n+++ b/drivers/common/sfc_efx/base/efx_rx.c\n@@ -1743,14 +1743,20 @@ siena_rx_qcreate(\n \t\tgoto fail2;\n \t}\n \n-\tif (flags & EFX_RXQ_FLAG_SCATTER) {\n #if EFSYS_OPT_RX_SCATTER\n-\t\tjumbo = B_TRUE;\n+#define SUPPORTED_RXQ_FLAGS EFX_RXQ_FLAG_SCATTER\n #else\n+#define SUPPORTED_RXQ_FLAGS EFX_RXQ_FLAG_NONE\n+#endif\n+\t/* Reject flags for unsupported queue features */\n+\tif ((flags & ~SUPPORTED_RXQ_FLAGS) != 0) {\n \t\trc = EINVAL;\n \t\tgoto fail3;\n-#endif\t/* EFSYS_OPT_RX_SCATTER */\n \t}\n+#undef SUPPORTED_RXQ_FLAGS\n+\n+\tif (flags & EFX_RXQ_FLAG_SCATTER)\n+\t\tjumbo = B_TRUE;\n \n \t/* Set up the new descriptor queue */\n \tEFX_POPULATE_OWORD_7(oword,\n@@ -1769,10 +1775,8 @@ siena_rx_qcreate(\n \n \treturn (0);\n \n-#if !EFSYS_OPT_RX_SCATTER\n fail3:\n \tEFSYS_PROBE(fail3);\n-#endif\n fail2:\n \tEFSYS_PROBE(fail2);\n fail1:\ndiff --git a/drivers/common/sfc_efx/base/rhead_rx.c b/drivers/common/sfc_efx/base/rhead_rx.c\nindex b2dacbab32..f1d46f7c70 100644\n--- a/drivers/common/sfc_efx/base/rhead_rx.c\n+++ b/drivers/common/sfc_efx/base/rhead_rx.c\n@@ -629,6 +629,9 @@ rhead_rx_qcreate(\n \t\tfields_mask |= 1U << EFX_RX_PREFIX_FIELD_RSS_HASH_VALID;\n \t}\n \n+\tif (flags & EFX_RXQ_FLAG_INGRESS_MPORT)\n+\t\tfields_mask |= 1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT;\n+\n \t/*\n \t * LENGTH is required in EF100 host interface, as receive events\n \t * do not include the packet length.\n", "prefixes": [ "07/20" ] }