Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93319/?format=api
{ "id": 93319, "url": "https://patches.dpdk.org/api/patches/93319/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1621425281-2413-1-git-send-email-fengchengwen@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1621425281-2413-1-git-send-email-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1621425281-2413-1-git-send-email-fengchengwen@huawei.com", "date": "2021-05-19T11:54:41", "name": "[v2] net/hns3: fix compile error with gcc8.3 and thunderx2", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "c104ce734211b226e307ea1e0f00e083c832a06a", "submitter": { "id": 2146, "url": "https://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1621425281-2413-1-git-send-email-fengchengwen@huawei.com/mbox/", "series": [ { "id": 17030, "url": "https://patches.dpdk.org/api/series/17030/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17030", "date": "2021-05-19T11:54:41", "name": "[v2] net/hns3: fix compile error with gcc8.3 and thunderx2", "version": 2, "mbox": "https://patches.dpdk.org/series/17030/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93319/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/93319/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55B17A0547;\n\tWed, 19 May 2021 13:57:47 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 15DAC40041;\n\tWed, 19 May 2021 13:57:47 +0200 (CEST)", "from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by mails.dpdk.org (Postfix) with ESMTP id 48B454003F\n for <dev@dpdk.org>; Wed, 19 May 2021 13:57:45 +0200 (CEST)", "from dggems706-chm.china.huawei.com (unknown [172.30.72.59])\n by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FlWXH0HJbzmXLF;\n Wed, 19 May 2021 19:55:27 +0800 (CST)", "from dggpeml500024.china.huawei.com (7.185.36.10) by\n dggems706-chm.china.huawei.com (10.3.19.183) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2176.2; Wed, 19 May 2021 19:57:43 +0800", "from localhost.localdomain (10.67.165.24) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2176.2; Wed, 19 May 2021 19:57:42 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@intel.com>,\n <david.marchand@redhat.com>", "CC": "<dev@dpdk.org>, <Honnappa.Nagarahalli@arm.com>, <jerinj@marvell.com>,\n <jerinjacobk@gmail.com>, <Ruifeng.Wang@arm.com>, <viktorin@rehivetech.com>,\n <bruce.richardson@intel.com>, <juraj.linkes@pantheon.tech>, <nd@arm.com>", "Date": "Wed, 19 May 2021 19:54:41 +0800", "Message-ID": "<1621425281-2413-1-git-send-email-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.8.1", "In-Reply-To": "<1621424821-53240-1-git-send-email-fengchengwen@huawei.com>", "References": "<1621424821-53240-1-git-send-email-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.67.165.24]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v2] net/hns3: fix compile error with gcc8.3 and\n thunderx2", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Compile error with gcc8.3 and crossfile arm64_thunderx2_linux_gcc:\n\t../drivers/net/hns3/hns3_rxtx_vec_sve.c\n\tcc1: error: switch ‘-mcpu=armv8.1-a’ conflicts with\n\t‘-march=armv8.2-a’ switch [-Werror]\n\t../drivers/net/hns3/hns3_rxtx_vec_sve.c:5:10: fatal error:\n\tarm_sve.h: No such file or directory\n\t 5 | #include <arm_sve.h>\n\nThe root cause is that gcc8.3 supports SVE, but it doesn't support\ncompile ACLE[1] SVE code, and the hns3_rxtx_vec_sve.c was written\nby ACLE SVE code.\n\nThis patch also filters out '-march=' '-mcpu' '-mtune' when compile\nwith hns3_rxtx_vec_sve.c.\n\n[1] ACLE: Arm C Language Extensions, user should include <arm_sve.h>\nwhen writing ACLE SVE code.\n\nFixes: 203fbaf8813d (\"net/hns3: refactor SVE code compile method\")\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\nv2:\n* fix check tool error\n---\n drivers/net/hns3/meson.build | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build\nindex 8563d70..5f9af9b 100644\n--- a/drivers/net/hns3/meson.build\n+++ b/drivers/net/hns3/meson.build\n@@ -39,16 +39,22 @@ if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')\n # compile SVE when:\n # a. support SVE in minimum instruction set baseline\n # b. it's not minimum instruction set, but compiler support\n- if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != ''\n+ if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' and cc.check_header('arm_sve.h')\n cflags += ['-DCC_SVE_SUPPORT']\n sources += files('hns3_rxtx_vec_sve.c')\n- elif cc.has_argument('-march=armv8.2-a+sve')\n- cflags += ['-DCC_SVE_SUPPORT']\n+ elif cc.has_argument('-march=armv8.2-a+sve') and cc.check_header('arm_sve.h')\n+ sve_cflags = ['-DCC_SVE_SUPPORT']\n+ foreach flag: cflags\n+ # filterout -march -mcpu -mtune\n+ if not (flag.startswith('-march=') or flag.startswith('-mcpu=') or flag.startswith('-mtune='))\n+ sve_cflags += flag\n+ endif\n+ endforeach\n hns3_sve_lib = static_library('hns3_sve_lib',\n 'hns3_rxtx_vec_sve.c',\n dependencies: [static_rte_ethdev],\n include_directories: includes,\n- c_args: [cflags, '-march=armv8.2-a+sve'])\n+ c_args: [sve_cflags, '-march=armv8.2-a+sve'])\n objs += hns3_sve_lib.extract_objects('hns3_rxtx_vec_sve.c')\n endif\n endif\n", "prefixes": [ "v2" ] }