Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93257/?format=api
{ "id": 93257, "url": "https://patches.dpdk.org/api/patches/93257/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1620911283-55627-2-git-send-email-fengchengwen@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1620911283-55627-2-git-send-email-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1620911283-55627-2-git-send-email-fengchengwen@huawei.com", "date": "2021-05-13T13:08:02", "name": "[v4,1/2] config/arm: select most suitable -march for kunpeng soc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4f966d9b309e3b981b25402991cefb03a2c832a7", "submitter": { "id": 2146, "url": "https://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1620911283-55627-2-git-send-email-fengchengwen@huawei.com/mbox/", "series": [ { "id": 16985, "url": "https://patches.dpdk.org/api/series/16985/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16985", "date": "2021-05-13T13:08:03", "name": "bugfix for Kunpeng SVE compile", "version": 4, "mbox": "https://patches.dpdk.org/series/16985/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93257/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/93257/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B9710A0A02;\n\tThu, 13 May 2021 15:11:21 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F021E41108;\n\tThu, 13 May 2021 15:11:13 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 81ABC4003F\n for <dev@dpdk.org>; Thu, 13 May 2021 15:11:10 +0200 (CEST)", "from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FgsQQ34V3zQmxB;\n Thu, 13 May 2021 21:07:42 +0800 (CST)", "from localhost.localdomain (10.67.165.24) by\n DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id\n 14.3.498.0; Thu, 13 May 2021 21:11:02 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <jerinj@marvell.com>, <ruifeng.wang@arm.com>,\n <viktorin@rehivetech.com>, <bruce.richardson@intel.com>,\n <Honnappa.Nagarahalli@arm.com>, <jerinjacobk@gmail.com>,\n <juraj.linkes@pantheon.tech>, <nd@arm.com>", "Date": "Thu, 13 May 2021 21:08:02 +0800", "Message-ID": "<1620911283-55627-2-git-send-email-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.8.1", "In-Reply-To": "<1620911283-55627-1-git-send-email-fengchengwen@huawei.com>", "References": "<1620808126-18876-1-git-send-email-fengchengwen@huawei.com>\n <1620911283-55627-1-git-send-email-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.24]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v4 1/2] config/arm: select most suitable -march\n for kunpeng soc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the soc_kunpeng930 declares '-march=armv8.2-a+crypto+sve',\nbut some compiler doesn't recognize the march because it doesn't\nsupport sve.\n\nTo solve this bug we use the following scheme:\n1. Define 'march_base' tuple which defines support march, it should\narrange from lower to higher.\ne.g. 'march_base' : ['-march=armv8-a', '-march=armv8.2-a']\n2. Define 'march_feature' tuple which defines support feature.\ne.g. 'march_feature' : ['crypto', 'sve']\n3. Select the most suitable march+feature combination based on\n'march_base' and 'march_feature' tuples.\n4. Use the selected march+feature combination as the default\nmachine_args.\n\nFixes: 7cf32a22b240 (\"config/arm: add Hisilicon kunpeng\")\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n config/arm/meson.build | 27 +++++++++++++++++++++++++--\n 1 file changed, 25 insertions(+), 2 deletions(-)", "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 3f34ec9..8551a80 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -149,7 +149,9 @@ implementer_hisilicon = {\n ],\n 'part_number_config': {\n '0xd01': {\n- 'machine_args': ['-march=armv8.2-a+crypto', '-mtune=tsv110'],\n+ 'march_base' : ['-march=armv8-a', '-march=armv8.2-a'],\n+ 'march_feature' : ['crypto'],\n+ 'machine_args': ['-mtune=tsv110'],\n 'flags': [\n ['RTE_MACHINE', '\"Kunpeng 920\"'],\n ['RTE_ARM_FEATURE_ATOMICS', true],\n@@ -158,7 +160,9 @@ implementer_hisilicon = {\n ]\n },\n '0xd02': {\n- 'machine_args': ['-march=armv8.2-a+crypto+sve'],\n+ 'march_base' : ['-march=armv8-a', '-march=armv8.2-a'],\n+ 'march_feature' : ['crypto', 'sve'],\n+ 'machine_args': [],\n 'flags': [\n ['RTE_MACHINE', '\"Kunpeng 930\"'],\n ['RTE_ARM_FEATURE_ATOMICS', true],\n@@ -449,8 +453,27 @@ else\n # add/overwrite flags in the proper order\n dpdk_flags = flags_common + implementer_config['flags'] + part_number_config.get('flags', []) + soc_flags\n \n+ # select the most suitable march+feature combination\n+ machine_march = []\n+ if part_number_config.has_key('march_base')\n+ foreach arch: part_number_config['march_base']\n+ if cc.has_argument(arch)\n+ machine_march = arch # Set the higher supported arch as possible\n+ endif\n+ endforeach\n+ endif\n+ if part_number_config.has_key('march_feature')\n+ foreach feature: part_number_config['march_feature']\n+ tmp_machine_march = machine_march + '+' + feature\n+ if cc.has_argument(tmp_machine_march)\n+ machine_march = tmp_machine_march # Set the more supported feature as possible\n+ endif\n+ endforeach\n+ endif\n+\n # apply supported machine args\n machine_args = [] # Clear previous machine args\n+ machine_args += machine_march\n foreach flag: part_number_config['machine_args']\n if cc.has_argument(flag)\n machine_args += flag\n", "prefixes": [ "v4", "1/2" ] }