Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93200/?format=api
{ "id": 93200, "url": "https://patches.dpdk.org/api/patches/93200/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210512101346.24803-2-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210512101346.24803-2-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210512101346.24803-2-mk@semihalf.com", "date": "2021-05-12T10:13:44", "name": "[v5,1/3] net/ena: indicate Rx RSS hash presence", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0ce84bcfda0e6e8c8b2a3d6f5b874648d1b4cb11", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210512101346.24803-2-mk@semihalf.com/mbox/", "series": [ { "id": 16955, "url": "https://patches.dpdk.org/api/series/16955/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16955", "date": "2021-05-12T10:13:43", "name": "net/ena: update ENA PMD to v2.3.0", "version": 5, "mbox": "https://patches.dpdk.org/series/16955/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93200/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/93200/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9B1B6A0C43;\n\tWed, 12 May 2021 12:14:28 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 07703410E3;\n\tWed, 12 May 2021 12:14:25 +0200 (CEST)", "from mail-lf1-f41.google.com (mail-lf1-f41.google.com\n [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id 35E8A410DF\n for <dev@dpdk.org>; Wed, 12 May 2021 12:14:23 +0200 (CEST)", "by mail-lf1-f41.google.com with SMTP id 2so32934025lft.4\n for <dev@dpdk.org>; Wed, 12 May 2021 03:14:23 -0700 (PDT)", "from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl.\n [89.79.189.199])\n by smtp.gmail.com with ESMTPSA id d26sm2892244lfa.118.2021.05.12.03.14.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 12 May 2021 03:14:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=d9MXBlKdhDkaV4GwG+h1Kj2PlflWwakmPHwuLvMDb50=;\n b=vv6iuQBrn3cV6jeWyzfBW/GFR5CnY7SNT7/L6mwqlOu6DIGrAiJfZEsLwrHwQkr3Iw\n EO7TfgYuC78gIlqYM45TmZa8waOcw2auG49VPoqm/Jtmk8lRr2I2QvCM5l9dTflcK5NU\n T96sZMcuQnZk/5mog4qOz+HOhAkhlsXdTuFfQ7lyfY/lsZ1ALDcIv2w0Fuq9iGIVoCRr\n IDr8Xv+QA2MiJoYp3IfQD2F5ReoxWjZ0j2/pQWjrA3OWhnGcwTnSPbLQ2wv4j9PXVPX9\n sP+a0vQpFcF28oHJBK1SAOysBp45lwU2V/x78OFgia2yYP5A6Rh8+odgq97WeJssOHK4\n 2BEw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=d9MXBlKdhDkaV4GwG+h1Kj2PlflWwakmPHwuLvMDb50=;\n b=FRjQCegR6cjFsnhDYiCI+CND5yH9MGptp7zrXiLvCiZXz3YE5aG2eiNPy0SPRyESWt\n thkXnGabk7MRcquXps97VUWrtPlmlMnSuUxhyuRDYta2nGzRlMohy+TVGtBJFgZ3b5vj\n 2DOMy4BRe5lYd9RI2E9YOY9E1iPki7eGY2NTuWY9bZwAfS6x/jqkcQRTiMXu0ZQzRPx6\n jB7R9JkfaevkbqGM+h1z28DqjmtnzsE9vK7ypvGE00ouCFqbP9TRf8eo3ZxJgZYcoM1T\n RLBumKx86xNrqzC1rGAoZTGm61Zdw5XRis9Lo58rmdjHesOKT/+fJ3VQKSY5boWYM2hp\n voXg==", "X-Gm-Message-State": "AOAM530aedakcEQUeywbSIcj/O9lUoXTfXfrIlvkSYrgR6JrpToT/zD0\n g3lcyERWgqQXXgAsBb7R4CJZjg==", "X-Google-Smtp-Source": "\n ABdhPJyfZ9utOP/Al10CLsKU2ynOGb7ac8zo1E2L1v3KWTxWMduDiVN4wH8msGJ6hWDAgLt7hdNhNQ==", "X-Received": "by 2002:a05:6512:2344:: with SMTP id\n p4mr24672077lfu.299.1620814462813;\n Wed, 12 May 2021 03:14:22 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com,\n upstream@semihalf.com, Michal Krawczyk <mk@semihalf.com>, stable@dpdk.org,\n Amit Bernstein <amitbern@amazon.com>", "Date": "Wed, 12 May 2021 12:13:44 +0200", "Message-Id": "<20210512101346.24803-2-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210512101346.24803-1-mk@semihalf.com>", "References": "\n <CAJMMOfMq4oXsn5+BiP3RNbntunCpA1b0-zXQV9+oLk4qdPSM=A@mail.gmail.com>\n <20210512101346.24803-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 1/3] net/ena: indicate Rx RSS hash presence", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To make it possible to the app to determine if the hash was calculated\nfor the packet or not, the PKT_RX_RSS_HASH should be set in the mbuf's\nol_flags.\n\nAs the PMD wasn't setting that, the application couldn't check if there\nis a hash in a proper way.\n\nThe hash is valid only if it's UDP or TCP and the IP packet wasn't\nfragmented.\n\nFixes: e5df9f33db00 (\"net/ena: fix passing RSS hash to mbuf\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\nv5:\n* Announce Rx RSS hash support in the dev_info->rx_offload_capa.\n\nv4:\n* Add release notes.\n* Always announce DEV_RX_OFFLOAD_RSS_HASH if RSS is enabled.\n\n doc/guides/rel_notes/release_21_05.rst | 1 +\n drivers/net/ena/ena_ethdev.c | 13 +++++++++++--\n 2 files changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst\nindex 4e669d3108..0466415112 100644\n--- a/doc/guides/rel_notes/release_21_05.rst\n+++ b/doc/guides/rel_notes/release_21_05.rst\n@@ -120,6 +120,7 @@ New Features\n * Updated ena_com (HAL) to the latest version.\n * Fixed bugs when requesting large LLQ headers using the devargs.\n * Fixed bug when the default ring size was set.\n+ * Added indication of the RSS hash presence in the mbuf.\n \n * **Updated Arkville PMD driver.**\n \ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 54d5e756cb..fb2b19cfdb 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -51,6 +51,8 @@\n \n #define ENA_MIN_RING_DESC\t128\n \n+#define ENA_PTYPE_HAS_HASH\t(RTE_PTYPE_L4_TCP | RTE_PTYPE_L4_UDP)\n+\n enum ethtool_stringset {\n \tETH_SS_TEST = 0,\n \tETH_SS_STATS,\n@@ -314,6 +316,11 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf,\n \t\telse\n \t\t\tol_flags |= PKT_RX_L4_CKSUM_GOOD;\n \n+\tif (likely((packet_type & ENA_PTYPE_HAS_HASH) && !ena_rx_ctx->frag)) {\n+\t\tol_flags |= PKT_RX_RSS_HASH;\n+\t\tmbuf->hash.rss = ena_rx_ctx->hash;\n+\t}\n+\n \tmbuf->ol_flags = ol_flags;\n \tmbuf->packet_type = packet_type;\n }\n@@ -1954,6 +1961,9 @@ static int ena_dev_configure(struct rte_eth_dev *dev)\n \n \tadapter->state = ENA_ADAPTER_STATE_CONFIG;\n \n+\tif (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)\n+\t\tdev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;\n+\n \tadapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads;\n \tadapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads;\n \treturn 0;\n@@ -2030,6 +2040,7 @@ static int ena_infos_get(struct rte_eth_dev *dev,\n \n \t/* Inform framework about available features */\n \tdev_info->rx_offload_capa = rx_feat;\n+\tdev_info->rx_offload_capa |= DEV_RX_OFFLOAD_RSS_HASH;\n \tdev_info->rx_queue_offload_capa = rx_feat;\n \tdev_info->tx_offload_capa = tx_feat;\n \tdev_info->tx_queue_offload_capa = tx_feat;\n@@ -2242,8 +2253,6 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\t++rx_ring->rx_stats.bad_csum;\n \t\t}\n \n-\t\tmbuf->hash.rss = ena_rx_ctx.hash;\n-\n \t\trx_pkts[completed] = mbuf;\n \t\trx_ring->rx_stats.bytes += mbuf->pkt_len;\n \t}\n", "prefixes": [ "v5", "1/3" ] }