Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93155/?format=api
{ "id": 93155, "url": "https://patches.dpdk.org/api/patches/93155/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210511113358.2485-3-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210511113358.2485-3-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210511113358.2485-3-david.marchand@redhat.com", "date": "2021-05-11T11:33:58", "name": "[v2,2/2] net/ice: fix leak on thread termination", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3a40075331345fbdce8e45a7ed256d96f4688649", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210511113358.2485-3-david.marchand@redhat.com/mbox/", "series": [ { "id": 16924, "url": "https://patches.dpdk.org/api/series/16924/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16924", "date": "2021-05-11T11:33:56", "name": "Thread termination leak fixes", "version": 2, "mbox": "https://patches.dpdk.org/series/16924/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93155/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/93155/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8EF03A0A0E;\n\tTue, 11 May 2021 13:34:46 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7193140697;\n\tTue, 11 May 2021 13:34:46 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 5F385406A3\n for <dev@dpdk.org>; Tue, 11 May 2021 13:34:45 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-470-sITd-pv9PxKhg8p5zNBONA-1; Tue, 11 May 2021 07:34:41 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EAA06107ACC7;\n Tue, 11 May 2021 11:34:39 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.60])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D8F1F1725E;\n Tue, 11 May 2021 11:34:31 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1620732884;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BXg0CvfZCdOSIYtk3enskdO9dVmz3hs9bRglQwtMemo=;\n b=dLtYXJQYPyZc7qYZs82SMZQ6n30l+HxPUIvIRoX8e8eVkAeqVUZckxn0/OaGQYChX+zAO6\n ADHdyjZLJhjaMFL+MfMkaR7HxTwRRx8KZOznL3jVLwqke0DK42raEphMoekXW07Olvx3lf\n 6GMAmzSc9D3r6AzO4t7Hxe/MY3CKrsw=", "X-MC-Unique": "sITd-pv9PxKhg8p5zNBONA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "timothy.mcdaniel@intel.com, maxime.coquelin@redhat.com,\n chenbo.xia@intel.com, stable@dpdk.org, Haiyue Wang <haiyue.wang@intel.com>,\n Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Date": "Tue, 11 May 2021 13:33:58 +0200", "Message-Id": "<20210511113358.2485-3-david.marchand@redhat.com>", "In-Reply-To": "<20210511113358.2485-1-david.marchand@redhat.com>", "References": "<20210506094452.1689-1-david.marchand@redhat.com>\n <20210511113358.2485-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v2 2/2] net/ice: fix leak on thread termination", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A terminated pthread should be joined or detached so that its associated\nresources are released.\n\nThe \"ice-reset-<vf_id>\" threads are used to service some reset task in the\nbackground, but they are never joined by the thread that created them.\nThe easiest solution is to detach new threads.\n\nThe Windows EAL did not provide a pthread_detach wrapper but there is no\nresource to release for Windows threads, so add an empty wrapper.\n\nFixes: 3b3757bda3c3 (\"net/ice: get VF hardware index in DCF\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Haiyue Wang <haiyue.wang@intel.com>\n---\nChanges since v1:\n- fixed build for net/ice on Windows\n\n---\n drivers/net/ice/ice_dcf_parent.c | 2 ++\n lib/eal/windows/include/pthread.h | 6 ++++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c\nindex c8e433239b..1d7aa8bc87 100644\n--- a/drivers/net/ice/ice_dcf_parent.c\n+++ b/drivers/net/ice/ice_dcf_parent.c\n@@ -121,6 +121,8 @@ ice_dcf_vsi_update_service_handler(void *param)\n \tstruct ice_dcf_hw *hw = reset_param->dcf_hw;\n \tstruct ice_dcf_adapter *adapter;\n \n+\tpthread_detach(pthread_self());\n+\n \trte_delay_us(ICE_DCF_VSI_UPDATE_SERVICE_INTERVAL);\n \n \trte_spinlock_lock(&vsi_update_lock);\ndiff --git a/lib/eal/windows/include/pthread.h b/lib/eal/windows/include/pthread.h\nindex 1939b0121c..27fd2cca52 100644\n--- a/lib/eal/windows/include/pthread.h\n+++ b/lib/eal/windows/include/pthread.h\n@@ -143,6 +143,12 @@ pthread_create(void *threadid, const void *threadattr, void *threadfunc,\n \treturn ((hThread != NULL) ? 0 : E_FAIL);\n }\n \n+static inline int\n+pthread_detach(__rte_unused pthread_t thread)\n+{\n+\treturn 0;\n+}\n+\n static inline int\n pthread_join(__rte_unused pthread_t thread,\n \t__rte_unused void **value_ptr)\n", "prefixes": [ "v2", "2/2" ] }