Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93089/?format=api
{ "id": 93089, "url": "https://patches.dpdk.org/api/patches/93089/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1620648363-31769-2-git-send-email-fengchengwen@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1620648363-31769-2-git-send-email-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1620648363-31769-2-git-send-email-fengchengwen@huawei.com", "date": "2021-05-10T12:06:02", "name": "[1/2] net/mlx4: fix memory barrier incorrectly placed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6aa25e7fad13165fac9d4d8f610c3959b88d763f", "submitter": { "id": 2146, "url": "https://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1620648363-31769-2-git-send-email-fengchengwen@huawei.com/mbox/", "series": [ { "id": 16898, "url": "https://patches.dpdk.org/api/series/16898/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16898", "date": "2021-05-10T12:06:01", "name": "bugfix for mlx4 and mlx5", "version": 1, "mbox": "https://patches.dpdk.org/series/16898/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93089/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/93089/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 04CC7A0A0E;\n\tMon, 10 May 2021 14:09:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 121EA4110C;\n\tMon, 10 May 2021 14:09:19 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id E8F52410FF\n for <dev@dpdk.org>; Mon, 10 May 2021 14:09:12 +0200 (CEST)", "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Ff0BN0pP5zQlVk;\n Mon, 10 May 2021 20:05:48 +0800 (CST)", "from localhost.localdomain (10.67.165.24) by\n DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id\n 14.3.498.0; Mon, 10 May 2021 20:09:03 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>", "Date": "Mon, 10 May 2021 20:06:02 +0800", "Message-ID": "<1620648363-31769-2-git-send-email-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.8.1", "In-Reply-To": "<1620648363-31769-1-git-send-email-fengchengwen@huawei.com>", "References": "<1620648363-31769-1-git-send-email-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.24]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 1/2] net/mlx4: fix memory barrier incorrectly\n placed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The memory barrier is used to ensure that the response is returned\nonly after the Tx/Rx function is set, it should place after the Rx/Tx\nfunction is set.\n\nFixes: 0203d33a1059 (\"net/mlx4: support secondary process\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/mlx4/mlx4_mp.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4_mp.c b/drivers/net/mlx4/mlx4_mp.c\nindex ddf7bdb..8fcfb54 100644\n--- a/drivers/net/mlx4/mlx4_mp.c\n+++ b/drivers/net/mlx4/mlx4_mp.c\n@@ -126,7 +126,6 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n \tswitch (param->type) {\n \tcase MLX4_MP_REQ_START_RXTX:\n \t\tINFO(\"port %u starting datapath\", dev->data->port_id);\n-\t\trte_mb();\n \t\tdev->tx_pkt_burst = mlx4_tx_burst;\n \t\tdev->rx_pkt_burst = mlx4_rx_burst;\n #ifdef HAVE_IBV_MLX4_UAR_MMAP_OFFSET\n@@ -144,6 +143,7 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n \t\t\t}\n \t\t}\n #endif\n+\t\trte_mb();\n \t\tmp_init_msg(dev, &mp_res, param->type);\n \t\tres->result = 0;\n \t\tret = rte_mp_reply(&mp_res, peer);\n", "prefixes": [ "1/2" ] }