Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93030/?format=api
{ "id": 93030, "url": "https://patches.dpdk.org/api/patches/93030/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210506151426.28202-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210506151426.28202-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210506151426.28202-2-david.marchand@redhat.com", "date": "2021-05-06T15:14:25", "name": "[1/2] net: add endianness annotations to ethernet headers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "45bd6edbc991b26bb470bf44ccf85d327833ebc6", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210506151426.28202-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 16863, "url": "https://patches.dpdk.org/api/series/16863/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16863", "date": "2021-05-06T15:14:24", "name": "21.05 fixes for OVS", "version": 1, "mbox": "https://patches.dpdk.org/series/16863/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/93030/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/93030/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 337D0A0524;\n\tThu, 6 May 2021 17:15:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D45DC41103;\n\tThu, 6 May 2021 17:14:58 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id E9F02410FF\n for <dev@dpdk.org>; Thu, 6 May 2021 17:14:57 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-115-f-sV6xgjPKew3_f3lDVyQw-1; Thu, 06 May 2021 11:14:53 -0400", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 81BB879EC8;\n Thu, 6 May 2021 15:14:52 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.60])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 2BA9F5B826;\n Thu, 6 May 2021 15:14:50 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1620314097;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=FOz1KNbH96B5Otlz1Nt6jOEZ/YlfBbq6e7XMXIRtl5g=;\n b=R3MiRB9HSPE1/msaste0EZe5ql2YhxWRGEInygsEqIg3mUAv0YWgobYh0NzrqMeNCyek3a\n WWtIqf7mAmw1pIAx411TmiQZ5pwI5N3dbLTp2muLblRlNW1sJBCwymRXwD3YVs0JAogmNg\n PqL4/5lGiFUj4SAfT+Z8bC74FvHmvh8=", "X-MC-Unique": "f-sV6xgjPKew3_f3lDVyQw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "ian.stokes@intel.com, ktraynor@redhat.com,\n Olivier Matz <olivier.matz@6wind.com>", "Date": "Thu, 6 May 2021 17:14:25 +0200", "Message-Id": "<20210506151426.28202-2-david.marchand@redhat.com>", "In-Reply-To": "<20210506151426.28202-1-david.marchand@redhat.com>", "References": "<20210506151426.28202-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 1/2] net: add endianness annotations to ethernet\n headers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Spotted by sparse in OVS build:\n\n/home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:789:27:\nerror: incorrect type in initializer (different base types)\n/home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:789:27:\nexpected unsigned short [usertype] ether_type\n/home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:789:27:\ngot restricted ovs_be16 [usertype]\n/home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:829:25:\nerror: incorrect type in initializer (different base types)\n/home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:829:25:\nexpected unsigned short [usertype] vlan_tci\n/home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:829:25:\ngot restricted ovs_be16 [usertype]\n/home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:830:26:\nerror: incorrect type in initializer (different base types)\n/home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:830:26:\nexpected unsigned short [usertype] eth_proto\n/home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:830:26:\ngot restricted ovs_be16 [usertype]\n\nThis was not caught before as no code in headers was using those fields.\nThis changed with commit 6f2168b69aee (\"ethdev: reuse ethernet header\ndefinition in flow item\") and commit a56a262e3408 (\"ethdev: reuse VLAN\nheader definition in flow item\").\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/net/rte_ether.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/net/rte_ether.h b/lib/net/rte_ether.h\nindex a303c24a8c..7ee5e9a292 100644\n--- a/lib/net/rte_ether.h\n+++ b/lib/net/rte_ether.h\n@@ -276,7 +276,7 @@ struct rte_ether_hdr {\n \t\t\tstruct rte_ether_addr S_addr;\n \t\t} S_un; /**< Do not use directly; use s_addr instead.*/\n \t};\n-\tuint16_t ether_type; /**< Frame type. */\n+\trte_be16_t ether_type; /**< Frame type. */\n } __rte_aligned(2);\n \n #pragma pop_macro(\"s_addr\")\n@@ -287,8 +287,8 @@ struct rte_ether_hdr {\n * of the encapsulated frame.\n */\n struct rte_vlan_hdr {\n-\tuint16_t vlan_tci; /**< Priority (3) + CFI (1) + Identifier Code (12) */\n-\tuint16_t eth_proto;/**< Ethernet type of encapsulated frame. */\n+\trte_be16_t vlan_tci; /**< Priority (3) + CFI (1) + Identifier Code (12) */\n+\trte_be16_t eth_proto; /**< Ethernet type of encapsulated frame. */\n } __rte_packed;\n \n \n", "prefixes": [ "1/2" ] }