Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92988/?format=api
{ "id": 92988, "url": "https://patches.dpdk.org/api/patches/92988/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1620285387-42792-2-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1620285387-42792-2-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1620285387-42792-2-git-send-email-humin29@huawei.com", "date": "2021-05-06T07:16:26", "name": "[v2,1/2] graph: fix memory leak", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "03c2831f8d1fee3daa80fe4fa9c4453f350347cb", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1620285387-42792-2-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16847, "url": "https://patches.dpdk.org/api/series/16847/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16847", "date": "2021-05-06T07:16:27", "name": "bugfix for graph", "version": 2, "mbox": "https://patches.dpdk.org/series/16847/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92988/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92988/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 92EE8A0524;\n\tThu, 6 May 2021 09:16:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 09860410F9;\n\tThu, 6 May 2021 09:16:32 +0200 (CEST)", "from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by mails.dpdk.org (Postfix) with ESMTP id 1F7E3410F3\n for <dev@dpdk.org>; Thu, 6 May 2021 09:16:29 +0200 (CEST)", "from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FbPvw1P64zklS4;\n Thu, 6 May 2021 15:14:20 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id\n 14.3.498.0; Thu, 6 May 2021 15:16:24 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>,\n <david.marchand@redhat.com>, <jerinj@marvell.com>, <kirankumark@marvell.com>", "Date": "Thu, 6 May 2021 15:16:26 +0800", "Message-ID": "<1620285387-42792-2-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1620285387-42792-1-git-send-email-humin29@huawei.com>", "References": "<1619092340-4047-1-git-send-email-humin29@huawei.com>\n <1620285387-42792-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v2 1/2] graph: fix memory leak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: HongBo Zheng <zhenghongbo3@huawei.com>\n\nFix function 'stats_mem_populate' return without\nfree dynamic memory referenced by 'stats'.\n\nFixes: af1ae8b6a32c (\"graph: implement stats\")\nCc: stable@dpdk.org\n\nSigned-off-by: HongBo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n lib/graph/graph_stats.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c\nindex 125e08d..30e295d 100644\n--- a/lib/graph/graph_stats.c\n+++ b/lib/graph/graph_stats.c\n@@ -165,6 +165,7 @@ stats_mem_populate(struct rte_graph_cluster_stats **stats_in,\n \tstats = realloc(stats, stats->sz + stats->cluster_node_size);\n \tif (stats == NULL)\n \t\tSET_ERR_JMP(ENOMEM, err, \"Realloc failed\");\n+\t*stats_in = NULL;\n \n \t/* Clear the new struct cluster_node area */\n \tcluster = RTE_PTR_ADD(stats, stats->sz),\n@@ -174,7 +175,7 @@ stats_mem_populate(struct rte_graph_cluster_stats **stats_in,\n \tcluster->stat.hz = rte_get_timer_hz();\n \tnode = graph_node_id_to_ptr(graph, id);\n \tif (node == NULL)\n-\t\tSET_ERR_JMP(ENOENT, err, \"Failed to find node %s in graph %s\",\n+\t\tSET_ERR_JMP(ENOENT, free, \"Failed to find node %s in graph %s\",\n \t\t\t graph_node->node->name, graph->name);\n \tcluster->nodes[cluster->nb_nodes++] = node;\n \n@@ -183,6 +184,8 @@ stats_mem_populate(struct rte_graph_cluster_stats **stats_in,\n \t*stats_in = stats;\n \n \treturn 0;\n+free:\n+\tfree(stats);\n err:\n \treturn -rte_errno;\n }\n", "prefixes": [ "v2", "1/2" ] }