Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92985/?format=api
{ "id": 92985, "url": "https://patches.dpdk.org/api/patches/92985/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1620281639-54472-1-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1620281639-54472-1-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1620281639-54472-1-git-send-email-humin29@huawei.com", "date": "2021-05-06T06:13:59", "name": "[v3] app/crypto-perf: fix dereference of null return", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7dc318acc19b2282d18d1a18aaf6efde72dc3e7c", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1620281639-54472-1-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16845, "url": "https://patches.dpdk.org/api/series/16845/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16845", "date": "2021-05-06T06:13:59", "name": "[v3] app/crypto-perf: fix dereference of null return", "version": 3, "mbox": "https://patches.dpdk.org/series/16845/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92985/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92985/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D2E9A0A02;\n\tThu, 6 May 2021 08:14:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1ED29410DB;\n\tThu, 6 May 2021 08:14:06 +0200 (CEST)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id BD33F40040\n for <dev@dpdk.org>; Thu, 6 May 2021 08:14:04 +0200 (CEST)", "from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FbNVW64YGzmfcf;\n Thu, 6 May 2021 14:10:43 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id\n 14.3.498.0; Thu, 6 May 2021 14:13:56 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>, <gakhil@marvell.com>", "Date": "Thu, 6 May 2021 14:13:59 +0800", "Message-ID": "<1620281639-54472-1-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619163678-37202-1-git-send-email-humin29@huawei.com>", "References": "<1619163678-37202-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v3] app/crypto-perf: fix dereference of null\n return", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Return value of a function 'rte_zmalloc' is dereferenced without\nchecking, and it may call segmentation fault.\n\nThis patch fixed it.\n\nFixes: f8be1786b1b8 (\"app/crypto-perf: introduce performance test application\")\nCc: stable@dpdk.org\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\nv3:\n* fix compiling warning.\n---\n app/test-crypto-perf/cperf_options_parsing.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c\nindex 40b6dfb..e84f56c 100644\n--- a/app/test-crypto-perf/cperf_options_parsing.c\n+++ b/app/test-crypto-perf/cperf_options_parsing.c\n@@ -506,6 +506,12 @@ parse_test_name(struct cperf_options *opts,\n {\n \tchar *test_name = (char *) rte_zmalloc(NULL,\n \t\tsizeof(char) * (strlen(arg) + 3), 0);\n+\tif (test_name == NULL) {\n+\t\tRTE_LOG(ERR, USER1, \"Failed to rte zmalloc with size: %zu\\n\",\n+\t\t\tstrlen(arg) + 3);\n+\t\treturn -1;\n+\t}\n+\n \tsnprintf(test_name, strlen(arg) + 3, \"[%s]\", arg);\n \topts->test_name = test_name;\n \n", "prefixes": [ "v3" ] }