Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92957/?format=api
https://patches.dpdk.org/api/patches/92957/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1620236174-10676-7-git-send-email-jizh@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1620236174-10676-7-git-send-email-jizh@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1620236174-10676-7-git-send-email-jizh@linux.microsoft.com", "date": "2021-05-05T17:36:10", "name": "[v12,06/10] app/testpmd: fix parse_fec_mode return type name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c569a8df1c6a2d07664c7b953eaf67a30fc1e9b9", "submitter": { "id": 1934, "url": "https://patches.dpdk.org/api/people/1934/?format=api", "name": "Jie Zhou", "email": "jizh@linux.microsoft.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1620236174-10676-7-git-send-email-jizh@linux.microsoft.com/mbox/", "series": [ { "id": 16837, "url": "https://patches.dpdk.org/api/series/16837/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16837", "date": "2021-05-05T17:36:05", "name": "app/testpmd: enable testpmd on Windows", "version": 12, "mbox": "https://patches.dpdk.org/series/16837/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92957/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92957/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E3B8A0524;\n\tWed, 5 May 2021 19:36:50 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5AB334112A;\n\tWed, 5 May 2021 19:36:26 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id EDE61410EE;\n Wed, 5 May 2021 19:36:19 +0200 (CEST)", "from\n linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net\n (linux.microsoft.com [13.77.154.182])\n by linux.microsoft.com (Postfix) with ESMTPSA id 0224820B8010;\n Wed, 5 May 2021 10:36:19 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 0224820B8010", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1620236179;\n bh=2JuPsZeGWOdTVf9U4/IrsCFpVD832l8owuZ/9rnTvhU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=anYdbXMHIGENfaUQ7ucVSkBmmvmH9FV8hyYW7vJLGLBcBfuW3bU7LK77NqN/5D/ul\n suWcvH3zs0w9Wmh1K1IliYwqiCJZBhUgQ3JvJE0m2WbNdLEOYLaSSaXVQ/nFhK9JxX\n uBy6vPuIQJ7fZq8P+E5bYgYp+vy0YMifkelxvcX0=", "From": "Jie Zhou <jizh@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "dmitry.kozliuk@gmail.com, xiaoyun.li@intel.com, roretzla@microsoft.com,\n talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net,\n bruce.richardson@intel.com, ferruh.yigit@intel.com,\n konstantin.ananyev@intel.com, stable@dpdk.org", "Date": "Wed, 5 May 2021 10:36:10 -0700", "Message-Id": "<1620236174-10676-7-git-send-email-jizh@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1620236174-10676-1-git-send-email-jizh@linux.microsoft.com>", "References": "<1620235115-7062-1-git-send-email-jizh@linux.microsoft.com>\n <1620236174-10676-1-git-send-email-jizh@linux.microsoft.com>", "Subject": "[dpdk-dev] [PATCH v12 06/10] app/testpmd: fix parse_fec_mode return\n type name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace parse_fec_mode misleading return type name mode with fec_capa\n\nFixes: b19da32e3151 (\"app/testpmd: add FEC command\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Zhou <jizh@microsoft.com>\nSigned-off-by: Jie Zhou <jizh@linux.microsoft.com>\n---\n app/test-pmd/cmdline.c | 6 +++---\n app/test-pmd/config.c | 4 ++--\n app/test-pmd/testpmd.h | 2 +-\n 3 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 12efbc0ca..d804ee233 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -16984,17 +16984,17 @@ cmd_set_port_fec_mode_parsed(\n {\n \tstruct cmd_set_port_fec_mode *res = parsed_result;\n \tuint16_t port_id = res->port_id;\n-\tuint32_t mode;\n+\tuint32_t fec_capa;\n \tint ret;\n \n-\tret = parse_fec_mode(res->fec_value, &mode);\n+\tret = parse_fec_mode(res->fec_value, &fec_capa);\n \tif (ret < 0) {\n \t\tprintf(\"Unknown fec mode: %s for Port %d\\n\", res->fec_value,\n \t\t\tport_id);\n \t\treturn;\n \t}\n \n-\tret = rte_eth_fec_set(port_id, mode);\n+\tret = rte_eth_fec_set(port_id, fec_capa);\n \tif (ret == -ENOTSUP) {\n \t\tprintf(\"Function not implemented\\n\");\n \t\treturn;\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex e189062ef..099bfa3c9 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -3548,13 +3548,13 @@ set_tx_pkt_split(const char *name)\n }\n \n int\n-parse_fec_mode(const char *name, uint32_t *mode)\n+parse_fec_mode(const char *name, uint32_t *fec_capa)\n {\n \tuint8_t i;\n \n \tfor (i = 0; i < RTE_DIM(fec_mode_name); i++) {\n \t\tif (strcmp(fec_mode_name[i].name, name) == 0) {\n-\t\t\t*mode = RTE_ETH_FEC_MODE_TO_CAPA(fec_mode_name[i].mode);\n+\t\t\t*fec_capa = RTE_ETH_FEC_MODE_TO_CAPA(fec_mode_name[i].mode);\n \t\t\treturn 0;\n \t\t}\n \t}\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 6ca872db8..1d104213b 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -886,7 +886,7 @@ void show_tx_pkt_segments(void);\n void set_tx_pkt_times(unsigned int *tx_times);\n void show_tx_pkt_times(void);\n void set_tx_pkt_split(const char *name);\n-int parse_fec_mode(const char *name, enum rte_eth_fec_mode *mode);\n+int parse_fec_mode(const char *name, uint32_t *fec_capa);\n void show_fec_capability(uint32_t num, struct rte_eth_fec_capa *speed_fec_capa);\n void set_nb_pkt_per_burst(uint16_t pkt_burst);\n char *list_pkt_forwarding_modes(void);\n", "prefixes": [ "v12", "06/10" ] }{ "id": 92957, "url": "