Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92857/?format=api
{ "id": 92857, "url": "https://patches.dpdk.org/api/patches/92857/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210505073348.6394-7-mk@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210505073348.6394-7-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210505073348.6394-7-mk@semihalf.com", "date": "2021-05-05T07:33:32", "name": "[v2,06/22] net/ena/base: destroy multiple \"wait events\"", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bc20b4654fbd49296d42dfdbe66dfe3432d5ba7f", "submitter": { "id": 786, "url": "https://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210505073348.6394-7-mk@semihalf.com/mbox/", "series": [ { "id": 16820, "url": "https://patches.dpdk.org/api/series/16820/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16820", "date": "2021-05-05T07:33:26", "name": "net/ena: update ENA PMD to v2.3.0", "version": 2, "mbox": "https://patches.dpdk.org/series/16820/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92857/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92857/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B10C9A0524;\n\tWed, 5 May 2021 09:34:50 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3C53641127;\n\tWed, 5 May 2021 09:34:10 +0200 (CEST)", "from mail-wm1-f53.google.com (mail-wm1-f53.google.com\n [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 75ACD41110\n for <dev@dpdk.org>; Wed, 5 May 2021 09:34:07 +0200 (CEST)", "by mail-wm1-f53.google.com with SMTP id\n 4-20020a05600c26c4b0290146e1feccd8so505556wmv.1\n for <dev@dpdk.org>; Wed, 05 May 2021 00:34:07 -0700 (PDT)", "from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl.\n [89.79.189.199])\n by smtp.gmail.com with ESMTPSA id t17sm4679856wmq.12.2021.05.05.00.34.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 05 May 2021 00:34:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=15FZt3K7cdpAllc/3/WHxIsIzw+Wtoo4ytssIEc5lvA=;\n b=iRdoSXbhDlFwhdKfQZ0dKDMiIK0D7Lwi9Bofubt0EWcdDRr2KF3QVZTo46qmojRIqX\n d8Keett5B8cdJP92zFnI1jM40gM5moNsw+aH2159t6ZVGC3pLG5qSRjy9R5mpzxmjHzM\n qx02Iz8WqiWMATX4NTAUPE3n+coHNU5mLbbVordHmS5lhYAqU6LI8yQSpN9oZf6Wy7nS\n cBHqYXOvMTtA/kPMwoM2kzxrtc7O6OcwHnps7lVqbHouhsG9b5V6h2C2XzMtCbXyuT/w\n DzGDtc5p+7gaIfGxHUOPhSUNY1WeepsRVViThvFfbHTJmo/aW9gxBu6tahPHR2QbwV8a\n aJiQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=15FZt3K7cdpAllc/3/WHxIsIzw+Wtoo4ytssIEc5lvA=;\n b=hajVkWGW2q80x7wgTBC6xU8E8XSsbl/e7fuyMbvqnQ1xLjn/0HANbx73ALxPADSOYt\n jDFpUlE3p5r5nw3OVuzsr5SL8/lH/gPDC4Hb/xYNbTA/gd5y5FG4eO7/DdJCWDD2tJxi\n H6NNycqiiVlhAMfecCqaKJagjPFGckjhHKZ6lUon4zLR6BPsHjSKiw7wGKehvGzp05Pw\n 3sb4PKZ6ajvMV8OGpQt2Ev88NAkuqtnNvMW74qugRLcKRNFb5bsc91f4sNQ5ZDqwyi2d\n R49uQR8HVCCG4q0M7fSHYXqiQvGY/Hg0zyRr5OgUWpM3K95+Ake9X64gr3SM1VPUjn5n\n 2lRg==", "X-Gm-Message-State": "AOAM533HLNJWZr8E38bO+Pf1k3GJTpIypofrV+s4/x+AttgPmSVywDIF\n T/ABkNk7tgk6nn20/XeO3tKaKaYJ8xfPFnG2", "X-Google-Smtp-Source": "\n ABdhPJylhBh5UPMCSPjbY1z2e+FmBFZnQdKBzv1OlOcDtBd7ASApx1g93eiXeKZzGofSHyqnjEjWcg==", "X-Received": "by 2002:a7b:c04c:: with SMTP id u12mr31470217wmc.44.1620200046887;\n Wed, 05 May 2021 00:34:06 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com,\n upstream@semihalf.com, Michal Krawczyk <mk@semihalf.com>", "Date": "Wed, 5 May 2021 09:33:32 +0200", "Message-Id": "<20210505073348.6394-7-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210505073348.6394-1-mk@semihalf.com>", "References": "<20210430125725.28796-1-mk@semihalf.com>\n <20210505073348.6394-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 06/22] net/ena/base: destroy multiple \"wait\n events\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Although the ENA DPDK PMD doesn't have to perform any actions for\ndestroying the wait event, some other platforms have to.\n\nThe macro \"ENA_WAIT_EVENT_DESTROY\" was renamed to\n\"ENA_WAIT_EVENTS_DESTROY\" and also whole implementation responsible for\nthat was moved to a separate function for better readability.\n\nFixes: 3adcba9a8987 (\"net/ena: update HAL to the newer version\")\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_com.c | 24 +++++++++++++++++-------\n drivers/net/ena/base/ena_plat_dpdk.h | 4 ++--\n 2 files changed, 19 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex 0cdeb1a2d9..d025c9cee1 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -1671,6 +1671,22 @@ int ena_com_validate_version(struct ena_com_dev *ena_dev)\n \treturn 0;\n }\n \n+static void\n+ena_com_free_ena_admin_queue_comp_ctx(struct ena_com_dev *ena_dev,\n+\t\t\t\t struct ena_com_admin_queue *admin_queue)\n+\n+{\n+\tif (!admin_queue->comp_ctx)\n+\t\treturn;\n+\n+\tENA_WAIT_EVENTS_DESTROY(admin_queue);\n+\tENA_MEM_FREE(ena_dev->dmadev,\n+\t\t admin_queue->comp_ctx,\n+\t\t (admin_queue->q_depth * sizeof(struct ena_comp_ctx)));\n+\n+\tadmin_queue->comp_ctx = NULL;\n+}\n+\n void ena_com_admin_destroy(struct ena_com_dev *ena_dev)\n {\n \tstruct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;\n@@ -1679,14 +1695,8 @@ void ena_com_admin_destroy(struct ena_com_dev *ena_dev)\n \tstruct ena_com_aenq *aenq = &ena_dev->aenq;\n \tu16 size;\n \n-\tif (admin_queue->comp_ctx) {\n-\t\tENA_WAIT_EVENT_DESTROY(admin_queue->comp_ctx->wait_event);\n-\t\tENA_MEM_FREE(ena_dev->dmadev,\n-\t\t\t admin_queue->comp_ctx,\n-\t\t\t (admin_queue->q_depth * sizeof(struct ena_comp_ctx)));\n-\t}\n+\tena_com_free_ena_admin_queue_comp_ctx(ena_dev, admin_queue);\n \n-\tadmin_queue->comp_ctx = NULL;\n \tsize = ADMIN_SQ_SIZE(admin_queue->q_depth);\n \tif (sq->entries)\n \t\tENA_MEM_FREE_COHERENT(ena_dev->dmadev, size, sq->entries,\ndiff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h\nindex f1338cd1fe..067909f745 100644\n--- a/drivers/net/ena/base/ena_plat_dpdk.h\n+++ b/drivers/net/ena/base/ena_plat_dpdk.h\n@@ -166,7 +166,7 @@ extern int ena_logtype_com;\n #define ENA_WAIT_EVENT_SIGNAL(waitevent) pthread_cond_signal(&waitevent.cond)\n /* pthread condition doesn't need to be rearmed after usage */\n #define ENA_WAIT_EVENT_CLEAR(...)\n-#define ENA_WAIT_EVENT_DESTROY(waitqueue) ((void)(waitqueue))\n+#define ENA_WAIT_EVENT_DESTROY(admin_queue) ((void)(admin_queue))\n \n #define ena_wait_event_t ena_wait_queue_t\n #define ENA_MIGHT_SLEEP()\n@@ -298,7 +298,7 @@ extern rte_atomic32_t ena_alloc_cnt;\n #define ENA_TIME_EXPIRE(timeout) (timeout < rte_get_timer_cycles())\n #define ENA_GET_SYSTEM_TIMEOUT(timeout_us)\t\t\t\t\\\n (timeout_us * rte_get_timer_hz() / 1000000 + rte_get_timer_cycles())\n-#define ENA_WAIT_EVENT_DESTROY(waitqueue) ((void)(waitqueue))\n+#define ENA_WAIT_EVENTS_DESTROY(waitqueue) ((void)(waitqueue))\n \n #ifndef READ_ONCE\n #define READ_ONCE(var) (*((volatile typeof(var) *)(&(var))))\n", "prefixes": [ "v2", "06/22" ] }