Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92795/?format=api
{ "id": 92795, "url": "https://patches.dpdk.org/api/patches/92795/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210505042004.25280-15-bingz@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210505042004.25280-15-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210505042004.25280-15-bingz@nvidia.com", "date": "2021-05-05T04:20:01", "name": "[v2,14/17] net/mlx5: validation of CT action", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e52aa05d5801be729d1d6ff5bf6bf20037f2b121", "submitter": { "id": 1976, "url": "https://patches.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210505042004.25280-15-bingz@nvidia.com/mbox/", "series": [ { "id": 16816, "url": "https://patches.dpdk.org/api/series/16816/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16816", "date": "2021-05-05T04:19:47", "name": "conntrack support in mlx5 PMD", "version": 2, "mbox": "https://patches.dpdk.org/series/16816/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92795/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92795/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0B968A034F;\n\tWed, 5 May 2021 06:22:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F059A41156;\n\tWed, 5 May 2021 06:21:21 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2056.outbound.protection.outlook.com [40.107.236.56])\n by mails.dpdk.org (Postfix) with ESMTP id A4CDC4114C\n for <dev@dpdk.org>; Wed, 5 May 2021 06:21:20 +0200 (CEST)", "from MW2PR16CA0042.namprd16.prod.outlook.com (2603:10b6:907:1::19)\n by SA0PR12MB4526.namprd12.prod.outlook.com (2603:10b6:806:98::23) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.38; Wed, 5 May\n 2021 04:21:19 +0000", "from CO1NAM11FT066.eop-nam11.prod.protection.outlook.com\n (2603:10b6:907:1:cafe::39) by MW2PR16CA0042.outlook.office365.com\n (2603:10b6:907:1::19) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend\n Transport; Wed, 5 May 2021 04:21:19 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT066.mail.protection.outlook.com (10.13.175.18) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4087.27 via Frontend Transport; Wed, 5 May 2021 04:21:19 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 May\n 2021 04:21:16 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=WALN8eVwP4hejyJkJ824ng4dFnNBfV5tIW3t2uU+9YKbb+rXXKwD7YrAKcNCUYyj2dyGv4SqWnDkztZZ5zRmrqHmBG4kiWCA/y0zMMrL3/oCUqZRKVRbpRkGT/FBmF9Bkn24OWlsJ7atH7rILChcd2Ic2yntGZVQxYzfxcV/w1SAG5pB5vESCrthdMbT7LqPvz0MAPqechmDmM3Dx+bvc0I0CHJfrOC7zlk1n5R7FxRaIbyA/Mroeed83Wc4JeQs2W8Gyi/XUHgqIBEai0v+UzrI7RFCX0HmE9fN1bs1slbM3nmklRGpE3k6qaN0sHxV2/879tVKJmHjFIjyG9jhuw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pVV4tzuozcUvQd2mRCQ4BpnUnOW1/SJxUjPmJAEnVA0=;\n b=c1RWSRZ2MvW7aXOJor7uh1z9nudZ2Q9k4K2OUSoqyWjb+6PIjbhQEqaijCXYiZurrjwNS5QEd3+t39Szq3mtRu9uQ2aUYo0d96iEyW3Axw9SSp+/RAeitSep1mUxKjDOUpg6ar/VMAOasCr2VYiuS9bYGmSasxxQETvN4xXt1e48NLIBMTQpRiwE/ZXT2xfPE7Xguvybl4TldOrQcr5eR4XEAY/NTGHYMHyiOCfaeCRu2XEnVrur13vvTidMjxuRzIN+3DTii3FiHSs+xcxMSRZDaD5xyupGH5JGqi/2jSMu+iCHXghysX9XzQ1KGeM3wluu40PY97riTT1PBAAI/g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pVV4tzuozcUvQd2mRCQ4BpnUnOW1/SJxUjPmJAEnVA0=;\n b=EKgl0eWoc6x8gicyurmnf2bGxjcR4805xhQRb8TOhOfWvf6mGXm5Y7podxM4y0a8DgCW0C0Ww+OC05E6r3jtxCqpPqBPhh0Cnu9LtrX/PcfjGTqqirnlNiNdaqcdlijv/YdkeIgge3hoKCYcJqVaYWqIraOMnq+FX/UAPbtJvdhTykDEMafppGqIDYNgtkpVi+U6FVD44XgoW95cjnjjcpanhQRCwWCGUh5FmyQwB/eHaXfzjR++eXhEBlTgJSdWdgeYa0K61DbA1OP01efd2Wr50AZRQMk3MGyqxG+1q8RSKfTMNzC8BSg6hplyu7NWt3KdueLN5OwsQRjbugyyMQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>, <thomas@monjalon.net>", "CC": "<dev@dpdk.org>, <orika@nvidia.com>, <rasland@nvidia.com>", "Date": "Wed, 5 May 2021 07:20:01 +0300", "Message-ID": "<20210505042004.25280-15-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210505042004.25280-1-bingz@nvidia.com>", "References": "<20210427153811.11554-1-bingz@nvidia.com>\n <20210505042004.25280-1-bingz@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "d41486ee-1203-47a6-9d7c-08d90f7d3b90", "X-MS-TrafficTypeDiagnostic": "SA0PR12MB4526:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <SA0PR12MB45262F49E656A7AD089911CDD0599@SA0PR12MB4526.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8273;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n TxuItWlCZZNgVmhhVgaduB4PypQt4UiPe6Wnrk+w597WryQIuyqB6AhNvz+z2zpYABhQR51SLsRTbWQYei1z/cv2GFhO6mBHO/pU/RWaBgNhELUW3dPg/sHuqeGGr6f1L2X0cvmnQQPGQ69TsVKcTjz8jZpWKdrJD7DOOig4j+rbfMcsbneJI7AvVcY98LDrfDpFM1cX+11vFwCaYhPt4/YqM8zPYXCpjuT1JS2FHDv8S5ifijHbxDiMtXOTgpakYYyxLuGKp6UZoI54g4P3GQ5IuYbgqo0O/dvuF8WTc4PrhTOf4xHr2BA5vnkUod9N8PNZdKhF6nisXQCaL61zrMPSm1iXVBe8+2yQgGlsD4pmGg+rtGdffA5Sk02sWcgiRNY33dOx93xwMoza33Uv3PgEF0fAPJtN4b58/WLigv68OXRUNNlQHm6sJeu8pOicKJGqJYLtrpyh7hy67pui0kVjZHZ5vBIzypzMwObqwPImYuQ9OQsLekTGcq2UWVhTbVJdDOB159wyfWlKqnN7+C7M+lyOwF9nNX15R+zX/VfhWUEqQv6XNUM9Q6J45H3w5IpP+jzBb0t9qfMKvnuEmWfdqPIj4uY3DnSQk06rBK/e2JRg9PiCDuxatidlJjPapVvlF+ISZkNVzTIsnr8UJL3BMEjvSUcBcHCAywO/rXTVkU/3Q34KLEGHnUXXC6jp", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(396003)(376002)(39860400002)(136003)(346002)(46966006)(36840700001)(356005)(47076005)(5660300002)(2906002)(8676002)(82310400003)(36756003)(36860700001)(426003)(4326008)(110136005)(1076003)(55016002)(70206006)(26005)(6286002)(186003)(107886003)(7696005)(83380400001)(7636003)(16526019)(8936002)(70586007)(36906005)(82740400003)(86362001)(6666004)(2616005)(316002)(54906003)(478600001)(336012)(309714004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "05 May 2021 04:21:19.3078 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n d41486ee-1203-47a6-9d7c-08d90f7d3b90", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT066.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA0PR12MB4526", "Subject": "[dpdk-dev] [PATCH v2 14/17] net/mlx5: validation of CT action", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The validation of a CT action contains two parts. The first is the\nCT action configurations parameter. When creating a CT action\ncontext, some members need to be verified.\n\nThe second is that when creating a flow, the DR action of CT should\nbe validated with other actions and items as well. Currently, only\nthe TCP protocol support connection tracking.\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\n---\n drivers/net/mlx5/mlx5.h | 4 ++\n drivers/net/mlx5/mlx5_flow.c | 31 +++++++++++++++\n drivers/net/mlx5/mlx5_flow_dv.c | 69 +++++++++++++++++++++++++++++++++\n 3 files changed, 104 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex d01a10ea54..36b7f05822 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -1611,6 +1611,10 @@ int mlx5_flow_dev_dump(struct rte_eth_dev *dev, struct rte_flow *flow,\n void mlx5_flow_rxq_dynf_metadata_set(struct rte_eth_dev *dev);\n int mlx5_flow_get_aged_flows(struct rte_eth_dev *dev, void **contexts,\n \t\t\tuint32_t nb_contexts, struct rte_flow_error *error);\n+int mlx5_validate_action_ct(struct rte_eth_dev *dev,\n+\t\t\t const struct rte_flow_action_conntrack *conntrack,\n+\t\t\t struct rte_flow_error *error);\n+\n \n /* mlx5_mp_os.c */\n \ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex f36eeae03f..6baaefbaba 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -1688,6 +1688,37 @@ mlx5_flow_validate_action_count(struct rte_eth_dev *dev __rte_unused,\n \treturn 0;\n }\n \n+/*\n+ * Validate the ASO CT action.\n+ *\n+ * @param[in] dev\n+ * Pointer to the Ethernet device structure.\n+ * @param[in] conntrack\n+ * Pointer to the CT action profile.\n+ * @param[out] error\n+ * Pointer to error structure.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_validate_action_ct(struct rte_eth_dev *dev,\n+\t\t\tconst struct rte_flow_action_conntrack *conntrack,\n+\t\t\tstruct rte_flow_error *error)\n+{\n+\tRTE_SET_USED(dev);\n+\n+\tif (conntrack->state > RTE_FLOW_CONNTRACK_STATE_TIME_WAIT)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t \"Invalid CT state\");\n+\tif (conntrack->last_index > RTE_FLOW_CONNTRACK_FLAG_RST)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t \"Invalid last TCP packet flag\");\n+\treturn 0;\n+}\n+\n /**\n * Verify the @p attributes will be correctly understood by the NIC and store\n * them in the @p flow if everything is correct.\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 6afbbbc4bb..f2a2c609e2 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -3400,6 +3400,57 @@ flow_dv_validate_action_raw_encap_decap\n \treturn 0;\n }\n \n+/*\n+ * Validate the ASO CT action.\n+ *\n+ * @param[in] dev\n+ * Pointer to the rte_eth_dev structure.\n+ * @param[in] action_flags\n+ * Holds the actions detected until now.\n+ * @param[in] item_flags\n+ * The items found in this flow rule.\n+ * @param[in] attr\n+ * Pointer to flow attributes.\n+ * @param[out] error\n+ * Pointer to error structure.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+flow_dv_validate_action_aso_ct(struct rte_eth_dev *dev,\n+\t\t\t uint64_t action_flags,\n+\t\t\t uint64_t item_flags,\n+\t\t\t const struct rte_flow_attr *attr,\n+\t\t\t struct rte_flow_error *error)\n+{\n+\tRTE_SET_USED(dev);\n+\n+\tif (attr->group == 0 && !attr->transfer)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"Only support non-root table\");\n+\tif (action_flags & MLX5_FLOW_FATE_ACTIONS)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t \"CT cannot follow a fate action\");\n+\tif ((action_flags & MLX5_FLOW_ACTION_METER) ||\n+\t (action_flags & MLX5_FLOW_ACTION_AGE))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t \"Only one ASO action is supported\");\n+\tif (action_flags & MLX5_FLOW_ACTION_ENCAP)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t \"Encap cannot exist before CT\");\n+\tif (!(item_flags & MLX5_FLOW_LAYER_OUTER_L4_TCP))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n+\t\t\t\t\t \"Not a outer TCP packet\");\n+\treturn 0;\n+}\n+\n /**\n * Match encap_decap resource.\n *\n@@ -7205,6 +7256,14 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \t\t\taction_flags |= MLX5_FLOW_ACTION_MODIFY_FIELD;\n \t\t\trw_act_num += ret;\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ACTION_TYPE_CONNTRACK:\n+\t\t\tret = flow_dv_validate_action_aso_ct(dev, action_flags,\n+\t\t\t\t\t\t\t item_flags, attr,\n+\t\t\t\t\t\t\t error);\n+\t\t\tif (ret < 0)\n+\t\t\t\treturn ret;\n+\t\t\taction_flags |= MLX5_FLOW_ACTION_CT;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n@@ -13861,6 +13920,10 @@ __flow_dv_action_ct_update(struct rte_eth_dev *dev, uint32_t idx,\n \tif (update->direction)\n \t\tct->is_original = !!new_prf->is_original_dir;\n \tif (update->state) {\n+\t\t/* Only validate the profile when it needs to be updated. */\n+\t\tret = mlx5_validate_action_ct(dev, new_prf, error);\n+\t\tif (ret)\n+\t\t\treturn ret;\n \t\tret = mlx5_aso_ct_update_by_wqe(priv->sh, ct, new_prf);\n \t\tif (ret)\n \t\t\treturn rte_flow_error_set(error, EIO,\n@@ -15732,6 +15795,12 @@ flow_dv_action_validate(struct rte_eth_dev *dev,\n \t\t\t\t\t\tNULL,\n \t\t\t\t\t \"shared age action not supported\");\n \t\treturn flow_dv_validate_action_age(0, action, dev, err);\n+\tcase RTE_FLOW_ACTION_TYPE_CONNTRACK:\n+\t\tif (!priv->sh->ct_aso_en)\n+\t\t\treturn rte_flow_error_set(err, ENOTSUP,\n+\t\t\t\t\tRTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n+\t\t\t\t\t\"ASO CT is not supported\");\n+\t\treturn mlx5_validate_action_ct(dev, action->conf, err);\n \tdefault:\n \t\treturn rte_flow_error_set(err, ENOTSUP,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n", "prefixes": [ "v2", "14/17" ] }