Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92762/?format=api
{ "id": 92762, "url": "https://patches.dpdk.org/api/patches/92762/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210504210857.3398397-4-matan@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210504210857.3398397-4-matan@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210504210857.3398397-4-matan@nvidia.com", "date": "2021-05-04T21:08:45", "name": "[v3,03/15] crypto/mlx5: support session operations", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b8ef2bd24baad36f0d8483fa88217d463c629c9f", "submitter": { "id": 1911, "url": "https://patches.dpdk.org/api/people/1911/?format=api", "name": "Matan Azrad", "email": "matan@nvidia.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210504210857.3398397-4-matan@nvidia.com/mbox/", "series": [ { "id": 16812, "url": "https://patches.dpdk.org/api/series/16812/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16812", "date": "2021-05-04T21:08:42", "name": "drivers: introduce mlx5 crypto PMD", "version": 3, "mbox": "https://patches.dpdk.org/series/16812/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92762/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92762/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8879EA0A02;\n\tTue, 4 May 2021 23:09:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 136A1410F6;\n\tTue, 4 May 2021 23:09:32 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2044.outbound.protection.outlook.com [40.107.93.44])\n by mails.dpdk.org (Postfix) with ESMTP id BBE65410F7\n for <dev@dpdk.org>; Tue, 4 May 2021 23:09:30 +0200 (CEST)", "from MWHPR18CA0036.namprd18.prod.outlook.com (2603:10b6:320:31::22)\n by MW2PR12MB2394.namprd12.prod.outlook.com (2603:10b6:907:f::18) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.35; Tue, 4 May\n 2021 21:09:29 +0000", "from CO1NAM11FT057.eop-nam11.prod.protection.outlook.com\n (2603:10b6:320:31:cafe::eb) by MWHPR18CA0036.outlook.office365.com\n (2603:10b6:320:31::22) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend\n Transport; Tue, 4 May 2021 21:09:29 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT057.mail.protection.outlook.com (10.13.174.205) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4087.27 via Frontend Transport; Tue, 4 May 2021 21:09:29 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 4 May\n 2021 21:09:25 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=WPGTLyqMRD2n6ckuN8vsUPk1kOlpCB2vVE2z1U/K+rssJCc+NKdRYMJBZRy6eBEuX7bdmikID2E+6xOFgg77SqlQF3NGmAu+y7w4CwuFVK43FecsZrFp9hXo4KCr7Azi82Y++Dx9NE7yzCBvlM3Pkh14Ipx9Vzv6oroFKnNTULw6iY0i7hJs1PCCUk+KqMFaLvtgAih3kZCUxYk1VzMUnsgnI57OW+9ipKwcfV9fLmVnJ7te7VO/j2COACHYC3RODDlXBeFAF/lPM+tzIGoDA7vJDAnau6DMUHGCnWo0i5/qL4Ul5RC2UsEd/o9hECg1gZh+7CTTrEIV6j/4q9xBGA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ZcoJrrI3OO8rHoXkx7Mqw/LQ59znRF+w62Cb9E7Bzdk=;\n b=Zf4V6X5+WyuQPAlQDzvh/YrheKJgCdAswNE2F0SPc3iCUCVXwMyZyjYQxjNhczG6U9Ynd9cWQV/NTNrZxKYehmEt6p0WyaFLocDUVQugNAgclHMdRKNi1H9ceYVYuwqtJGMAZ920gggvcPt2mB47WaqaciO1enRWSmhJhExrgvgF2jJ6+SxfezBSoU7RquNnF2P4lNz3IqLfXxA5aNfVox0I2j7uiM7x64fscIwwA29E7c7L4zk3udU7evf3TjHGVtWyDFgckCWaDYZEvJlS/0n+C73LZuR+YrkzbEoUCmqz5SGSKur7ALOkaJagcYEhpmPGq2GO++mifNZs/LhtyA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ZcoJrrI3OO8rHoXkx7Mqw/LQ59znRF+w62Cb9E7Bzdk=;\n b=qkG31wFFSOzvc05yuiIkwciB7ug3SFtZUL7OjaoyQtTZAWirxZu+0c1JyfQVyzKlPaDhN+BownZcfws/BM9UhqMltUsj4sGmdAxOCPrk25bOjyoOvzuvOxX7PFVnJ4mMmXkH0QfgCRSSi7Q0YfU000Uet2Rtv9Mh4dU3rhylmrm930JK812RqYMRNc2uE2Oa4xFfO3MZgTH+/F/miYWltm9q8vuhi3+1BsYHTgUhwx2qtAvtxuaBBqMplo85v+24dIp7sltwfivdXPbOjxvQEq9yRukLpb8k3AfQCseBUl0l7MQ05sigCh2Fjy8RSfABzbqBYgu/KV3gSjdEU9UAiQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed)\n header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Matan Azrad <matan@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<matan@nvidia.com>, <gakhil@marvell.com>, <suanmingm@nvidia.com>, \"Thomas\n Monjalon\" <thomas@monjalon.net>, Shiri Kuzin <shirik@nvidia.com>", "Date": "Wed, 5 May 2021 00:08:45 +0300", "Message-ID": "<20210504210857.3398397-4-matan@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210504210857.3398397-1-matan@nvidia.com>", "References": "<20210429154712.2820159-1-matan@nvidia.com>\n <20210504210857.3398397-1-matan@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL111.nvidia.com (172.20.187.18) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "6fcb82a6-7d70-43a8-72eb-08d90f40e7d9", "X-MS-TrafficTypeDiagnostic": "MW2PR12MB2394:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <MW2PR12MB2394A36D3366F9E9A544DA34DF5A9@MW2PR12MB2394.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4303;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n h5oz6mXQToGfybP0CWG/chUz2p5mMXZlZuNTRA6JkBDfGj7BKtdq0tyW9lq8oKyNpfjv+rzc06P0zzomDOW+cZDk42vyWbXfLc5hc+qadNkYQfGC17qvqhpVv7ydHDbdrmuy3thktU6a3AEzkyFsVbm15EfRzJP6tOqMXnIxWWU8WJn9PJNrhYvCfv843BkrS4GWgHokNFtgdVLGqOqyCl9EDEFJZ2p9K2Bu6K1/YSjV1ZKfez4dyRZYFzo2Y+Y0vnDIFXg14uYUXQhicFMz/o2G7U0lkPg8uINTOm+XdFrsM9aC+WFkn33ulM3rR2GaDo7gfuoQ5kXsqL5XvjPWn0lQRauedHZwdnu/d4NS8tgL/jIpF5/Zkz+FUWdOFf8g+9vg/RQKUVvMxwyNxcjY82qc6ZgmgqvEdmJ/9zwpId00hDMBWUUrv7q5NGjV5YFIWUZ+vuDfbxoaUyeSBbVfnJ5w+XxSG464y72/MVW14u5+mfY8GJkw16ERJpkMqes4GNTpsm0qOr2mKL3jL2d0foaM0U/yWAtaPNYuTA2rtvf9aK7rrnTBTRwKUm6x8P/paWJs4tM5p4dBD9XtMSXvQa2UVd4CY3x/Smz+HCsfQgbqV3u7FBbodACg4HoxITpXiaS60hhFiNFFeSHB3dTHGsvtWQwJI7OwvBCaOe+gZAU=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(39860400002)(396003)(136003)(376002)(346002)(36840700001)(46966006)(26005)(186003)(107886003)(426003)(356005)(83380400001)(336012)(16526019)(2906002)(8936002)(6286002)(4326008)(2616005)(86362001)(82310400003)(70206006)(1076003)(8676002)(6916009)(55016002)(36756003)(36860700001)(7696005)(316002)(54906003)(6666004)(36906005)(47076005)(5660300002)(82740400003)(7636003)(70586007)(478600001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 May 2021 21:09:29.0707 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6fcb82a6-7d70-43a8-72eb-08d90f40e7d9", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT057.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW2PR12MB2394", "Subject": "[dpdk-dev] [PATCH v3 03/15] crypto/mlx5: support session operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shiri Kuzin <shirik@nvidia.com>\n\nSessions are used in symmetric transformations in order to prepare\nobjects and data for packet processing stage.\n\nA mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct,\nbsf_size, bsf_p_type, encryption_order and encryption standard.\n\nImplement the next session operations:\n mlx5_crypto_sym_session_get_size- returns the size of the mlx5\n\tsession struct.\n\tmlx5_crypto_sym_session_configure- prepares the DEK hash-list\n\tand saves all the session data.\n\tmlx5_crypto_sym_session_clear - destroys the DEK hash-list.\n\nSigned-off-by: Shiri Kuzin <shirik@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/crypto/mlx5/mlx5_crypto.c | 96 ++++++++++++++++++++++++++++++-\n 1 file changed, 93 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c\nindex 2bdfb1a10f..32f5077066 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.c\n+++ b/drivers/crypto/mlx5/mlx5_crypto.c\n@@ -3,6 +3,7 @@\n */\n \n #include <rte_malloc.h>\n+#include <rte_mempool.h>\n #include <rte_errno.h>\n #include <rte_log.h>\n #include <rte_pci.h>\n@@ -36,6 +37,24 @@ static const struct rte_driver mlx5_drv = {\n \n static struct cryptodev_driver mlx5_cryptodev_driver;\n \n+struct mlx5_crypto_session {\n+\tuint32_t bs_bpt_eo_es;\n+\t/*\n+\t * bsf_size, bsf_p_type, encryption_order and encryption standard,\n+\t * saved in big endian format.\n+\t */\n+\tuint32_t iv_offset:16;\n+\t/* Starting point for Initialisation Vector. */\n+\tstruct mlx5_crypto_dek *dek; /* Pointer to dek struct. */\n+\tuint32_t dek_id; /* DEK ID */\n+} __rte_packed;\n+\n+static unsigned int\n+mlx5_crypto_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)\n+{\n+\treturn sizeof(struct mlx5_crypto_session);\n+}\n+\n static int\n mlx5_crypto_dev_configure(struct rte_cryptodev *dev,\n \t\tstruct rte_cryptodev_config *config __rte_unused)\n@@ -58,6 +77,77 @@ mlx5_crypto_dev_close(struct rte_cryptodev *dev)\n \treturn 0;\n }\n \n+static int\n+mlx5_crypto_sym_session_configure(struct rte_cryptodev *dev,\n+\t\t\t\t struct rte_crypto_sym_xform *xform,\n+\t\t\t\t struct rte_cryptodev_sym_session *session,\n+\t\t\t\t struct rte_mempool *mp)\n+{\n+\tstruct mlx5_crypto_priv *priv = dev->data->dev_private;\n+\tstruct mlx5_crypto_session *sess_private_data;\n+\tstruct rte_crypto_cipher_xform *cipher;\n+\tuint8_t encryption_order;\n+\tint ret;\n+\n+\tif (unlikely(xform->next != NULL)) {\n+\t\tDRV_LOG(ERR, \"Xform next is not supported.\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\tif (unlikely((xform->type != RTE_CRYPTO_SYM_XFORM_CIPHER) ||\n+\t\t (xform->cipher.algo != RTE_CRYPTO_CIPHER_AES_XTS))) {\n+\t\tDRV_LOG(ERR, \"Only AES-XTS algorithm is supported.\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\tret = rte_mempool_get(mp, (void *)&sess_private_data);\n+\tif (ret != 0) {\n+\t\tDRV_LOG(ERR,\n+\t\t\t\"Failed to get session %p private data from mempool.\",\n+\t\t\tsess_private_data);\n+\t\treturn -ENOMEM;\n+\t}\n+\tcipher = &xform->cipher;\n+\tsess_private_data->dek = mlx5_crypto_dek_prepare(priv, cipher);\n+\tif (sess_private_data->dek == NULL) {\n+\t\trte_mempool_put(mp, sess_private_data);\n+\t\tDRV_LOG(ERR, \"Failed to prepare dek.\");\n+\t\treturn -ENOMEM;\n+\t}\n+\tif (cipher->op == RTE_CRYPTO_CIPHER_OP_ENCRYPT)\n+\t\tencryption_order = MLX5_ENCRYPTION_ORDER_ENCRYPTED_RAW_MEMORY;\n+\telse\n+\t\tencryption_order = MLX5_ENCRYPTION_ORDER_ENCRYPTED_RAW_WIRE;\n+\tsess_private_data->bs_bpt_eo_es = rte_cpu_to_be_32\n+\t\t\t(MLX5_BSF_SIZE_64B << MLX5_BSF_SIZE_OFFSET |\n+\t\t\t MLX5_BSF_P_TYPE_CRYPTO << MLX5_BSF_P_TYPE_OFFSET |\n+\t\t\t encryption_order << MLX5_ENCRYPTION_ORDER_OFFSET |\n+\t\t\t MLX5_ENCRYPTION_STANDARD_AES_XTS);\n+\tsess_private_data->iv_offset = cipher->iv.offset;\n+\tsess_private_data->dek_id =\n+\t\t\trte_cpu_to_be_32(sess_private_data->dek->obj->id &\n+\t\t\t\t\t 0xffffff);\n+\tset_sym_session_private_data(session, dev->driver_id,\n+\t\t\t\t sess_private_data);\n+\tDRV_LOG(DEBUG, \"Session %p was configured.\", sess_private_data);\n+\treturn 0;\n+}\n+\n+static void\n+mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev,\n+\t\t\t struct rte_cryptodev_sym_session *sess)\n+{\n+\tstruct mlx5_crypto_priv *priv = dev->data->dev_private;\n+\tstruct mlx5_crypto_session *sess_private_data =\n+\t\t\tget_sym_session_private_data(sess, dev->driver_id);\n+\n+\tif (unlikely(sess_private_data == NULL)) {\n+\t\tDRV_LOG(ERR, \"Failed to get session %p private data.\",\n+\t\t\t\tsess_private_data);\n+\t\treturn;\n+\t}\n+\tmlx5_crypto_dek_destroy(priv, sess_private_data->dek);\n+\tDRV_LOG(DEBUG, \"Session %p was cleared.\", sess_private_data);\n+}\n+\n static struct rte_cryptodev_ops mlx5_crypto_ops = {\n \t.dev_configure\t\t\t= mlx5_crypto_dev_configure,\n \t.dev_start\t\t\t= NULL,\n@@ -68,9 +158,9 @@ static struct rte_cryptodev_ops mlx5_crypto_ops = {\n \t.stats_reset\t\t\t= NULL,\n \t.queue_pair_setup\t\t= NULL,\n \t.queue_pair_release\t\t= NULL,\n-\t.sym_session_get_size\t\t= NULL,\n-\t.sym_session_configure\t\t= NULL,\n-\t.sym_session_clear\t\t= NULL,\n+\t.sym_session_get_size\t\t= mlx5_crypto_sym_session_get_size,\n+\t.sym_session_configure\t\t= mlx5_crypto_sym_session_configure,\n+\t.sym_session_clear\t\t= mlx5_crypto_sym_session_clear,\n \t.sym_get_raw_dp_ctx_size\t= NULL,\n \t.sym_configure_raw_dp_ctx\t= NULL,\n };\n", "prefixes": [ "v3", "03/15" ] }