Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9270/?format=api
{ "id": 9270, "url": "https://patches.dpdk.org/api/patches/9270/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1449118929-19962-5-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449118929-19962-5-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449118929-19962-5-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-03T05:02:01", "name": "[dpdk-dev,v2,04/12] mk: install a standard cutomizable tree", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fab7aec8208ff55799c8ab1a9d635f95a47975b8", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1449118929-19962-5-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/9270/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/9270/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 9A0A68E7F;\n\tThu, 3 Dec 2015 06:03:33 +0100 (CET)", "from mail-wm0-f45.google.com (mail-wm0-f45.google.com\n\t[74.125.82.45]) by dpdk.org (Postfix) with ESMTP id C06428E79\n\tfor <dev@dpdk.org>; Thu, 3 Dec 2015 06:03:30 +0100 (CET)", "by wmec201 with SMTP id c201so6452032wme.1\n\tfor <dev@dpdk.org>; Wed, 02 Dec 2015 21:03:30 -0800 (PST)", "from XPS13.ibrowse.com ([93.158.46.55])\n\tby smtp.gmail.com with ESMTPSA id\n\tgl4sm5720379wjd.17.2015.12.02.21.03.29\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tWed, 02 Dec 2015 21:03:30 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=J3LusbunDVMJAUrC/u0XAOZko4kl+nvteZ04C4OHcYs=;\n\tb=1IgopU5eXySVktK/6tTzYHPlPFpLhYoJfGAJOiq2Tb6IGgA4Nmfrj6DwXc7rfFJUs5\n\tOkbPWa8KORETjuMd1QWXagqYIqtWnUpryaCr819OPG6IW0sExfk7Fdru+VGPebjOT/0k\n\tih8bHO3L39ouujHv1mQxkeszKRCfeZbMZ9nO/jS1IZbSTopTAEXc/NbsWHm5JCjb6QP6\n\t0mqvakoWXCSapNUZnW3wHwwlaU9pU26gs8lXTNUx8ra10DMMPjWVzNtW7EVAeZ2dOJaF\n\tY3hW+mCqUYu0R6GFo9RZUCtg1wkCEH44fNRgHZNoTomnSZhxfH+61mLkx4iFlclv74zK\n\tdOaQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=J3LusbunDVMJAUrC/u0XAOZko4kl+nvteZ04C4OHcYs=;\n\tb=NUKmc+ZD9YmyoJK1qNDBU/08+6DHQrt8+A3GEXQVSc5+3ZsfyfpgAIn/L2L5h0LnJg\n\t/D5TAkOdfViiKFEp+lcqZXW4Im6+OPxuCkeUhviYcpRlgZBTeA5AmFMgRXsv1YitgLMh\n\tKTztIg9gEgRhDlaDxpHMS8Xn4KEeFgAoh2T9mMWtvVZTa6TXth+tmbL4U4yly+M7ccQw\n\tQMP3UmcY3uK953vHC2QflCVFsHu3SX/cMiHQINySgKY0Q0fVaKnI6N0thixQdaDnWXEG\n\tM5AoseYbrfVEpuboPmSOfg5T/WNTx0q+FkuiX7Snd494Aaid3mYeioMH9Fyu4Fcz3deS\n\t1H/w==", "X-Gm-Message-State": "ALoCoQkOf6kj8UCSeN0ayNAAXmNNC3+sglpV4hAQWh+wtn8lHMu6yuuxQXDvmgk1Ry3eUW4RPAS3", "X-Received": "by 10.194.192.198 with SMTP id hi6mr8640852wjc.141.1449119010671;\n\tWed, 02 Dec 2015 21:03:30 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 3 Dec 2015 06:02:01 +0100", "Message-Id": "<1449118929-19962-5-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "In-Reply-To": "<1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 04/12] mk: install a standard cutomizable tree", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The rule \"install\" follows these conventions:\nhttp://gnu.org/prep/standards/html_node/Directory-Variables.html\nhttp://gnu.org/prep/standards/html_node/DESTDIR.html\n\nThe variable sdkdir has been added to the more standards ones,\nto configure the directory used with RTE_SDK when using the DPDK makefiles\nto build an application.\n\nIt is still possible to build DPDK with the \"install T=\" rule without\nspecifying any DESTDIR. In such case there is no install, as before.\n\nThe old usage of an installed SDK is:\n make -C examples/helloworld RTE_SDK=$(readlink -m $DESTDIR) \\\n RTE_TARGET=x86_64-native-linuxapp-gcc\nRTE_TARGET can be specified but is useless now with an installed SDK.\nThe RTE_SDK directory must now point to a different path depending of\nthe installation.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n doc/build-sdk-quick.txt | 1 +\n doc/guides/prog_guide/dev_kit_root_make_help.rst | 6 ++-\n mk/internal/rte.extvars.mk | 4 ++\n mk/rte.sdkinstall.mk | 59 ++++++++++++++++++------\n mk/rte.vars.mk | 10 +---\n 5 files changed, 58 insertions(+), 22 deletions(-)", "diff": "diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt\nindex b5f752e..662ef63 100644\n--- a/doc/build-sdk-quick.txt\n+++ b/doc/build-sdk-quick.txt\n@@ -19,6 +19,7 @@ Build variables\n \tD debug dependencies\n \tO build directory (default: build/ - install default: ./)\n \tDESTDIR second-stage install directory\n+\tprefix root install directory\n \tT target template - used with config or install\n \t\t\tformat: <arch-machine-execenv-toolchain>\n \t\t\ttemplates in config/defconfig_*\ndiff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst b/doc/guides/prog_guide/dev_kit_root_make_help.rst\nindex 458fc91..b0429d8 100644\n--- a/doc/guides/prog_guide/dev_kit_root_make_help.rst\n+++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst\n@@ -111,11 +111,15 @@ Install Targets\n The name of the target to install is specified using T=mytarget.\n The list of available targets are in $(RTE_SDK)/config (remove the defconfig\\_ prefix).\n \n+ The GNU standards variables may be used:\n+ http://gnu.org/prep/standards/html_node/Directory-Variables.html and\n+ http://gnu.org/prep/standards/html_node/DESTDIR.html\n+\n Example:\n \n .. code-block:: console\n \n- make install T=x86_64-native-linuxapp-gcc\n+ make install T=x86_64-native-linuxapp-gcc prefix=/usr\n \n Test Targets\n ------------\ndiff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk\nindex e248d19..040d39f 100644\n--- a/mk/internal/rte.extvars.mk\n+++ b/mk/internal/rte.extvars.mk\n@@ -51,7 +51,11 @@ endif\n RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile\n export RTE_EXTMK\n \n+# RTE_SDK_BIN must point to .config, include/ and lib/.\n RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)\n+ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)\n+$(error Cannot find .config in $(RTE_SDK))\n+endif\n \n #\n # Output files wil go in a separate directory: default output is\ndiff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk\nindex 54ea501..4816998 100644\n--- a/mk/rte.sdkinstall.mk\n+++ b/mk/rte.sdkinstall.mk\n@@ -1,6 +1,7 @@\n # BSD LICENSE\n #\n # Copyright(c) 2010-2014 Intel Corporation. All rights reserved.\n+# Copyright 2015 6WIND S.A.\n # All rights reserved.\n #\n # Redistribution and use in source and binary forms, with or without\n@@ -36,6 +37,25 @@\n O ?= .\n BUILD_DIR := $O/$T\n \n+prefix ?= /usr/local\n+exec_prefix ?= $(prefix)\n+bindir ?= $(exec_prefix)/bin\n+libdir ?= $(exec_prefix)/lib\n+includedir ?= $(prefix)/include/dpdk\n+datarootdir ?= $(prefix)/share\n+datadir ?= $(datarootdir)/dpdk\n+sdkdir ?= $(datadir)\n+targetdir ?= $(datadir)/$(RTE_TARGET)\n+\n+# The install directories may be staged in DESTDIR\n+\n+# Create the directory $1 if not exists\n+rte_mkdir = test -d $1 || mkdir -p $1\n+\n+# Create the relative symbolic link $2 -> $1\n+# May be replaced with --relative option of ln from coreutils-8.16\n+rte_symlink = ln -snf $$($(RTE_SDK)/scripts/relpath.sh $1 $(dir $2)) $2\n+\n .PHONY: pre_install\n pre_install:\n \t$(Q)if [ ! -f $(BUILD_DIR)/.config ]; then \\\n@@ -57,16 +77,29 @@ pre_install:\n \n .PHONY: install\n install: pre_install\n-\t@echo ================== Installing $(DESTDIR)\n-\t$(Q)mkdir -p $(DESTDIR)\n-\t$(Q)tar -C $(RTE_SDK) -cf - mk scripts/*.sh | tar -C $(DESTDIR) -x \\\n-\t --keep-newer-files --warning=no-ignore-newer -f -\n-\t$(Q)mkdir -p $(DESTDIR)/$T\n-\t$(Q)tar -C $(BUILD_DIR) -chf - \\\n-\t --exclude app --exclude hostapp --exclude build \\\n-\t --exclude Makefile --exclude .depdirs . | \\\n-\t tar -C $(DESTDIR)/$T -x --keep-newer-files \\\n-\t --warning=no-ignore-newer -f -\n-\t$(Q)install -D $(BUILD_DIR)/app/testpmd \\\n-\t $(DESTDIR)/$T/app/testpmd\n-\t@echo Installation in $(DESTDIR) complete\n+ifeq ($(DESTDIR)$(if $T,,+),)\n+\t@echo Installation cannot run with T defined and DESTDIR undefined\n+else\n+\t@echo ================== Installing $(DESTDIR)$(prefix)/\n+\t$(Q)$(call rte_mkdir, $(DESTDIR)$(libdir))\n+\t$(Q)cp -a $(BUILD_DIR)/lib/* $(DESTDIR)$(libdir)\n+\t$(Q)$(call rte_mkdir, $(DESTDIR)$(bindir))\n+\t$(Q)tar -cf - -C $(BUILD_DIR) app --exclude 'app/*.map' \\\n+\t\t--exclude 'app/cmdline*' --exclude app/test \\\n+\t\t--exclude app/testacl --exclude app/testpipeline | \\\n+\t tar -xf - -C $(DESTDIR)$(bindir) --strip-components=1 \\\n+\t\t--keep-newer-files --warning=no-ignore-newer\n+\t$(Q)$(call rte_mkdir, $(DESTDIR)$(datadir))\n+\t$(Q)cp -a $(RTE_SDK)/tools $(DESTDIR)$(datadir)\n+\t$(Q)$(call rte_mkdir, $(DESTDIR)$(includedir))\n+\t$(Q)tar -chf - -C $(BUILD_DIR) include | \\\n+\t tar -xf - -C $(DESTDIR)$(includedir) --strip-components=1 \\\n+\t\t--keep-newer-files --warning=no-ignore-newer\n+\t$(Q)$(call rte_mkdir, $(DESTDIR)$(sdkdir))\n+\t$(Q)cp -a $(RTE_SDK)/{mk,scripts} $(DESTDIR)$(sdkdir)\n+\t$(Q)$(call rte_mkdir, $(DESTDIR)$(targetdir))\n+\t$(Q)cp -a $(BUILD_DIR)/.config $(DESTDIR)$(targetdir)\n+\t$(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include)\n+\t$(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib)\n+\t@echo Installation in $(DESTDIR)$(prefix)/ complete\n+endif\ndiff --git a/mk/rte.vars.mk b/mk/rte.vars.mk\nindex f87cf4b..7e7ee14 100644\n--- a/mk/rte.vars.mk\n+++ b/mk/rte.vars.mk\n@@ -61,18 +61,12 @@ ifneq ($(BUILDING_RTE_SDK),)\n RTE_MACHINE := $(CONFIG_RTE_MACHINE:\"%\"=%)\n RTE_EXEC_ENV := $(CONFIG_RTE_EXEC_ENV:\"%\"=%)\n RTE_TOOLCHAIN := $(CONFIG_RTE_TOOLCHAIN:\"%\"=%)\n- RTE_TARGET := $(RTE_ARCH)-$(RTE_MACHINE)-$(RTE_EXEC_ENV)-$(RTE_TOOLCHAIN)\n RTE_SDK_BIN := $(RTE_OUTPUT)\n endif\n \n-RTE_LIBNAME := dpdk\n+RTE_TARGET ?= $(RTE_ARCH)-$(RTE_MACHINE)-$(RTE_EXEC_ENV)-$(RTE_TOOLCHAIN)\n \n-# RTE_TARGET is deducted from config when we are building the SDK.\n-# Else, when building an external app, RTE_TARGET must be specified\n-# by the user.\n-ifeq ($(RTE_TARGET),)\n-$(error RTE_TARGET is not defined)\n-endif\n+RTE_LIBNAME := dpdk\n \n ifeq ($(BUILDING_RTE_SDK),)\n # if we are building an external app/lib, include internal/rte.extvars.mk that will\n", "prefixes": [ "dpdk-dev", "v2", "04/12" ] }