Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9268/?format=api
{ "id": 9268, "url": "https://patches.dpdk.org/api/patches/9268/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1449118929-19962-3-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449118929-19962-3-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449118929-19962-3-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-03T05:01:59", "name": "[dpdk-dev,v2,02/12] mk: remove multi-target install", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "97f69eaeceb203d338a4eac6bc5f2a67aad7632a", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1449118929-19962-3-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/9268/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/9268/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E91E58E6D;\n\tThu, 3 Dec 2015 06:03:29 +0100 (CET)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 34C6D8E58\n\tfor <dev@dpdk.org>; Thu, 3 Dec 2015 06:03:28 +0100 (CET)", "by wmuu63 with SMTP id u63so5940120wmu.0\n\tfor <dev@dpdk.org>; Wed, 02 Dec 2015 21:03:28 -0800 (PST)", "from XPS13.ibrowse.com ([93.158.46.55])\n\tby smtp.gmail.com with ESMTPSA id\n\tgl4sm5720379wjd.17.2015.12.02.21.03.26\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tWed, 02 Dec 2015 21:03:27 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=jiIcJVAinSXbrB91d1Bl+fyngxLmyxNK0j7TL/e44cY=;\n\tb=rnJiAImPccYLWAqr81dhxidbcBdA47PRv8Yq1Iy/JJh8i1tMEehHYpZfFCzJUJxK51\n\t73vNM9/6yTPFUWEQsDD4wxWD4g4xKlC4NeUcQYWe+kgzgxIltjDFZ+IQxxdga3OdlV5O\n\th8OX6TbOTBbCG0fU3iVjL54lrBX8WvMl0gVvn5zjmr28zEQQfhLHdDdT8Z/1R9trWI1G\n\tYTTeGUAO9gRkZPg5afc+6fJPvOFcyjstRzy3FEFe3Hwy3qikfZpOe3HZYKUWLp1P3Jde\n\tla0bhk+2PVwnpSxdU1JK5oFIDWnmfdCPERwaFhKM2xfuXLCH2JqOPif5uuiRqU+tFKsm\n\taIXw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=jiIcJVAinSXbrB91d1Bl+fyngxLmyxNK0j7TL/e44cY=;\n\tb=TmFrc0qevLnlYF8EthYxYeeVZsbyQwViRh7WVlghghTU5Ep9oxULwsCXA2vpDEMfE1\n\ttZi60C2hcj9kXuTpva1xBkVD4Qt6+9OzRV4/0Z32ChOZg9dYnhO1hcO2dblWVYqhzS8Y\n\txOl6kW6TfMIfeLuwsydRf99sgTNi6USDIomKwVksWQik8pOVtp8+wxoHsz80TQfY40nZ\n\tJUW8aRGu8kZxqsCSTynuy5GmN731P6+q7US54OKae172SZ/RuHcBu2sAywsTh02v21Dx\n\ti4Bz+9EhpRDiYsNjJEreIdj0Ja1qTfD5Xc0daACWYM5UvUb+H/b1igbBBM6L7KGyi+KE\n\tFakg==", "X-Gm-Message-State": "ALoCoQlAwKk35pfXT7rPrAl6L6b99ASjMwZrDms6rrldn3+2QaKOf+IxCBlDBR7HCXaaUCBM/HfS", "X-Received": "by 10.28.214.143 with SMTP id n137mr49899328wmg.2.1449119008063; \n\tWed, 02 Dec 2015 21:03:28 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 3 Dec 2015 06:01:59 +0100", "Message-Id": "<1449118929-19962-3-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "In-Reply-To": "<1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 02/12] mk: remove multi-target install", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The multi-target install create some subdirectories with the target name\nwhich is not standard for a \"make install\" procedure.\n\nThe uninstall procedure cannot be applied properly (without removing\nall files in a directory). It would need to pre-compute paths.\nAs it is a packaging issue, it is removed from the build system capabilities.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n doc/build-sdk-quick.txt | 5 +-\n doc/guides/linux_gsg/build_dpdk.rst | 16 ------\n doc/guides/prog_guide/dev_kit_root_make_help.rst | 11 +----\n mk/rte.sdkinstall.mk | 62 ++++++------------------\n mk/rte.sdkroot.mk | 4 +-\n tools/setup.sh | 31 ++++--------\n 6 files changed, 32 insertions(+), 97 deletions(-)", "diff": "diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt\nindex bf18b48..b5f752e 100644\n--- a/doc/build-sdk-quick.txt\n+++ b/doc/build-sdk-quick.txt\n@@ -5,8 +5,7 @@ Build commands\n \tall same as build (default rule)\n \tbuild build in a configured directory\n \tclean remove files but keep configuration\n-\tinstall build many targets (wildcard allowed) and install in DESTDIR\n-\tuninstall remove all installed targets\n+\tinstall configure, build and install a target in DESTDIR\n \texamples build examples for given targets (T=)\n \texamples_clean clean examples for given targets (T=)\n Build variables\n@@ -20,6 +19,6 @@ Build variables\n \tD debug dependencies\n \tO build directory (default: build/ - install default: ./)\n \tDESTDIR second-stage install directory\n-\tT target template (install default: *) - used with config or install\n+\tT target template - used with config or install\n \t\t\tformat: <arch-machine-execenv-toolchain>\n \t\t\ttemplates in config/defconfig_*\ndiff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/build_dpdk.rst\nindex 2680e66..fd0fcc8 100644\n--- a/doc/guides/linux_gsg/build_dpdk.rst\n+++ b/doc/guides/linux_gsg/build_dpdk.rst\n@@ -110,22 +110,6 @@ To compile a 32-bit build using gcc, the make command should be:\n \n make install T=i686-native-linuxapp-gcc\n \n-To compile all 64-bit targets using gcc, use:\n-\n-.. code-block:: console\n-\n- make install T=x86_64*gcc\n-\n-To compile all 64-bit targets using both gcc and icc, use:\n-\n-.. code-block:: console\n-\n- make install T=x86_64-*\n-\n-.. note::\n-\n- The wildcard operator (*) can be used to create multiple targets at the same time.\n-\n To prepare a target without building it, for example, if the configuration changes need to be made before compilation,\n use the make config T=<target> command:\n \ndiff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst b/doc/guides/prog_guide/dev_kit_root_make_help.rst\nindex e02c544..458fc91 100644\n--- a/doc/guides/prog_guide/dev_kit_root_make_help.rst\n+++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst\n@@ -108,21 +108,14 @@ Install Targets\n * Install\n \n Build the DPDK binary.\n- Actually, this builds each supported target in a separate directory.\n- The name of each directory is the name of the target.\n- The name of the targets to install can be optionally specified using T=mytarget.\n- The target name can contain wildcard \\* characters.\n+ The name of the target to install is specified using T=mytarget.\n The list of available targets are in $(RTE_SDK)/config (remove the defconfig\\_ prefix).\n \n Example:\n \n .. code-block:: console\n \n- make install T=x86_64-*\n-\n-* Uninstall\n-\n- Remove installed target directories.\n+ make install T=x86_64-native-linuxapp-gcc\n \n Test Targets\n ------------\ndiff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk\nindex 86c98a5..3e6e8ca 100644\n--- a/mk/rte.sdkinstall.mk\n+++ b/mk/rte.sdkinstall.mk\n@@ -29,59 +29,29 @@\n # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n \n-# Build directory is given with O=\n-ifdef O\n-BUILD_DIR=$(O)\n-else\n-BUILD_DIR=.\n-endif\n+# Configuration, compilation and installation can be done at once\n+# with make install T=<config>\n \n-# Targets to install can be specified in command line. It can be a\n-# target name or a name containing jokers \"*\". Example:\n-# x86_64-native-*-gcc\n-ifndef T\n-T=*\n-endif\n-\n-#\n-# install: build sdk for all supported targets\n-#\n-INSTALL_CONFIGS := $(patsubst $(RTE_SRCDIR)/config/defconfig_%,%,\\\n-\t$(wildcard $(RTE_SRCDIR)/config/defconfig_$(T)))\n-INSTALL_TARGETS := $(addsuffix _install,\\\n-\t$(filter-out %~,$(INSTALL_CONFIGS)))\n+# The build directory is T and may be prepended with O\n+O ?= .\n+BUILD_DIR := $O/$T\n \n .PHONY: install\n-install: $(INSTALL_TARGETS)\n-\n-%_install:\n-\t@echo ================== Installing $*\n-\t$(Q)if [ ! -f $(BUILD_DIR)/$*/.config ]; then \\\n-\t\t$(MAKE) config T=$* O=$(BUILD_DIR)/$*; \\\n-\telif cmp -s $(BUILD_DIR)/$*/.config.orig $(BUILD_DIR)/$*/.config; then \\\n-\t\t$(MAKE) config T=$* O=$(BUILD_DIR)/$*; \\\n+install:\n+\t@echo ================== Installing $T\n+\t$(Q)if [ ! -f $(BUILD_DIR)/.config ]; then \\\n+\t\t$(MAKE) config T=$T O=$(BUILD_DIR); \\\n+\telif cmp -s $(BUILD_DIR)/.config.orig $(BUILD_DIR)/.config; then \\\n+\t\t$(MAKE) config T=$T O=$(BUILD_DIR); \\\n \telse \\\n-\t\tif [ -f $(BUILD_DIR)/$*/.config.orig ] ; then \\\n-\t\t\ttmp_build=$(BUILD_DIR)/$*/.config.tmp; \\\n-\t\t\t$(MAKE) config T=$* O=$$tmp_build; \\\n-\t\t\tif ! cmp -s $(BUILD_DIR)/$*/.config.orig $$tmp_build/.config ; then \\\n+\t\tif [ -f $(BUILD_DIR)/.config.orig ] ; then \\\n+\t\t\ttmp_build=$(BUILD_DIR)/.config.tmp; \\\n+\t\t\t$(MAKE) config T=$T O=$$tmp_build; \\\n+\t\t\tif ! cmp -s $(BUILD_DIR)/.config.orig $$tmp_build/.config ; then \\\n \t\t\t\techo \"Conflict: local config and template config have both changed\"; \\\n \t\t\t\texit 1; \\\n \t\t\tfi; \\\n \t\tfi; \\\n \t\techo \"Using local configuration\"; \\\n \tfi\n-\t$(Q)$(MAKE) all O=$(BUILD_DIR)/$*\n-\n-#\n-# uninstall: remove all built sdk\n-#\n-UNINSTALL_TARGETS := $(addsuffix _uninstall,\\\n-\t$(filter-out %~,$(INSTALL_CONFIGS)))\n-\n-.PHONY: uninstall\n-uninstall: $(UNINSTALL_TARGETS)\n-\n-%_uninstall:\n-\t@echo ================== Uninstalling $*\n-\t$(Q)rm -rf $(BUILD_DIR)/$*\n+\t$(Q)$(MAKE) all O=$(BUILD_DIR)\ndiff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk\nindex 0e97308..9fdecf4 100644\n--- a/mk/rte.sdkroot.mk\n+++ b/mk/rte.sdkroot.mk\n@@ -93,8 +93,8 @@ config showconfigs showversion:\n test fast_test ring_test mempool_test perf_test coverage:\n \t$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@\n \n-.PHONY: install uninstall\n-install uninstall:\n+.PHONY: install\n+install:\n \t$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkinstall.mk $@\n \n .PHONY: doc help\ndiff --git a/tools/setup.sh b/tools/setup.sh\nindex 5a8b2f3..58a08e7 100755\n--- a/tools/setup.sh\n+++ b/tools/setup.sh\n@@ -105,14 +105,6 @@ setup_target()\n }\n \n #\n-# Uninstall all targets.\n-#\n-uninstall_targets()\n-{\n-\tmake uninstall\n-}\n-\n-#\n # Creates hugepage filesystem.\n #\n create_mnt_huge()\n@@ -571,23 +563,20 @@ step5_func()\n {\n \tTITLE=\"Uninstall and system cleanup\"\n \n-\tTEXT[1]=\"Uninstall all targets\"\n-\tFUNC[1]=\"uninstall_targets\"\n-\n-\tTEXT[2]=\"Unbind NICs from IGB UIO or VFIO driver\"\n-\tFUNC[2]=\"unbind_nics\"\n+\tTEXT[1]=\"Unbind NICs from IGB UIO or VFIO driver\"\n+\tFUNC[1]=\"unbind_nics\"\n \n-\tTEXT[3]=\"Remove IGB UIO module\"\n-\tFUNC[3]=\"remove_igb_uio_module\"\n+\tTEXT[2]=\"Remove IGB UIO module\"\n+\tFUNC[2]=\"remove_igb_uio_module\"\n \n-\tTEXT[4]=\"Remove VFIO module\"\n-\tFUNC[4]=\"remove_vfio_module\"\n+\tTEXT[3]=\"Remove VFIO module\"\n+\tFUNC[3]=\"remove_vfio_module\"\n \n-\tTEXT[5]=\"Remove KNI module\"\n-\tFUNC[5]=\"remove_kni_module\"\n+\tTEXT[4]=\"Remove KNI module\"\n+\tFUNC[4]=\"remove_kni_module\"\n \n-\tTEXT[6]=\"Remove hugepage mappings\"\n-\tFUNC[6]=\"clear_huge_pages\"\n+\tTEXT[5]=\"Remove hugepage mappings\"\n+\tFUNC[5]=\"clear_huge_pages\"\n }\n \n STEPS[1]=\"step1_func\"\n", "prefixes": [ "dpdk-dev", "v2", "02/12" ] }