Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92442/?format=api
{ "id": 92442, "url": "https://patches.dpdk.org/api/patches/92442/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210429154712.2820159-11-matan@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210429154712.2820159-11-matan@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210429154712.2820159-11-matan@nvidia.com", "date": "2021-04-29T15:47:07", "name": "[v2,10/15] crypto/mlx5: add keytag device argument", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c4b914f03e617ade0da1c5aba94bd2329fe40646", "submitter": { "id": 1911, "url": "https://patches.dpdk.org/api/people/1911/?format=api", "name": "Matan Azrad", "email": "matan@nvidia.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210429154712.2820159-11-matan@nvidia.com/mbox/", "series": [ { "id": 16765, "url": "https://patches.dpdk.org/api/series/16765/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16765", "date": "2021-04-29T15:46:57", "name": "drivers: introduce mlx5 crypto PMD", "version": 2, "mbox": "https://patches.dpdk.org/series/16765/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92442/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92442/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E79BCA0547;\n\tThu, 29 Apr 2021 17:48:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DF4A34133B;\n\tThu, 29 Apr 2021 17:48:37 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2082.outbound.protection.outlook.com [40.107.94.82])\n by mails.dpdk.org (Postfix) with ESMTP id 61BF341360\n for <dev@dpdk.org>; Thu, 29 Apr 2021 17:48:33 +0200 (CEST)", "from DM5PR13CA0035.namprd13.prod.outlook.com (2603:10b6:3:7b::21) by\n CH0PR12MB5058.namprd12.prod.outlook.com (2603:10b6:610:e1::8) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4065.21; Thu, 29 Apr 2021 15:48:31 +0000", "from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com\n (2603:10b6:3:7b:cafe::7a) by DM5PR13CA0035.outlook.office365.com\n (2603:10b6:3:7b::21) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.8 via Frontend\n Transport; Thu, 29 Apr 2021 15:48:31 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4087.32 via Frontend Transport; Thu, 29 Apr 2021 15:48:31 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Apr\n 2021 15:48:29 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=lNMZlTtChuSiODHobjVFfSktgsQQDdsNvK5Aeondlc2ONj4Ben0+JmvfbmXvn9QIGJE8hhi92InF2aQDKQBy4NSRyi9jKJcQARvDQETGdkg6mPNAOPnCsAsK0b54dXig4qK5cpPmyasjrCGP8Ua2WquwuZi5KZWakNzuVvdlBwZi/0AiX4i4eiIv+8npGZyiQ0R+sOZn44ndcq4ayxXLFlKbqic5FzIOCwJR7eLgQTr1nqZyUhz4gmSD+suXkxN5K6d21dXBibKyxYfkgxodKfl1miY0wpMP+dzFKBBxGXgMrwWBNKlb63/9zM6A5QHwXkC0oQpdkROrPdHo7OV09w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=bB9umH0+Odl2ZBEoGWqnlFGR+ICM52npfAw6cZ2TV20=;\n b=aDYjKx0+5Ymo1jTDV6o6vrYJQL+iEj3O3PyJof3OrCDY6s/kih/3V8C5+hLPnm7xC/yz0SSKmjCZQlsOxQNmqbNuVkLNVXXd5JGepGm9xgUYbmh6oJfeu8DwE0uHbxNXAvADK9tA0W2KcvuT1AR+akJnMZV6JTpG+4iypu9Ar/LTp1nuAWG2lO76dSysvxtTftOb+6Ith5q0COb5LJxMoKDccFR91hfarVMa6C53HGxQQwPCzktCJXi4/JMZk/8XaeOxfVUO83i/w+Zx7bo/RknU0d0Z5uAwTcTuETCGv2oD5Ase8kGFK4Ybb6HsEGj8qqI2922fo5yDzjJR17lClQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=bB9umH0+Odl2ZBEoGWqnlFGR+ICM52npfAw6cZ2TV20=;\n b=rRjTu3uqygnUBV4oB+KMMu44HEj/8jrFhmi7SA6AzNUd05Btpn06KM5z1IR3AqJVC0NFjXps8j0VbYbRcN48ceuQnMf5RrtitDYKn5iGIIcEhQiIJOcB02TiyIvFYITomcwnz2kIxfDgB+cPORMMcBMNMAq8udYtYzdx5Z9LZ67XPjJY/iNUex2b15q2CiCktASVrcb3KwnCtO7oxgjmxRlLaaOYMUfG8e/umvi0DfbA5IgD31V6crFEfmCfk0Lv2mrNh1rJoKY53lsDl7bqUsSrEk8MLLNQVrlPcysmdnO6TPTKJT/qmnHufNP0olqRmNWTW7PySYwgn9RS1IuApw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; marvell.com; dkim=none (message not signed)\n header.d=none;marvell.com; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Matan Azrad <matan@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<matan@nvidia.com>, <gakhil@marvell.com>, <suanmingm@nvidia.com>", "Date": "Thu, 29 Apr 2021 18:47:07 +0300", "Message-ID": "<20210429154712.2820159-11-matan@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210429154712.2820159-1-matan@nvidia.com>", "References": "<20210408204849.9543-1-shirik@nvidia.com>\n <20210429154712.2820159-1-matan@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "a8c5dde6-9940-443c-7008-08d90b263d7a", "X-MS-TrafficTypeDiagnostic": "CH0PR12MB5058:", "X-Microsoft-Antispam-PRVS": "\n <CH0PR12MB50584203139EF7904BA3C572DF5F9@CH0PR12MB5058.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:125;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n t0+DBI7RW/9kD5eZaTEt7wfbQch7ixSaEDghOZysMYKfzmmjHdjnm3En+IU46qcYROfj0CU+d3M9C95IXSlcfaMUkZ7rPVq2cPteVjL3Jewwa6YTxRnO52yfuaQ9lXWpoibDf6nhJhDPeJO4bFv0tEKhon8ubfA+Do3VmkBbsAhzcV5EzEnWnwimobHI4Pife0a3E8LK7O8ICYlUVCPS2eu8RF1ypcfuzhtgtZ3i3ep+6etWbrYu4tsJvmZlLy8w5lcC4IuRpyKSmcLdx/thK7W4ZzqwZLDqLIdVwq5sVCv2ZPxMD/3fsGYTE7TtwcXRWLqxWfPaoJTQYBW6idcc63zUXe8yt+ytIJhnsHityd66QMIEU3BEdgFLcKmfBqm0Gvn+FiWnFKuWlJUHwdC0x6JAFGyDIfAH1m/jHfZXHqG+K35XMeyEX7RDFzIMhrMxoB2KK+KKAXK9aDAoIqC/OpQD0GQpGFVVL3JTBem4BAH5oVfd9xti8rmmae+IWottVRAQ9PD0tidwSPL6pgfc4ooSgievMCooKJlrBRbbTCK2ijp9d9+oTpB5CXRYihPf4BK91f/y5e3VQZB/YP+OTCA9oU1BhKezKXCbMsBeSUc7SOM2pQNMQdnwv+9Y80B4wtQjlu6O0iRf55Y8d+bLR67XQ6TZKJ12xEz6gqzYAhs=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(376002)(136003)(39860400002)(396003)(346002)(46966006)(36840700001)(5660300002)(83380400001)(6286002)(36906005)(8936002)(2616005)(6916009)(36756003)(26005)(4326008)(55016002)(54906003)(478600001)(82310400003)(426003)(107886003)(70586007)(8676002)(70206006)(6666004)(186003)(356005)(7696005)(86362001)(7636003)(36860700001)(47076005)(16526019)(2906002)(1076003)(82740400003)(336012)(316002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "29 Apr 2021 15:48:31.6703 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a8c5dde6-9940-443c-7008-08d90b263d7a", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT014.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH0PR12MB5058", "Subject": "[dpdk-dev] [PATCH v2 10/15] crypto/mlx5: add keytag device argument", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Suanming Mou <suanmingm@nvidia.com>\n\nA keytag is a piece of data encrypted together with a DEK.\n\nWhen a DEK is referenced by an MKEY.bsf through its index, the keytag is\nalso supplied in the BSF as plaintext. The HW will decrypt the DEK (and\nthe attached keytag) and will fail the operation if the keytags don't\nmatch.\n\nThis commit adds the configuration of the keytag with devargs.\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\nSigned-off-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/crypto/mlx5/mlx5_crypto.c | 50 +++++++++++++++++--------------\n drivers/crypto/mlx5/mlx5_crypto.h | 3 +-\n 2 files changed, 30 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c\nindex 1dcebce04c..9f270e4382 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.c\n+++ b/drivers/crypto/mlx5/mlx5_crypto.c\n@@ -468,56 +468,52 @@ mlx5_crypto_args_check_handler(const char *key, const char *val, void *opaque)\n \t\tattr->session_import_kek_ptr = (uint32_t)tmp;\n \telse if (strcmp(key, \"credential_id\") == 0)\n \t\tattr->credential_pointer = (uint32_t)tmp;\n+\telse if (strcmp(key, \"keytag\") == 0)\n+\t\tdevarg_prms->keytag = tmp;\n \telse\n \t\tDRV_LOG(WARNING, \"Invalid key %s.\", key);\n \treturn 0;\n }\n \n-static struct mlx5_devx_obj *\n-mlx5_crypto_config_login(struct rte_devargs *devargs,\n-\t\t\t struct ibv_context *ctx)\n+static int\n+mlx5_crypto_parse_devargs(struct rte_devargs *devargs,\n+\t\t\t struct mlx5_crypto_devarg_params *devarg_prms)\n {\n-\t/*\n-\t * Set credential pointer and session import KEK pointer to a default\n-\t * value of 0.\n-\t */\n-\tstruct mlx5_crypto_devarg_params login = {\n-\t\t\t.login_devarg = false,\n-\t\t\t.login_attr = {\n-\t\t\t\t\t.credential_pointer = 0,\n-\t\t\t\t\t.session_import_kek_ptr = 0,\n-\t\t\t}\n-\t};\n+\tstruct mlx5_devx_crypto_login_attr *attr = &devarg_prms->login_attr;\n \tstruct rte_kvargs *kvlist;\n \n+\t/* Default values. */\n+\tattr->credential_pointer = 0;\n+\tattr->session_import_kek_ptr = 0;\n+\tdevarg_prms->keytag = 0;\n \tif (devargs == NULL) {\n \t\tDRV_LOG(ERR,\n \t\"No login devargs in order to enable crypto operations in the device.\");\n \t\trte_errno = EINVAL;\n-\t\treturn NULL;\n+\t\treturn -1;\n \t}\n \tkvlist = rte_kvargs_parse(devargs->args, NULL);\n \tif (kvlist == NULL) {\n \t\tDRV_LOG(ERR, \"Failed to parse devargs.\");\n \t\trte_errno = EINVAL;\n-\t\treturn NULL;\n+\t\treturn -1;\n \t}\n \tif (rte_kvargs_process(kvlist, NULL, mlx5_crypto_args_check_handler,\n-\t\t\t &login) != 0) {\n+\t\t\t devarg_prms) != 0) {\n \t\tDRV_LOG(ERR, \"Devargs handler function Failed.\");\n \t\trte_kvargs_free(kvlist);\n \t\trte_errno = EINVAL;\n-\t\treturn NULL;\n+\t\treturn -1;\n \t}\n \trte_kvargs_free(kvlist);\n-\tif (login.login_devarg == false) {\n+\tif (devarg_prms->login_devarg == false) {\n \t\tDRV_LOG(ERR,\n \t\"No login credential devarg in order to enable crypto operations \"\n \t\"in the device.\");\n \t\trte_errno = EINVAL;\n-\t\treturn NULL;\n+\t\treturn -1;\n \t}\n-\treturn mlx5_devx_cmd_create_crypto_login_obj(ctx, &login.login_attr);\n+\treturn 0;\n }\n \n /**\n@@ -543,6 +539,7 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \tstruct ibv_context *ctx;\n \tstruct mlx5_devx_obj *login;\n \tstruct mlx5_crypto_priv *priv;\n+\tstruct mlx5_crypto_devarg_params devarg_prms = { 0 };\n \tstruct mlx5_hca_attr attr = { 0 };\n \tstruct rte_cryptodev_pmd_init_params init_params = {\n \t\t.name = \"\",\n@@ -551,6 +548,8 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \t\t.max_nb_queue_pairs =\n \t\t\t\tRTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS,\n \t};\n+\tint ret;\n+\n \tRTE_SET_USED(pci_drv);\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n \t\tDRV_LOG(ERR, \"Non-primary process type is not supported.\");\n@@ -580,7 +579,13 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \t\trte_errno = ENOTSUP;\n \t\treturn -ENOTSUP;\n \t}\n-\tlogin = mlx5_crypto_config_login(pci_dev->device.devargs, ctx);\n+\tret = mlx5_crypto_parse_devargs(pci_dev->device.devargs, &devarg_prms);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"Failed to parse devargs.\");\n+\t\treturn -rte_errno;\n+\t}\n+\tlogin = mlx5_devx_cmd_create_crypto_login_obj(ctx,\n+\t\t\t\t\t\t &devarg_prms.login_attr);\n \tif (login == NULL) {\n \t\tDRV_LOG(ERR, \"Failed to configure login.\");\n \t\treturn -rte_errno;\n@@ -620,6 +625,7 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \t}\n \tpriv->mr_scache.reg_mr_cb = mlx5_common_verbs_reg_mr;\n \tpriv->mr_scache.dereg_mr_cb = mlx5_common_verbs_dereg_mr;\n+\tpriv->keytag = rte_cpu_to_be_64(devarg_prms.keytag);\n \tpthread_mutex_lock(&priv_list_lock);\n \tTAILQ_INSERT_TAIL(&mlx5_crypto_priv_list, priv, next);\n \tpthread_mutex_unlock(&priv_list_lock);\ndiff --git a/drivers/crypto/mlx5/mlx5_crypto.h b/drivers/crypto/mlx5/mlx5_crypto.h\nindex 0aef804b92..34c65f9a24 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.h\n+++ b/drivers/crypto/mlx5/mlx5_crypto.h\n@@ -30,6 +30,7 @@ struct mlx5_crypto_priv {\n \tstruct rte_cryptodev_config dev_config;\n \tstruct mlx5_mr_share_cache mr_scache; /* Global shared MR cache. */\n \tstruct mlx5_devx_obj *login_obj;\n+\tuint64_t keytag;\n };\n \n struct mlx5_crypto_qp {\n@@ -49,10 +50,10 @@ struct mlx5_crypto_dek {\n \tbool size_is_48; /* Whether the key\\data size is 48 bytes or not. */\n };\n \n-\n struct mlx5_crypto_devarg_params {\n \tbool login_devarg;\n \tstruct mlx5_devx_crypto_login_attr login_attr;\n+\tuint64_t keytag;\n };\n \n int\n", "prefixes": [ "v2", "10/15" ] }