Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92440/?format=api
{ "id": 92440, "url": "https://patches.dpdk.org/api/patches/92440/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210429154712.2820159-9-matan@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210429154712.2820159-9-matan@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210429154712.2820159-9-matan@nvidia.com", "date": "2021-04-29T15:47:05", "name": "[v2,08/15] crypto/mlx5: create login object using DevX", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "312afbc0ed9711253aba48c5171b1588eca8ab12", "submitter": { "id": 1911, "url": "https://patches.dpdk.org/api/people/1911/?format=api", "name": "Matan Azrad", "email": "matan@nvidia.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210429154712.2820159-9-matan@nvidia.com/mbox/", "series": [ { "id": 16765, "url": "https://patches.dpdk.org/api/series/16765/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16765", "date": "2021-04-29T15:46:57", "name": "drivers: introduce mlx5 crypto PMD", "version": 2, "mbox": "https://patches.dpdk.org/series/16765/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92440/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92440/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 72DA4A0547;\n\tThu, 29 Apr 2021 17:48:31 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0364D41328;\n\tThu, 29 Apr 2021 17:48:24 +0200 (CEST)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48])\n by mails.dpdk.org (Postfix) with ESMTP id C79BD41216\n for <dev@dpdk.org>; Thu, 29 Apr 2021 17:48:22 +0200 (CEST)", "from DM5PR12CA0014.namprd12.prod.outlook.com (2603:10b6:4:1::24) by\n MWHPR12MB1934.namprd12.prod.outlook.com (2603:10b6:300:109::23) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Thu, 29 Apr\n 2021 15:48:21 +0000", "from DM6NAM11FT058.eop-nam11.prod.protection.outlook.com\n (2603:10b6:4:1:cafe::65) by DM5PR12CA0014.outlook.office365.com\n (2603:10b6:4:1::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend\n Transport; Thu, 29 Apr 2021 15:48:21 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT058.mail.protection.outlook.com (10.13.172.216) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4087.27 via Frontend Transport; Thu, 29 Apr 2021 15:48:20 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Apr\n 2021 15:48:18 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=iGz3qiEyfWySFjlWNXFOCYySx28HHwnGVuj9xZKQRxpZtAfwkhNG0n0HbKY9fc8YhtD3SpVxIn3Zu9a0b4SzSconAZjBje/wm0sq+zQp2h7ZlKdLphHmfwfZdjlrViKNNmXs/G1fUPRXGczDDmvmnajAyPGBAHXaKFxyFtTjmbx/m6pUud8XOcwB+Y209cIuJMMf58Rr7ck9K3rn+yq1cdNoVM9bLZI7ds7KQmZL8skRXuB4p6neavWN5ndpwWI9S2AxJ5rgH503PeFWpaWvAlKlepW2NjcQKFGtHRyQL0Jzkzt1nQGyn7oVKh7CoTmFAK0Pck2F+BR3wyWcqzErHg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=VCps/VNbLsNaaq8F6oZhD45vLXHm1hrwbW/5vkkG8pA=;\n b=c0xfBpxJTFUyUPd5d6D6VK0RrxVIY6HHibUJdPJP3iQaohpbVWnt7roGjeyP6TcjIiFHmwDArHfQlblVurtrI7fGYUjFZcN4lyx676ixOABQf+0JFc3LViw05nCdX/bV2eWxj+IAicH9/PwglAJJdz9xO3WWGZkSiclh824iQIcIPVRPu7nN0BSwNahL3F4d3aXpwW3vDumDgT9GOhQU8TjpxhN1DcrpH8NE42BOy+kugxFrXBUCgpwPTeHaF+VlubuUe6J3tWZDPN3sgI4kURITCXzklg7/9w+ijDB0koOkF4rWMCe6DYoz1g+OAlkq6olcS0r6k5kzIersy/yS6w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=VCps/VNbLsNaaq8F6oZhD45vLXHm1hrwbW/5vkkG8pA=;\n b=mzyhgTpwltvBm4HOGbhzvmNmCiLaliedcJFXhe7IGr7WTDgvEwzLRymd7TpNFAOg53JX/ino/UC3D7JcRnnCECEpoul7utkx3G3/YLDvpHdE53wzyaBkR9GtOk/4uwnqCVk16Lyn+F0/GUhdve+AVs8HPBHPjKuh22AH+ouj18NybNHxYzVzhr7b+vFSYnvximUaQCZeDgWaN6fbv8wTEWPt28lAxyEd0F5hn7BlLT1tEFdchKbVPwGIDesaL915kvyhH4X0W1fyu621S2zLYBmBwHYLNTkqNIzcyTiGiMPqRSzBJVYh2aGAd96vGE+WPQjZkck96iINi4V1DnrbTQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; marvell.com; dkim=none (message not signed)\n header.d=none;marvell.com; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Matan Azrad <matan@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<matan@nvidia.com>, <gakhil@marvell.com>, <suanmingm@nvidia.com>, \"Shiri\n Kuzin\" <shirik@nvidia.com>", "Date": "Thu, 29 Apr 2021 18:47:05 +0300", "Message-ID": "<20210429154712.2820159-9-matan@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210429154712.2820159-1-matan@nvidia.com>", "References": "<20210408204849.9543-1-shirik@nvidia.com>\n <20210429154712.2820159-1-matan@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "1ccf7a44-6baf-4ab6-bbaf-08d90b263717", "X-MS-TrafficTypeDiagnostic": "MWHPR12MB1934:", "X-Microsoft-Antispam-PRVS": "\n <MWHPR12MB1934C6DF2F130726FD552812DF5F9@MWHPR12MB1934.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:92;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n sQCkBLbdpdXBfn/bPYDQqsvp18VjfwF3nC34V9qM8OqbQTX8+OsHwugYf3ToAXFmGWPdQ7t6wGXcNolBmGIcqhHYS6byPzIMiygCjPtJJOswPonPJGjYQmyjssq4AMxBQOEbLNGyhYHR2RsXEuYITufkfAT+agdVT1fxFl0HgE8xjD6VR11mkWiITSFtHFday1vUuzUN+QZ0XPFW7bor52+bkLnAsHfqtgAfnuFserLRAEMH/9sIEVPqmMZ1FOh4I79hNPTTtNI4Q68ThWVO94bW1KthU4GLl7ki9l1NWEO0fRSBPgHE7wdypA3iyWxYrzd2gEyMve9IjyjYbPVrYQv6dTlstk1GjP7o3IAaie9GE26TfajiyuGi7KMQxyhO6D09fAluTBiVMi3LPjtls0L7Ey8MDQcIp92IOmsnIRPxPDTli6mAUwDOjoJVp6xsX/R4LzJ8S8O9JOBmU7CQjClewmWLR3Jf1gmdMKfcdgGjbucQ4sCj8Gzlf9j98hA0jFpR4BVm8CULgQ8Duw23r3qimaqW7SSspZudO6o/iyv0vC+X3AFJVdPm5DXU0SHAIPBwFvMsWgvNzoLGpIzPLCMkeiQqrsnwe93dBUjBAI7zlsScyw4GtyFjQPzbFsv76qM1aLsE1+aB3zchsa+XtPMq6jUQGsW1OFewNBURkb4=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(396003)(376002)(346002)(136003)(39860400002)(36840700001)(46966006)(5660300002)(16526019)(70586007)(1076003)(82310400003)(186003)(86362001)(107886003)(70206006)(55016002)(36906005)(26005)(6916009)(54906003)(6666004)(478600001)(6286002)(7636003)(7696005)(2906002)(83380400001)(47076005)(4326008)(82740400003)(316002)(356005)(8676002)(426003)(2616005)(8936002)(36860700001)(36756003)(336012);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "29 Apr 2021 15:48:20.8292 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1ccf7a44-6baf-4ab6-bbaf-08d90b263717", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT058.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MWHPR12MB1934", "Subject": "[dpdk-dev] [PATCH v2 08/15] crypto/mlx5: create login object using\n DevX", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shiri Kuzin <shirik@nvidia.com>\n\nTo work with crypto engines that are marked with wrapped_import_method,\na login session is required.\nA crypto login object needs to be created using DevX.\n\nThe crypto login object contains:\n\t- The credential pointer.\n\t- The import_KEK pointer to be used for all secured information\n\t communicated in crypto commands (key fields), including the\n\t provided credential in this command.\n\t- The credential secret, wrapped by the import_KEK indicated in\n\t this command. Size includes 8 bytes IV for wrapping.\n\nAdded devargs for the required login values:\n\t- wcs_file - path to the file containing the credential.\n\t- import_kek_id - the import KEK pointer.\n\t- credential_id - the credential pointer.\n\nCreate the login DevX object in pci_probe function and destroy it in\npci_remove.\nDestroying the crypto login object means logout.\n\nSigned-off-by: Shiri Kuzin <shirik@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/crypto/mlx5/mlx5_crypto.c | 103 ++++++++++++++++++++++++++++++\n drivers/crypto/mlx5/mlx5_crypto.h | 7 ++\n 2 files changed, 110 insertions(+)", "diff": "diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c\nindex 79e3d3ee45..44038f0e05 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.c\n+++ b/drivers/crypto/mlx5/mlx5_crypto.c\n@@ -402,6 +402,101 @@ mlx5_crypto_hw_global_prepare(struct mlx5_crypto_priv *priv)\n \treturn 0;\n }\n \n+\n+static int\n+mlx5_crypto_args_check_handler(const char *key, const char *val, void *opaque)\n+{\n+\tstruct mlx5_crypto_devarg_params *devarg_prms = opaque;\n+\tstruct mlx5_devx_crypto_login_attr *attr = &devarg_prms->login_attr;\n+\tunsigned long tmp;\n+\tFILE *file;\n+\tint ret;\n+\tint i;\n+\n+\tif (strcmp(key, \"class\") == 0)\n+\t\treturn 0;\n+\tif (strcmp(key, \"wcs_file\") == 0) {\n+\t\tfile = fopen(val, \"rb\");\n+\t\tif (file == NULL) {\n+\t\t\trte_errno = ENOTSUP;\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t\tfor (i = 0 ; i < MLX5_CRYPTO_CREDENTIAL_SIZE ; i++) {\n+\t\t\tret = fscanf(file, \"%02hhX\", &attr->credential[i]);\n+\t\t\tif (ret <= 0) {\n+\t\t\t\tfclose(file);\n+\t\t\t\tDRV_LOG(ERR,\n+\t\t\t\t\t\"Failed to read credential from file.\");\n+\t\t\t\trte_errno = EINVAL;\n+\t\t\t\treturn -rte_errno;\n+\t\t\t}\n+\t\t}\n+\t\tfclose(file);\n+\t\tdevarg_prms->login_devarg = true;\n+\t\treturn 0;\n+\t}\n+\terrno = 0;\n+\ttmp = strtoul(val, NULL, 0);\n+\tif (errno) {\n+\t\tDRV_LOG(WARNING, \"%s: \\\"%s\\\" is an invalid integer.\", key, val);\n+\t\treturn -errno;\n+\t}\n+\tif (strcmp(key, \"import_kek_id\") == 0)\n+\t\tattr->session_import_kek_ptr = (uint32_t)tmp;\n+\telse if (strcmp(key, \"credential_id\") == 0)\n+\t\tattr->credential_pointer = (uint32_t)tmp;\n+\telse\n+\t\tDRV_LOG(WARNING, \"Invalid key %s.\", key);\n+\treturn 0;\n+}\n+\n+static struct mlx5_devx_obj *\n+mlx5_crypto_config_login(struct rte_devargs *devargs,\n+\t\t\t struct ibv_context *ctx)\n+{\n+\t/*\n+\t * Set credential pointer and session import KEK pointer to a default\n+\t * value of 0.\n+\t */\n+\tstruct mlx5_crypto_devarg_params login = {\n+\t\t\t.login_devarg = false,\n+\t\t\t.login_attr = {\n+\t\t\t\t\t.credential_pointer = 0,\n+\t\t\t\t\t.session_import_kek_ptr = 0,\n+\t\t\t}\n+\t};\n+\tstruct rte_kvargs *kvlist;\n+\n+\tif (devargs == NULL) {\n+\t\tDRV_LOG(ERR,\n+\t\"No login devargs in order to enable crypto operations in the device.\");\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\tkvlist = rte_kvargs_parse(devargs->args, NULL);\n+\tif (kvlist == NULL) {\n+\t\tDRV_LOG(ERR, \"Failed to parse devargs.\");\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\tif (rte_kvargs_process(kvlist, NULL, mlx5_crypto_args_check_handler,\n+\t\t\t &login) != 0) {\n+\t\tDRV_LOG(ERR, \"Devargs handler function Failed.\");\n+\t\trte_kvargs_free(kvlist);\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\trte_kvargs_free(kvlist);\n+\tif (login.login_devarg == false) {\n+\t\tDRV_LOG(ERR,\n+\t\"No login credential devarg in order to enable crypto operations \"\n+\t\"in the device.\");\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\treturn mlx5_devx_cmd_create_crypto_login_obj(ctx, &login.login_attr);\n+}\n+\n /**\n * DPDK callback to register a PCI device.\n *\n@@ -423,6 +518,7 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \tstruct ibv_device *ibv;\n \tstruct rte_cryptodev *crypto_dev;\n \tstruct ibv_context *ctx;\n+\tstruct mlx5_devx_obj *login;\n \tstruct mlx5_crypto_priv *priv;\n \tstruct mlx5_hca_attr attr = { 0 };\n \tstruct rte_cryptodev_pmd_init_params init_params = {\n@@ -461,6 +557,11 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \t\trte_errno = ENOTSUP;\n \t\treturn -ENOTSUP;\n \t}\n+\tlogin = mlx5_crypto_config_login(pci_dev->device.devargs, ctx);\n+\tif (login == NULL) {\n+\t\tDRV_LOG(ERR, \"Failed to configure login.\");\n+\t\treturn -rte_errno;\n+\t}\n \tcrypto_dev = rte_cryptodev_pmd_create(ibv->name, &pci_dev->device,\n \t\t\t\t\t&init_params);\n \tif (crypto_dev == NULL) {\n@@ -477,6 +578,7 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \tcrypto_dev->driver_id = mlx5_crypto_driver_id;\n \tpriv = crypto_dev->data->dev_private;\n \tpriv->ctx = ctx;\n+\tpriv->login_obj = login;\n \tpriv->pci_dev = pci_dev;\n \tpriv->crypto_dev = crypto_dev;\n \tif (mlx5_crypto_hw_global_prepare(priv) != 0) {\n@@ -517,6 +619,7 @@ mlx5_crypto_pci_remove(struct rte_pci_device *pdev)\n \t\tmlx5_mr_release_cache(&priv->mr_scache);\n \t\tmlx5_crypto_hw_global_release(priv);\n \t\trte_cryptodev_pmd_destroy(priv->crypto_dev);\n+\t\tclaim_zero(mlx5_devx_cmd_destroy(priv->login_obj));\n \t\tclaim_zero(mlx5_glue->close_device(priv->ctx));\n \t}\n \treturn 0;\ndiff --git a/drivers/crypto/mlx5/mlx5_crypto.h b/drivers/crypto/mlx5/mlx5_crypto.h\nindex 397267d249..0aef804b92 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.h\n+++ b/drivers/crypto/mlx5/mlx5_crypto.h\n@@ -29,6 +29,7 @@ struct mlx5_crypto_priv {\n \tstruct mlx5_hlist *dek_hlist; /* Dek hash list. */\n \tstruct rte_cryptodev_config dev_config;\n \tstruct mlx5_mr_share_cache mr_scache; /* Global shared MR cache. */\n+\tstruct mlx5_devx_obj *login_obj;\n };\n \n struct mlx5_crypto_qp {\n@@ -48,6 +49,12 @@ struct mlx5_crypto_dek {\n \tbool size_is_48; /* Whether the key\\data size is 48 bytes or not. */\n };\n \n+\n+struct mlx5_crypto_devarg_params {\n+\tbool login_devarg;\n+\tstruct mlx5_devx_crypto_login_attr login_attr;\n+};\n+\n int\n mlx5_crypto_dek_destroy(struct mlx5_crypto_priv *priv,\n \t\t\tstruct mlx5_crypto_dek *dek);\n", "prefixes": [ "v2", "08/15" ] }