Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92336/?format=api
{ "id": 92336, "url": "https://patches.dpdk.org/api/patches/92336/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210428142553.1593546-3-kda@semihalf.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210428142553.1593546-3-kda@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210428142553.1593546-3-kda@semihalf.com", "date": "2021-04-28T14:25:53", "name": "[v2,2/2] test/distributor: fix burst flush on worker quit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1751aaea55cb732e71ea12ab2e72b2f753b12f66", "submitter": { "id": 2179, "url": "https://patches.dpdk.org/api/people/2179/?format=api", "name": "Stanislaw Kardach", "email": "kda@semihalf.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210428142553.1593546-3-kda@semihalf.com/mbox/", "series": [ { "id": 16722, "url": "https://patches.dpdk.org/api/series/16722/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16722", "date": "2021-04-28T14:25:51", "name": "test/distributor: perf burst mode quit fixes", "version": 2, "mbox": "https://patches.dpdk.org/series/16722/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92336/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92336/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6E64AA0C3F;\n\tWed, 28 Apr 2021 16:28:41 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 38A1A412B7;\n\tWed, 28 Apr 2021 16:28:39 +0200 (CEST)", "from mail-lj1-f175.google.com (mail-lj1-f175.google.com\n [209.85.208.175])\n by mails.dpdk.org (Postfix) with ESMTP id 8197F40147\n for <dev@dpdk.org>; Wed, 28 Apr 2021 16:28:36 +0200 (CEST)", "by mail-lj1-f175.google.com with SMTP id o5so39386970ljc.1\n for <dev@dpdk.org>; Wed, 28 Apr 2021 07:28:36 -0700 (PDT)", "from localhost.localdomain (89-73-146-138.dynamic.chello.pl.\n [89.73.146.138])\n by smtp.gmail.com with ESMTPSA id e15sm1204409lja.14.2021.04.28.07.28.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 28 Apr 2021 07:28:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=SXAAQ+CK3NA0Epv0wskpT+80qVV7+yewMy51V394ItM=;\n b=IL9UKPsoMGeXtW2eplxSL1/ZlWveV4wOjRwvo4tpMSYlSW+5zSMIUi3TH5VFrwnLgD\n GobT24wc2shRC1GL+ktSTRPoWbw5DVpRkXQyrAUb5rBtOpmFQDCjIAdBXe7GTVoIHHq7\n xU9WLI8cZf5CgojsclCLmZRh548QCXyzTXmjKLG+CkFZ1KAJhqSWNcaLG1WMQgLnvW4P\n LqRDE4AiYSJhWuT2U1AUAMxf0oGgobd3HAyAV7Af4TE4/wcwyZmSuOQWH/LdSrD2j/ra\n Dga9NeN5o8va7rGGavwYpcyktbLMj4DinW7udtuUilwGBufWy5q9riyVwB3skFZ7qQkQ\n eGcw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=SXAAQ+CK3NA0Epv0wskpT+80qVV7+yewMy51V394ItM=;\n b=fLZCu7sXb01pk1v+DCdoIgx6I7MhT6ES3uHiiV6UqxOrhd3Ga4GKrw7c8lS0QcOvH1\n 9JpCm5mCu2TIlVT/oAfTw2M5gsY0nuIkOAwY4KVLBgPdrLXUIqvnahSuLbWyfF8kVAKL\n cZ8oHBqaZ2AgzVCzxODSeh2I42/a8COUszjiu3bSe/K5SRAJNrL8ViJKenrnkG3fGL61\n ek/yMFZu8EiQkaru+P3FCRCxm2z1d8+bZImayKXckXk+XJIJ6OCK3jqi5SuwNOFolz/U\n dmnirfFwXO0BQtldvQKF9SfwDQ7+L8CMQCcz3+tVGRr0NMAHwe0uEB0+xHZqX19oHlAF\n Tdtw==", "X-Gm-Message-State": "AOAM532OyiheU2mXZZUEZUeVTS+eEp6nzDlq85SD60u8GafLDskbBlr2\n qlviZygM3+tl/pKTBP9IhHmyyLqdHrjkUy1x", "X-Google-Smtp-Source": "\n ABdhPJwlGC/X1i3gLp43CGkryXBVdForcIMUCqtkrOed/nhSvecshGHC7VY8zSZ3c3ml/N4gfq6lig==", "X-Received": "by 2002:a2e:9659:: with SMTP id\n z25mr20890107ljh.188.1619620116146;\n Wed, 28 Apr 2021 07:28:36 -0700 (PDT)", "From": "Stanislaw Kardach <kda@semihalf.com>", "To": "dev@dpdk.org,\n\tdavid.hunt@intel.com", "Cc": "upstream@semihalf.com, l.wojciechow@partner.samsung.com,\n Stanislaw Kardach <kda@semihalf.com>,\n David Marchand <david.marchand@redhat.com>", "Date": "Wed, 28 Apr 2021 16:25:53 +0200", "Message-Id": "<20210428142553.1593546-3-kda@semihalf.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210428142553.1593546-1-kda@semihalf.com>", "References": "<20210426163310.1043438-1-kda@semihalf.com>\n <20210428142553.1593546-1-kda@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 2/2] test/distributor: fix burst flush on\n worker quit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "While working on RISC-V port I have encountered a situation where worker\nthreads get stuck in the rte_distributor_return_pkt() function in the\nburst test.\nInvestigation showed some of the threads enter this function with\nflag RTE_DISTRIB_GET_BUF set in the d->retptr64[0]. At the same time the\nmain thread has already passed rte_distributor_process() so nobody will\nclear this flag and hence workers can't return.\n\nWhat I've noticed is that adding a flush just after the last _process(),\nsimilarly to how quit_workers() function is written in the\ntest_distributor.c fixes the issue.\nLukasz Wojciechowski reproduced the same issue on x86 using a VM with 32\nemulated CPU cores to force some lcores not to be woken up.\n\nFixes: 7c3287a10535 (\"test/distributor: add performance test for burst mode\")\nCc: David Marchand <david.marchand@redhat.com>\n\nSigned-off-by: Stanislaw Kardach <kda@semihalf.com>\nAcked-by: David Hunt <david.hunt@intel.com>\nTested-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\nReviewed-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n app/test/test_distributor_perf.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c\nindex 371a14ba4..fdbeae6d2 100644\n--- a/app/test/test_distributor_perf.c\n+++ b/app/test/test_distributor_perf.c\n@@ -196,6 +196,7 @@ quit_workers(struct rte_distributor *d, struct rte_mempool *p)\n \trte_mempool_put_bulk(p, (void *)bufs, num_workers);\n \n \trte_distributor_process(d, NULL, 0);\n+\trte_distributor_flush(d);\n \trte_eal_mp_wait_lcore();\n \tquit = 0;\n \tworker_idx = 0;\n", "prefixes": [ "v2", "2/2" ] }