Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9231/?format=api
{ "id": 9231, "url": "https://patches.dpdk.org/api/patches/9231/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1449028676-19232-2-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449028676-19232-2-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449028676-19232-2-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-02T03:57:47", "name": "[dpdk-dev,01/10] mk: remove multi-target install", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "04ca463a93f2dec2a1cff1159e6081615fd0a73e", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1449028676-19232-2-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/9231/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/9231/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D4D8C8DAE;\n\tWed, 2 Dec 2015 04:59:19 +0100 (CET)", "from mail-wm0-f48.google.com (mail-wm0-f48.google.com\n\t[74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 7E8988D85\n\tfor <dev@dpdk.org>; Wed, 2 Dec 2015 04:59:18 +0100 (CET)", "by wmec201 with SMTP id c201so234690521wme.0\n\tfor <dev@dpdk.org>; Tue, 01 Dec 2015 19:59:18 -0800 (PST)", "from XPS13.ibrowse.com ([93.158.52.3])\n\tby smtp.gmail.com with ESMTPSA id\n\th5sm783942wjz.21.2015.12.01.19.59.17\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 01 Dec 2015 19:59:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=5NmJZU7RhqYvBhMssmSFtN/TqqFt+CMopeEg65iz7RM=;\n\tb=v33h5fMlX1nHVnHkElDIzutSZlIOQ4SAU4p846Dtws8lRQainTc9UNke/uoPiN+pqn\n\tdVNY6kSZ8QjaGWEpzUp1LlC2TuHm63KTXp6vhW2kJB1gUX3jHFhZfnnB9dybOb95I29l\n\tVLx4CIKHIhIo9imQnxaKo9mOfIeHWn3cOjvvXqwYN3lzg9pEp8D4bTNLlWxL266ah4Ig\n\tAjJieyIuoY2fmBL+dFjWVnxtkibakdr1OFMgmN6XRs4QeWRjHHSzbVe/21T4pqdxAS1t\n\tdO8xJuIZPakOVvn14iXKVZXBrBQwslAySCgsrT9Qq7MA615U4bSPKJWUKsqFBztHyi+k\n\ti01g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=5NmJZU7RhqYvBhMssmSFtN/TqqFt+CMopeEg65iz7RM=;\n\tb=haeOIZ1gi7V6yXw7Sf5TgzJGyC5ed4ntiuBWXTOpAdEyhksw4AqYX94IWaMsPr4qrK\n\twErAwQ79O1cgm0I/dZ6x1er3sklARnTjWVWnQ89L6nhc9Wc/1FxrTaYFmwZpCEYmSf7z\n\tP5eNZUes/h0mGA6onL21LkiEB6oIkxO9YIDihdjvkE9i5pidsVyE/K7y/VVPXw+4FEXg\n\tcw0q3sf0g5eynN5USiaq5VfQvgxR9EF2LWcZ4A8kjhLE1zqxIRkplRh1H/JOJl3ZWCy+\n\tKFacJ/qDj+B+uFJL3pOYtcCPLf2d2+wVJ6NHOmQjweVMyrH8mMFWwN4upY43a9kAE0wg\n\ttsnQ==", "X-Gm-Message-State": "ALoCoQmwLxx2M6YdLfoAcY8QhT+4axtNfmLBKgh9A+W4xxjk+RMr5Mtr3SxhfpxGnudh9Wn64Wub", "X-Received": "by 10.194.59.108 with SMTP id y12mr1476441wjq.33.1449028758374; \n\tTue, 01 Dec 2015 19:59:18 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 2 Dec 2015 04:57:47 +0100", "Message-Id": "<1449028676-19232-2-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "In-Reply-To": "<1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 01/10] mk: remove multi-target install", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The multi-target install create some subdirectories with the target name\nwhich is not standard for a \"make install\" procedure.\n\nThe uninstall procedure cannot be applied properly (without removing\nall files in a directory). It would need to pre-compute paths.\nAs it is a packaging issue, it is removed from the build system capabilities.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n doc/build-sdk-quick.txt | 5 ++--\n mk/rte.sdkinstall.mk | 61 +++++++++++++------------------------------------\n mk/rte.sdkroot.mk | 4 ++--\n 3 files changed, 20 insertions(+), 50 deletions(-)", "diff": "diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt\nindex bf18b48..b5f752e 100644\n--- a/doc/build-sdk-quick.txt\n+++ b/doc/build-sdk-quick.txt\n@@ -5,8 +5,7 @@ Build commands\n \tall same as build (default rule)\n \tbuild build in a configured directory\n \tclean remove files but keep configuration\n-\tinstall build many targets (wildcard allowed) and install in DESTDIR\n-\tuninstall remove all installed targets\n+\tinstall configure, build and install a target in DESTDIR\n \texamples build examples for given targets (T=)\n \texamples_clean clean examples for given targets (T=)\n Build variables\n@@ -20,6 +19,6 @@ Build variables\n \tD debug dependencies\n \tO build directory (default: build/ - install default: ./)\n \tDESTDIR second-stage install directory\n-\tT target template (install default: *) - used with config or install\n+\tT target template - used with config or install\n \t\t\tformat: <arch-machine-execenv-toolchain>\n \t\t\ttemplates in config/defconfig_*\ndiff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk\nindex 86c98a5..e8355eb 100644\n--- a/mk/rte.sdkinstall.mk\n+++ b/mk/rte.sdkinstall.mk\n@@ -30,58 +30,29 @@\n # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n \n # Build directory is given with O=\n-ifdef O\n-BUILD_DIR=$(O)\n-else\n-BUILD_DIR=.\n-endif\n+O ?= .\n \n-# Targets to install can be specified in command line. It can be a\n-# target name or a name containing jokers \"*\". Example:\n-# x86_64-native-*-gcc\n-ifndef T\n-T=*\n-endif\n-\n-#\n-# install: build sdk for all supported targets\n-#\n-INSTALL_CONFIGS := $(patsubst $(RTE_SRCDIR)/config/defconfig_%,%,\\\n-\t$(wildcard $(RTE_SRCDIR)/config/defconfig_$(T)))\n-INSTALL_TARGETS := $(addsuffix _install,\\\n-\t$(filter-out %~,$(INSTALL_CONFIGS)))\n+# Configuration, compilation and installation can be done at once\n+# with make install T=<config>\n+# The build directory is T and may be prepended with O\n+BUILD_DIR := $O/$T\n \n .PHONY: install\n-install: $(INSTALL_TARGETS)\n-\n-%_install:\n-\t@echo ================== Installing $*\n-\t$(Q)if [ ! -f $(BUILD_DIR)/$*/.config ]; then \\\n-\t\t$(MAKE) config T=$* O=$(BUILD_DIR)/$*; \\\n-\telif cmp -s $(BUILD_DIR)/$*/.config.orig $(BUILD_DIR)/$*/.config; then \\\n-\t\t$(MAKE) config T=$* O=$(BUILD_DIR)/$*; \\\n+install:\n+\t@echo ================== Installing $T\n+\t$(Q)if [ ! -f $(BUILD_DIR)/.config ]; then \\\n+\t\t$(MAKE) config T=$T O=$(BUILD_DIR); \\\n+\telif cmp -s $(BUILD_DIR)/.config.orig $(BUILD_DIR)/.config; then \\\n+\t\t$(MAKE) config T=$T O=$(BUILD_DIR); \\\n \telse \\\n-\t\tif [ -f $(BUILD_DIR)/$*/.config.orig ] ; then \\\n-\t\t\ttmp_build=$(BUILD_DIR)/$*/.config.tmp; \\\n-\t\t\t$(MAKE) config T=$* O=$$tmp_build; \\\n-\t\t\tif ! cmp -s $(BUILD_DIR)/$*/.config.orig $$tmp_build/.config ; then \\\n+\t\tif [ -f $(BUILD_DIR)/.config.orig ] ; then \\\n+\t\t\ttmp_build=$(BUILD_DIR)/.config.tmp; \\\n+\t\t\t$(MAKE) config T=$T O=$$tmp_build; \\\n+\t\t\tif ! cmp -s $(BUILD_DIR)/.config.orig $$tmp_build/.config ; then \\\n \t\t\t\techo \"Conflict: local config and template config have both changed\"; \\\n \t\t\t\texit 1; \\\n \t\t\tfi; \\\n \t\tfi; \\\n \t\techo \"Using local configuration\"; \\\n \tfi\n-\t$(Q)$(MAKE) all O=$(BUILD_DIR)/$*\n-\n-#\n-# uninstall: remove all built sdk\n-#\n-UNINSTALL_TARGETS := $(addsuffix _uninstall,\\\n-\t$(filter-out %~,$(INSTALL_CONFIGS)))\n-\n-.PHONY: uninstall\n-uninstall: $(UNINSTALL_TARGETS)\n-\n-%_uninstall:\n-\t@echo ================== Uninstalling $*\n-\t$(Q)rm -rf $(BUILD_DIR)/$*\n+\t$(Q)$(MAKE) all O=$(BUILD_DIR)\ndiff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk\nindex e8423b0..18180fa 100644\n--- a/mk/rte.sdkroot.mk\n+++ b/mk/rte.sdkroot.mk\n@@ -97,8 +97,8 @@ test fast_test ring_test mempool_test perf_test coverage:\n testall:\n \t$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktestall.mk $@\n \n-.PHONY: install uninstall\n-install uninstall:\n+.PHONY: install\n+install:\n \t$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkinstall.mk $@\n \n .PHONY: doc help\n", "prefixes": [ "dpdk-dev", "01/10" ] }