Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92276/?format=api
{ "id": 92276, "url": "https://patches.dpdk.org/api/patches/92276/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210427153811.11554-12-bingz@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210427153811.11554-12-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210427153811.11554-12-bingz@nvidia.com", "date": "2021-04-27T15:38:05", "name": "[11/17] net/mlx5: add translation for CT action", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6ac14f06b593c72b26daef81edec504e0c052ee7", "submitter": { "id": 1976, "url": "https://patches.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210427153811.11554-12-bingz@nvidia.com/mbox/", "series": [ { "id": 16705, "url": "https://patches.dpdk.org/api/series/16705/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16705", "date": "2021-04-27T15:37:54", "name": "conntrack support in mlx5 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/16705/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92276/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92276/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 30579A0A02;\n\tTue, 27 Apr 2021 17:39:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 65BD541294;\n\tTue, 27 Apr 2021 17:39:11 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58])\n by mails.dpdk.org (Postfix) with ESMTP id 94E2D41260\n for <dev@dpdk.org>; Tue, 27 Apr 2021 17:39:08 +0200 (CEST)", "from MWHPR01CA0046.prod.exchangelabs.com (2603:10b6:300:101::32) by\n BYAPR12MB3335.namprd12.prod.outlook.com (2603:10b6:a03:dd::11) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4065.23; Tue, 27 Apr 2021 15:39:07 +0000", "from CO1NAM11FT013.eop-nam11.prod.protection.outlook.com\n (2603:10b6:300:101:cafe::2) by MWHPR01CA0046.outlook.office365.com\n (2603:10b6:300:101::32) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25 via Frontend\n Transport; Tue, 27 Apr 2021 15:39:06 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT013.mail.protection.outlook.com (10.13.174.227) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4065.21 via Frontend Transport; Tue, 27 Apr 2021 15:39:06 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Apr\n 2021 15:39:04 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=VPdtw/7WkYSMFjAOdDceb4lZ9pl/TzNiPi92mYa7Kg20L8Qeonp9tERTtGh/0fCL0L+rxp01zstBcy2NosQBICmjRjsrU6B4SOwT1JI0Xxuo9Z9N2saXNPBwLU7FC1QEeLgUwEuoIqEY7r0EXYKwfmmBr69qMzkbM8JBThhmNNDoRWAkOPHKVDkyIeC8CueW4H6zfQyshQ754DGW1itZDKLGIavA0MkS0edfczobX85tcIG29nMJ4CaKyBn+Qvo2EcIidhx0VG1FkH4vf+omn/18brvXMHk+V2xAwDniOTLqeiQCofLMlllpvhNt775JVqde8XAYK17FGeJUriv7tw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=/KDmYONwBusmj4jN995KRSfUm9QqRA8xs5oF/Tln/0Q=;\n b=c/G8QPnKuJcQ2uZJvY1ZQNMIoVRRxAffFX7n15Isot7a3IHb9wZU3ItI/NGwwWXySH6pddo15igxnn1OBruIl80Umi1OLu8ezOY0/BgvLYqz1ddS12iuPzJbAufxL0CyY6qTF8gbkZTRcMzDgEAYUATAjtSoUbqr7uyHmwAY6Y0DsbMA9u/iODv3TPuPiuLT6gA3rkspbdxOWDrQS234qZbZcFtQYNfbXbTt3D4iYbAkAgNsl90mJG7xeIMvKhO3x/V4MN4vBZK+vMA0wesDUpVwOWsxLIRlrX6m0oIsDe13NL21lXgffEmUkkPf8mjOMLT23uvkgFvms1Tn90wV7w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=/KDmYONwBusmj4jN995KRSfUm9QqRA8xs5oF/Tln/0Q=;\n b=EClJZqIbzNuXL0UThKZO3nXEUjDT9ke9K/RD1S4/TGbEzcyoUkqnDlkjf1Z09odeF+9/a/2dbh2+oKmcl/gDb/jUfvSvKGqn4hsCe9Qt+eDZKTL+9OdOyTkckeQmXZh5Zl2CrYS+v682lVmEsCkZlklDBlhasDwDegts+sw3KtpKDG+BbtJD6KjEQWfZMP4lPiulRM98sTpno3SOLI1xvMsEcrzpe+6QOATeysLQXmQCbZRa5s0k1HOtJ6DWbnkVmf17jemMYv6vp25R3azKez5WZUlivLftSZqMSUfbdP1T0L4awgyAZNGMsTy4FGmBZKXQJGp1uRTzcZ9LOX1xpQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<dev@dpdk.org>, <orika@nvidia.com>, <rasland@nvidia.com>", "Date": "Tue, 27 Apr 2021 18:38:05 +0300", "Message-ID": "<20210427153811.11554-12-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210427153811.11554-1-bingz@nvidia.com>", "References": "<20210427153811.11554-1-bingz@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "7fe431f3-9cdc-489e-d73f-08d9099297f9", "X-MS-TrafficTypeDiagnostic": "BYAPR12MB3335:", "X-Microsoft-Antispam-PRVS": "\n <BYAPR12MB33358BDC4FCA76732FE85C18D0419@BYAPR12MB3335.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:6790;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n X6UieBFCqCbp46yOgsj7lzDVaysPR24ZlpJfORFMYT6C1qJhX9tILX/lDcOqQpDBAIeH9fBFgp6gu4+gebMmJyaBV6Gf0vydXAgfdXX5fV3exzgp8x95+5AXj0SIDHOjTM47SaKIJnIXVDi/+chbnNoalyCQisIDAVMOAGRjDAC3w2l1JBmXoeluOTOx7i21vmI/FEm+5Lf64Fq3dn8x4SyH59YL0qn+QUAvW+E0UBY9i1Zva4SQhbZ2UNx7vyneLZ3adusmOyVFwR8QE2HzLaE0gV3HsWL245pRFEGO2lTUPOb7Vbax+jEtXvSNcHHKG3cuStThh9ZnM7ZsAbtQ5Sq35VJDnIOZp2vK8GqKgaMZOMtdLuicyeSUCks8cui3Q3rmDxqhvqimdDHEsmrWo5akjLsEID8E5OHhXIZUb+nuB2szsvRrWXseqHp/AdcMJ4l9eH1bCIZbmvcAghWnARuUJpV83d90SmKmv20RYIIkZ/5o/+1tEtQPkjUBNP3AwBwBaVZ8P2Z2yL2Q789tphiYOIRZ5ZgSHQFSOXKcj5FKjV5m593MLREdcEn25YKwmUl1ci7RHbYwW2ZEKJyWfk2Rx0MSiKxVTwlcA8XF6XHjlQKNdcQuQBrcKbm9WRPYroCD18LuDSQo20zNtXGGbW/dodxbQ7Wb5t7vSAoklz2HNR2j/2JaJQGHTSTFQ8Lc", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(376002)(136003)(346002)(396003)(39860400002)(46966006)(36840700001)(336012)(8676002)(54906003)(82310400003)(36756003)(47076005)(6286002)(36906005)(7636003)(316002)(5660300002)(110136005)(478600001)(70206006)(2616005)(83380400001)(6636002)(82740400003)(70586007)(8936002)(426003)(2906002)(107886003)(356005)(36860700001)(16526019)(55016002)(186003)(4326008)(26005)(7696005)(86362001)(1076003)(309714004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "27 Apr 2021 15:39:06.7755 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7fe431f3-9cdc-489e-d73f-08d9099297f9", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT013.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR12MB3335", "Subject": "[dpdk-dev] [PATCH 11/17] net/mlx5: add translation for CT action", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When creating a flow with this action context for CT, it needs to be\ntranslated in 2 levels.\nFirst, retrieve from action context to RTE_FLOW action.\nSecond, translate it to the correct DR action with traffic direction.\n\nBefore using the DR action in a flow, the CT context should be\navailable to use in the hardware.\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\n---\n drivers/net/mlx5/mlx5.h | 3 ++-\n drivers/net/mlx5/mlx5_flow.c | 9 +++++++++\n drivers/net/mlx5/mlx5_flow.h | 1 +\n drivers/net/mlx5/mlx5_flow_aso.c | 40 ++++++++++++++++++++++++++++++++++++++++\n drivers/net/mlx5/mlx5_flow_dv.c | 18 ++++++++++++++++++\n 5 files changed, 70 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex f999828..3b67706 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -1716,6 +1716,7 @@ int mlx5_aso_ct_wait_ready(struct mlx5_dev_ctx_shared *sh,\n int mlx5_aso_ct_query_by_wqe(struct mlx5_dev_ctx_shared *sh,\n \t\t\t struct mlx5_aso_ct_action *ct,\n \t\t\t struct rte_flow_action_conntrack *profile);\n-\n+int mlx5_aso_ct_available(struct mlx5_dev_ctx_shared *sh,\n+\t\t\t struct mlx5_aso_ct_action *ct);\n \n #endif /* RTE_PMD_MLX5_H_ */\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 1c28b63..7b9f055 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -3552,6 +3552,15 @@ flow_action_handles_translate(struct rte_eth_dev *dev,\n \t\t\t\tbreak;\n \t\t\t}\n \t\t\t/* Fall-through */\n+\t\tcase MLX5_INDIRECT_ACTION_TYPE_CT:\n+\t\t\tif (priv->sh->ct_aso_en) {\n+\t\t\t\ttranslated[handle->index].type =\n+\t\t\t\t\tRTE_FLOW_ACTION_TYPE_CONNTRACK;\n+\t\t\t\ttranslated[handle->index].conf =\n+\t\t\t\t\t\t\t (void *)(uintptr_t)idx;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t\t/* Fall-through */\n \t\tdefault:\n \t\t\tmlx5_free(translated);\n \t\t\treturn rte_flow_error_set\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 988b171..ddfc517 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -226,6 +226,7 @@ enum mlx5_feature_name {\n #define MLX5_FLOW_ACTION_TUNNEL_MATCH (1ull << 38)\n #define MLX5_FLOW_ACTION_MODIFY_FIELD (1ull << 39)\n #define MLX5_FLOW_ACTION_METER_WITH_TERMINATED_POLICY (1ull << 40)\n+#define MLX5_FLOW_ACTION_CT (1ull << 41)\n \n #define MLX5_FLOW_FATE_ACTIONS \\\n \t(MLX5_FLOW_ACTION_DROP | MLX5_FLOW_ACTION_QUEUE | \\\ndiff --git a/drivers/net/mlx5/mlx5_flow_aso.c b/drivers/net/mlx5/mlx5_flow_aso.c\nindex 12e8dc7..21de855 100644\n--- a/drivers/net/mlx5/mlx5_flow_aso.c\n+++ b/drivers/net/mlx5/mlx5_flow_aso.c\n@@ -1394,3 +1394,43 @@ mlx5_aso_ct_query_by_wqe(struct mlx5_dev_ctx_shared *sh,\n \t\tmlx5_aso_ct_obj_analyze(profile, out_data);\n \treturn ret;\n }\n+\n+/*\n+ * Make sure the conntrack context is synchronized with hardware before\n+ * creating a flow rule that uses it.\n+ *\n+ * @param[in] sh\n+ * Pointer to shared device context.\n+ * @param[in] ct\n+ * Pointer to connection tracking offload object.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_aso_ct_available(struct mlx5_dev_ctx_shared *sh,\n+\t\t struct mlx5_aso_ct_action *ct)\n+{\n+\tstruct mlx5_aso_ct_pools_mng *mng = sh->ct_mng;\n+\tuint32_t poll_cqe_times = MLX5_CT_POLL_WQE_CQE_TIMES;\n+\tuint8_t state = __atomic_load_n(&ct->state, __ATOMIC_RELAXED);\n+\n+\tif (state == ASO_CONNTRACK_FREE) {\n+\t\trte_errno = ENXIO;\n+\t\treturn -rte_errno;\n+\t} else if (state == ASO_CONNTRACK_READY ||\n+\t\t state == ASO_CONNTRACK_QUERY) {\n+\t\treturn 0;\n+\t}\n+\tdo {\n+\t\tmlx5_aso_ct_completion_handle(mng);\n+\t\tstate = __atomic_load_n(&ct->state, __ATOMIC_RELAXED);\n+\t\tif (state == ASO_CONNTRACK_READY ||\n+\t\t state == ASO_CONNTRACK_QUERY)\n+\t\t\treturn 0;\n+\t\t/* Waiting for CQE ready, consider should block or sleep. */\n+\t\trte_delay_us_sleep(MLX5_ASO_WQE_CQE_RESPONSE_DELAY);\n+\t} while (--poll_cqe_times);\n+\trte_errno = EBUSY;\n+\treturn -rte_errno;\n+}\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex f4fa3a0..3ebeb58 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -11373,6 +11373,7 @@ flow_dv_translate_create_conntrack(struct rte_eth_dev *dev,\n \t\treturn rte_flow_error_set(error, EBUSY,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n \t\t\t\t\t \"Failed to update CT\");\n+\tct->is_original = !!pro->is_original_dir;\n \treturn idx;\n }\n \n@@ -11529,6 +11530,8 @@ flow_dv_translate(struct rte_eth_dev *dev,\n \t\tconst struct rte_flow_action *found_action = NULL;\n \t\tuint32_t jump_group = 0;\n \t\tstruct mlx5_flow_counter *cnt;\n+\t\tuint32_t ct_idx;\n+\t\tstruct mlx5_aso_ct_action *ct;\n \n \t\tif (!mlx5_flow_os_action_supported(action_type))\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n@@ -12002,6 +12005,21 @@ flow_dv_translate(struct rte_eth_dev *dev,\n \t\t\t\treturn -rte_errno;\n \t\t\taction_flags |= MLX5_FLOW_ACTION_MODIFY_FIELD;\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ACTION_TYPE_CONNTRACK:\n+\t\t\tct_idx = (uint32_t)(uintptr_t)action->conf;\n+\t\t\tct = flow_aso_ct_get_by_idx(dev, ct_idx);\n+\t\t\tif (mlx5_aso_ct_available(priv->sh, ct))\n+\t\t\t\treturn -rte_errno;\n+\t\t\tif (ct->is_original)\n+\t\t\t\tdev_flow->dv.actions[actions_n] =\n+\t\t\t\t\t\t\tct->dr_action_orig;\n+\t\t\telse\n+\t\t\t\tdev_flow->dv.actions[actions_n] =\n+\t\t\t\t\t\t\tct->dr_action_rply;\n+\t\t\t__atomic_fetch_add(&ct->refcnt, 1, __ATOMIC_RELAXED);\n+\t\t\tactions_n++;\n+\t\t\taction_flags |= MLX5_FLOW_ACTION_CT;\n+\t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_END:\n \t\t\tactions_end = true;\n \t\t\tif (mhdr_res->actions_num) {\n", "prefixes": [ "11/17" ] }