Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92273/?format=api
{ "id": 92273, "url": "https://patches.dpdk.org/api/patches/92273/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210427153811.11554-9-bingz@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210427153811.11554-9-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210427153811.11554-9-bingz@nvidia.com", "date": "2021-04-27T15:38:02", "name": "[08/17] net/mlx5: close CT management structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d3759cf037b48cd09ac7562aea57bfa2ecdd01ea", "submitter": { "id": 1976, "url": "https://patches.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210427153811.11554-9-bingz@nvidia.com/mbox/", "series": [ { "id": 16705, "url": "https://patches.dpdk.org/api/series/16705/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16705", "date": "2021-04-27T15:37:54", "name": "conntrack support in mlx5 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/16705/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92273/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92273/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6E6BCA0A02;\n\tTue, 27 Apr 2021 17:39:36 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 42A744128A;\n\tTue, 27 Apr 2021 17:39:02 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2076.outbound.protection.outlook.com [40.107.92.76])\n by mails.dpdk.org (Postfix) with ESMTP id 5365641284\n for <dev@dpdk.org>; Tue, 27 Apr 2021 17:39:00 +0200 (CEST)", "from MW4PR03CA0103.namprd03.prod.outlook.com (2603:10b6:303:b7::18)\n by BYAPR12MB3141.namprd12.prod.outlook.com (2603:10b6:a03:da::33)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Tue, 27 Apr\n 2021 15:38:58 +0000", "from CO1NAM11FT028.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:b7:cafe::b2) by MW4PR03CA0103.outlook.office365.com\n (2603:10b6:303:b7::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.22 via Frontend\n Transport; Tue, 27 Apr 2021 15:38:58 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT028.mail.protection.outlook.com (10.13.175.214) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4065.21 via Frontend Transport; Tue, 27 Apr 2021 15:38:58 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Apr\n 2021 15:38:56 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=GQRX6G4INvvANLDFMngValEqjsHZ12wDDM/ru+Pxi6taproh3+3KM/QgzC71M5nLPJyguIRpYFSwcaChA5LjRp1K07rIowMnJE7BO5dH+4NPh+WjNFIAAr6KcbVmFcEdPk413XT+yfLIv2cN0pG1hSoj4F36sbmMJ6myoETgpG/S/T++66h84KOwVV/4OsDeNzj6uqCuGaYVgM7Ecdh50sCBlqiSEXjQ2bgADDkwpiYAjrSrurqWujglQ8vbx8QKMAcz/Ce8jFm7FXZKOJQDhPWZqdUtB9FE3mFjNU2RwBuLK7VFXf99pVUZu1kQxvkTP5jRxFfcn9U0vjA/tOrKYw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=07shCMasPR0Iw+w0gFbx9DUXFGNYmVyHZPTmz4CsTpw=;\n b=O5VI0vC64xjiXrIZTBHnLqFjY3+KdtIpgKCdJYL0KbF9ZVJ5u6bhywMLxu1eARuZ5oUQWlDYbpXWP7vrJhFDyH0DKMLyH+X19HQCx1Uok8Nv0zFW2Q/HbmZRL//qrGLqpQmoyvpG7axzllDEMQzi79Nf5bsjhdGp1fBjI+4IItfA8vFR5mCrD/taG1wdbui3pKXGUi0Ostszl0GcH1Xla7Sw7Hj5diH4N94OQ+i01TiKxz4I2qXZCVeQmW7vHrumHfWWjixUS3z8x7Vy5mOV2PLyu4YmOpKiOKbeQlAFn0OjfDbVt1OPRuWYqT0IVQ/pw6OcnZxkK9D4QPCKMCkknQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=07shCMasPR0Iw+w0gFbx9DUXFGNYmVyHZPTmz4CsTpw=;\n b=epjiARHkv45YL4EUmx3KgWoaLFFIPdriq3QBzfaaqIYKMeUCDzmF3WhqGyPRywmaHcv1xanuqu6bfaO6pYiHI3dZDZUXtyxKtmqQJ5G4aZZKq0apPQPO59R6zZykCwWCpwh5oW1f7m9yCfBDADGe8U2atWnCbxWZpPeOuJjopnBFJCcLw2jm3xD/rC82Hji4/HmB8XHfkojR5DpWjw9NE6jQ1DSJFYXbqV94mgsiKRBRh/4STeImyMWMw5DbjN+SPseKp9Wwv1J/OoliSHkR98fNM1frfgrhStq64i72pNbO81tzWQgFF4f2f9bd3j5Vyv7AnNpG8a7ezv2cBI66fQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<dev@dpdk.org>, <orika@nvidia.com>, <rasland@nvidia.com>", "Date": "Tue, 27 Apr 2021 18:38:02 +0300", "Message-ID": "<20210427153811.11554-9-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210427153811.11554-1-bingz@nvidia.com>", "References": "<20210427153811.11554-1-bingz@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "5e59c36d-38ec-48b0-b44a-08d909929307", "X-MS-TrafficTypeDiagnostic": "BYAPR12MB3141:", "X-Microsoft-Antispam-PRVS": "\n <BYAPR12MB3141B8E38618B38A233A0B73D0419@BYAPR12MB3141.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:1169;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n Dg5vLuv/5hg9SkTUdqtJZntjrCsv6g4ktjNg0rycYRpIh4C63gJHb/lUqSSA2Thch11t9jhTYadvbtCJHbBA31PaNH0YqXwqFn2d32ZzwtUU6+v0Mw+5lyGsrl1LIPIpj3qC5HL+rLmGosfFzVkn44Xcoor2+fYy/TN1oY1CNImRlHKmQrADEQCvUXPHOKtKMu0/6uFb3jz0bOlfgIcQAIJkD+OuIbA/L9cex7gHqfmZJkPX6sKjjW7Abb3ENeJeLEnNQ6eUYFP2edBniIBpIEyrvQsCThEgEqrOYkU4xi0lpkPKtnc29CPNRYd7/t/5paQHDAo8xKuVpb2EsTkiKV2F9F/X50hYF2BaI+hSIl2tz2ZHJuMRKjeX41u4nhWl+oxCA+BwwbMM/qiG65Mxw/U+uNVnf2qyenn45ZZjmS79IGHrUPBatv3lDRh9a3Mj2y364QiIs4RFBMQR2hDFIOgVMaqvEiwyQXDKXYqvdEqxqobUWv602+LsTEtiWuCIy/eYh086cA2eKhStrcvaGqXQ0zizNGYhLXjmPn/q114+8uCiBC0PLO1xUEIZxX02f5xCrzgiYYybHQLLOcgfkxDOQY/CEBsLIlTM+o3yWpXWiw0VLgV82gG7pwLexo8S3Yk5hfw+OCaSreJsigLbuhi2efc76PNWmSxwGeFNH8c=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(346002)(39860400002)(396003)(376002)(136003)(36840700001)(46966006)(70586007)(70206006)(47076005)(82310400003)(83380400001)(55016002)(82740400003)(5660300002)(336012)(316002)(36906005)(426003)(6666004)(186003)(16526019)(2616005)(36756003)(110136005)(26005)(7696005)(7636003)(54906003)(8936002)(86362001)(8676002)(6636002)(2906002)(478600001)(1076003)(356005)(4326008)(6286002)(36860700001)(107886003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "27 Apr 2021 15:38:58.5127 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 5e59c36d-38ec-48b0-b44a-08d909929307", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT028.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR12MB3141", "Subject": "[dpdk-dev] [PATCH 08/17] net/mlx5: close CT management structure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When freeing the IB shared context during stopping a device, the\nASO connection tracking management structure should also be cleaned\nup.\n\nAll the DR actions created should be destroyed. The structures need\nto be freed and ASO CT QP should be released. In the meanwhile, the\nallocated and registered memory region for query should also be\nderegistered and then freed.\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\n---\n drivers/net/mlx5/mlx5.c | 56 ++++++++++++++++++++++++++++++++++++++++\n drivers/net/mlx5/mlx5_flow_aso.c | 4 +++\n 2 files changed, 60 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex a884234..5717e72 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -706,6 +706,60 @@ mlx5_flow_aso_ct_mng_init(struct mlx5_dev_ctx_shared *sh)\n \treturn 0;\n }\n \n+/*\n+ * Close and release all the resources of the\n+ * ASO connection tracking management structure.\n+ *\n+ * @param[in] sh\n+ * Pointer to mlx5_dev_ctx_shared object to free.\n+ */\n+static void\n+mlx5_flow_aso_ct_mng_close(struct mlx5_dev_ctx_shared *sh)\n+{\n+\tstruct mlx5_aso_ct_pools_mng *mng = sh->ct_mng;\n+\tstruct mlx5_aso_ct_pool *ct_pool;\n+\tstruct mlx5_aso_ct_action *ct;\n+\tuint32_t idx;\n+\tuint32_t val;\n+\tuint32_t cnt;\n+\tint i;\n+\n+\tmlx5_aso_queue_uninit(sh, ASO_OPC_MOD_CONNECTION_TRACKING);\n+\tidx = mng->next;\n+\twhile (idx--) {\n+\t\tcnt = 0;\n+\t\tct_pool = mng->pools[idx];\n+\t\tfor (i = 0; i < MLX5_ASO_CT_ACTIONS_PER_POOL; i++) {\n+\t\t\tct = &ct_pool->actions[i];\n+\t\t\tval = __atomic_sub_fetch(&ct->refcnt, 1,\n+\t\t\t\t\t\t __ATOMIC_RELAXED);\n+\t\t\tMLX5_ASSERT(val <= 1);\n+\t\t\tif (val > 1)\n+\t\t\t\tcnt++;\n+#ifdef HAVE_MLX5_DR_ACTION_ASO_CT\n+\t\t\tif (ct->dr_action_orig)\n+\t\t\t\tclaim_zero(mlx5_glue->destroy_flow_action\n+\t\t\t\t\t\t\t(ct->dr_action_orig));\n+\t\t\tif (ct->dr_action_rply)\n+\t\t\t\tclaim_zero(mlx5_glue->destroy_flow_action\n+\t\t\t\t\t\t\t(ct->dr_action_rply));\n+#endif\n+\t\t}\n+\t\tclaim_zero(mlx5_devx_cmd_destroy(ct_pool->devx_obj));\n+\t\tif (cnt) {\n+\t\t\tDRV_LOG(WARNING, \"%u ASO CT objects are being used in the pool %u\",\n+\t\t\t\tcnt, i);\n+\t\t}\n+\t\tmlx5_free(ct_pool);\n+\t\t/* in case of failure. */\n+\t\tmng->next--;\n+\t}\n+\tmlx5_free(mng->pools);\n+\tmlx5_free(mng);\n+\t/* Management structure must be cleared to 0s during allocation. */\n+\tsh->ct_mng = NULL;\n+}\n+\n /**\n * Initialize the flow resources' indexed mempool.\n *\n@@ -1238,6 +1292,8 @@ mlx5_free_shared_dev_ctx(struct mlx5_dev_ctx_shared *sh)\n \t}\n \tif (sh->mtrmng)\n \t\tmlx5_aso_flow_mtrs_mng_close(sh);\n+\tif (sh->ct_mng)\n+\t\tmlx5_flow_aso_ct_mng_close(sh);\n \tmlx5_flow_ipool_destroy(sh);\n \tmlx5_os_dev_shared_handler_uninstall(sh);\n \tif (sh->cnt_id_tbl) {\ndiff --git a/drivers/net/mlx5/mlx5_flow_aso.c b/drivers/net/mlx5/mlx5_flow_aso.c\nindex bb3221a..6a13b98 100644\n--- a/drivers/net/mlx5/mlx5_flow_aso.c\n+++ b/drivers/net/mlx5/mlx5_flow_aso.c\n@@ -393,6 +393,10 @@ mlx5_aso_queue_uninit(struct mlx5_dev_ctx_shared *sh,\n \tcase ASO_OPC_MOD_POLICER:\n \t\tsq = &sh->mtrmng->pools_mng.sq;\n \t\tbreak;\n+\tcase ASO_OPC_MOD_CONNECTION_TRACKING:\n+\t\tmlx5_aso_devx_dereg_mr(&sh->ct_mng->aso_sq.mr);\n+\t\tsq = &sh->ct_mng->aso_sq;\n+\t\tbreak;\n \tdefault:\n \t\tDRV_LOG(ERR, \"Unknown ASO operation mode\");\n \t\treturn;\n", "prefixes": [ "08/17" ] }