Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92060/?format=api
{ "id": 92060, "url": "https://patches.dpdk.org/api/patches/92060/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1619165464-7545-1-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619165464-7545-1-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619165464-7545-1-git-send-email-humin29@huawei.com", "date": "2021-04-23T08:11:04", "name": "mbuf: check mbuf dyn shared memory validity", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "761da1313a1d38dfb9a8814fcb279dd589dc2dc9", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1619165464-7545-1-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16623, "url": "https://patches.dpdk.org/api/series/16623/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16623", "date": "2021-04-23T08:11:04", "name": "mbuf: check mbuf dyn shared memory validity", "version": 1, "mbox": "https://patches.dpdk.org/series/16623/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92060/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92060/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1DA32A0548;\n\tFri, 23 Apr 2021 10:11:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0575A4067E;\n\tFri, 23 Apr 2021 10:11:01 +0200 (CEST)", "from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by mails.dpdk.org (Postfix) with ESMTP id E09154014F\n for <dev@dpdk.org>; Fri, 23 Apr 2021 10:10:59 +0200 (CEST)", "from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FRRkR2wQHz7wxL;\n Fri, 23 Apr 2021 16:08:31 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id\n 14.3.498.0; Fri, 23 Apr 2021 16:10:54 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <olivier.matz@6wind.com>, <thomas@monjalon.net>", "Date": "Fri, 23 Apr 2021 16:11:04 +0800", "Message-ID": "<1619165464-7545-1-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH] mbuf: check mbuf dyn shared memory validity", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nBecause mbuf dyn shared memory was allocated runtime, so it's\nnecessary to check validity when dump mbuf dyn info.\n\nAlso this patch adds an error logging when init shared memory fail.\n\nFixes: 4958ca3a443a (\"mbuf: support dynamic fields and flags\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n lib/mbuf/rte_mbuf_dyn.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/mbuf/rte_mbuf_dyn.c b/lib/mbuf/rte_mbuf_dyn.c\nindex 7d5e942..ca46eb2 100644\n--- a/lib/mbuf/rte_mbuf_dyn.c\n+++ b/lib/mbuf/rte_mbuf_dyn.c\n@@ -115,8 +115,10 @@ init_shared_mem(void)\n \t} else {\n \t\tmz = rte_memzone_lookup(RTE_MBUF_DYN_MZNAME);\n \t}\n-\tif (mz == NULL)\n+\tif (mz == NULL) {\n+\t\tRTE_LOG(ERR, MBUF, \"Failed to get mbuf dyn shared memory\\n\");\n \t\treturn -1;\n+\t}\n \n \tshm = mz->addr;\n \n@@ -525,7 +527,11 @@ void rte_mbuf_dyn_dump(FILE *out)\n \tsize_t i;\n \n \trte_mcfg_tailq_write_lock();\n-\tinit_shared_mem();\n+\tif (init_shared_mem() < 0) {\n+\t\trte_mcfg_tailq_write_unlock();\n+\t\treturn;\n+\t}\n+\n \tfprintf(out, \"Reserved fields:\\n\");\n \tmbuf_dynfield_list = RTE_TAILQ_CAST(\n \t\tmbuf_dynfield_tailq.head, mbuf_dynfield_list);\n", "prefixes": [] }