Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91759/?format=api
https://patches.dpdk.org/api/patches/91759/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1618839289-33224-8-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618839289-33224-8-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618839289-33224-8-git-send-email-humin29@huawei.com", "date": "2021-04-19T13:34:46", "name": "[07/10] examples/l3fwd: add function return value check", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "82f57d512e2f37fe605af6c68782a17c58b773b5", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1618839289-33224-8-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16492, "url": "https://patches.dpdk.org/api/series/16492/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16492", "date": "2021-04-19T13:34:39", "name": "fixes for clean code", "version": 1, "mbox": "https://patches.dpdk.org/series/16492/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/91759/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/91759/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 81170A0524;\n\tMon, 19 Apr 2021 15:35:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D33CB41310;\n\tMon, 19 Apr 2021 15:34:57 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id CD4FD412ED\n for <dev@dpdk.org>; Mon, 19 Apr 2021 15:34:50 +0200 (CEST)", "from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FP7621xshzqTWG;\n Mon, 19 Apr 2021 21:32:26 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id\n 14.3.498.0; Mon, 19 Apr 2021 21:34:39 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <cristian.dumitrescu@intel.com>,\n <jerinj@marvell.com>, <jianjay.zhou@huawei.com>, <jia.guo@intel.com>,\n <g.singh@nxp.com>, <andrew.rybchenko@oktetlabs.ru>, <hemant.agrawal@nxp.com>,\n <orika@nvidia.com>", "Date": "Mon, 19 Apr 2021 21:34:46 +0800", "Message-ID": "<1618839289-33224-8-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618839289-33224-1-git-send-email-humin29@huawei.com>", "References": "<1618839289-33224-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 07/10] examples/l3fwd: add function return value\n check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: HongBo Zheng <zhenghongbo3@huawei.com>\n\nReturn value of a function 'rte_eth_macaddr_get' called at\nl3fwd_eth_dev_port_setup is not checked, but it is usually\nchecked for this function.\n\nThis patch fix this problem.\n\nFixes: a65bf3d724df (\"examples/l3fwd: add ethdev setup based on eventdev\")\nCc: stable@dpdk.org\n\nSigned-off-by: HongBo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n examples/l3fwd/l3fwd_event.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/examples/l3fwd/l3fwd_event.c b/examples/l3fwd/l3fwd_event.c\nindex 4d31593..7f704f9 100644\n--- a/examples/l3fwd/l3fwd_event.c\n+++ b/examples/l3fwd/l3fwd_event.c\n@@ -105,7 +105,11 @@ l3fwd_eth_dev_port_setup(struct rte_eth_conf *port_conf)\n \t\t\t\t \"Cannot adjust number of descriptors: err=%d, \"\n \t\t\t\t \"port=%d\\n\", ret, port_id);\n \n-\t\trte_eth_macaddr_get(port_id, &ports_eth_addr[port_id]);\n+\t\tret = rte_eth_macaddr_get(port_id, &ports_eth_addr[port_id]);\n+\t\tif (ret < 0)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"Cannot get MAC address: err=%d, port=%d\\n\",\n+\t\t\t\t ret, port_id);\n \t\tprint_ethaddr(\" Address:\", &ports_eth_addr[port_id]);\n \t\tprintf(\", \");\n \t\tprint_ethaddr(\"Destination:\",\n", "prefixes": [ "07/10" ] }{ "id": 91759, "url": "