Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91591/?format=api
{ "id": 91591, "url": "https://patches.dpdk.org/api/patches/91591/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210415151135.2098674-14-lizh@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210415151135.2098674-14-lizh@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210415151135.2098674-14-lizh@nvidia.com", "date": "2021-04-15T15:11:33", "name": "[v5,13/14] net/mlx5: make ASO meter queue thread-safe", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "573de97bbf11fb85226500db3320c1c5353164e2", "submitter": { "id": 1967, "url": "https://patches.dpdk.org/api/people/1967/?format=api", "name": "Li Zhang", "email": "lizh@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210415151135.2098674-14-lizh@nvidia.com/mbox/", "series": [ { "id": 16417, "url": "https://patches.dpdk.org/api/series/16417/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16417", "date": "2021-04-15T15:11:20", "name": "Add ASO meter support in MLX5 PMD", "version": 5, "mbox": "https://patches.dpdk.org/series/16417/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/91591/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/91591/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 645CEA0C3F;\n\tThu, 15 Apr 2021 17:13:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E0990162355;\n\tThu, 15 Apr 2021 17:12:07 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 76E15162307\n for <dev@dpdk.org>; Thu, 15 Apr 2021 17:11:51 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n lizh@nvidia.com)\n with SMTP; 15 Apr 2021 18:11:48 +0300", "from nvidia.com (c-235-17-1-009.mtl.labs.mlnx [10.235.17.9])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 13FFBjPS032677;\n Thu, 15 Apr 2021 18:11:48 +0300" ], "From": "Li Zhang <lizh@nvidia.com>", "To": "dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com,\n matan@nvidia.com, shahafs@nvidia.com", "Cc": "dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com", "Date": "Thu, 15 Apr 2021 18:11:33 +0300", "Message-Id": "<20210415151135.2098674-14-lizh@nvidia.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20210415151135.2098674-1-lizh@nvidia.com>", "References": "<20210331073632.1443011-1-lizh@nvidia.com>\n <20210415151135.2098674-1-lizh@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 13/14] net/mlx5: make ASO meter queue\n thread-safe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Synchronize ASO meter queue accesses from\ndifferent threads using a spinlock.\n\nSigned-off-by: Li Zhang <lizh@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5.h | 1 +\n drivers/net/mlx5/mlx5_flow_aso.c | 16 +++++++++++++---\n 2 files changed, 14 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex d2ae69f209..d0798226ce 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -493,6 +493,7 @@ struct mlx5_aso_sq_elem {\n \n struct mlx5_aso_sq {\n \tuint16_t log_desc_n;\n+\trte_spinlock_t sqsl;\n \tstruct mlx5_aso_cq cq;\n \tstruct mlx5_devx_sq sq_obj;\n \tvolatile uint64_t *uar_addr;\ndiff --git a/drivers/net/mlx5/mlx5_flow_aso.c b/drivers/net/mlx5/mlx5_flow_aso.c\nindex fe5c9912f2..cd2cc016b9 100644\n--- a/drivers/net/mlx5/mlx5_flow_aso.c\n+++ b/drivers/net/mlx5/mlx5_flow_aso.c\n@@ -274,6 +274,7 @@ mlx5_aso_sq_create(void *ctx, struct mlx5_aso_sq *sq, int socket,\n \tsq->tail = 0;\n \tsq->sqn = sq->sq_obj.sq->id;\n \tsq->uar_addr = mlx5_os_get_devx_uar_reg_addr(uar);\n+\trte_spinlock_init(&sq->sqsl);\n \treturn 0;\n error:\n \tmlx5_aso_destroy_sq(sq);\n@@ -665,12 +666,15 @@ mlx5_aso_mtr_sq_enqueue_single(struct mlx5_aso_sq *sq,\n \tstruct mlx5_flow_meter_info *fm = NULL;\n \tuint16_t size = 1 << sq->log_desc_n;\n \tuint16_t mask = size - 1;\n-\tuint16_t res = size - (uint16_t)(sq->head - sq->tail);\n+\tuint16_t res;\n \tuint32_t dseg_idx = 0;\n \tstruct mlx5_aso_mtr_pool *pool = NULL;\n \n+\trte_spinlock_lock(&sq->sqsl);\n+\tres = size - (uint16_t)(sq->head - sq->tail);\n \tif (unlikely(!res)) {\n \t\tDRV_LOG(ERR, \"Fail: SQ is full and no free WQE to send\");\n+\t\trte_spinlock_unlock(&sq->sqsl);\n \t\treturn 0;\n \t}\n \twqe = &sq->sq_obj.aso_wqes[sq->head & mask];\n@@ -707,6 +711,7 @@ mlx5_aso_mtr_sq_enqueue_single(struct mlx5_aso_sq *sq,\n \trte_wmb();\n \t*sq->uar_addr = *(volatile uint64_t *)wqe; /* Assume 64 bit ARCH. */\n \trte_wmb();\n+\trte_spinlock_unlock(&sq->sqsl);\n \treturn 1;\n }\n \n@@ -737,12 +742,16 @@ mlx5_aso_mtr_completion_handle(struct mlx5_aso_sq *sq)\n \tconst unsigned int mask = cq_size - 1;\n \tuint32_t idx;\n \tuint32_t next_idx = cq->cq_ci & mask;\n-\tconst uint16_t max = (uint16_t)(sq->head - sq->tail);\n+\tuint16_t max;\n \tuint16_t n = 0;\n \tint ret;\n \n-\tif (unlikely(!max))\n+\trte_spinlock_lock(&sq->sqsl);\n+\tmax = (uint16_t)(sq->head - sq->tail);\n+\tif (unlikely(!max)) {\n+\t\trte_spinlock_unlock(&sq->sqsl);\n \t\treturn;\n+\t}\n \tdo {\n \t\tidx = next_idx;\n \t\tnext_idx = (cq->cq_ci + 1) & mask;\n@@ -769,6 +778,7 @@ mlx5_aso_mtr_completion_handle(struct mlx5_aso_sq *sq)\n \t\trte_io_wmb();\n \t\tcq->cq_obj.db_rec[0] = rte_cpu_to_be_32(cq->cq_ci);\n \t}\n+\trte_spinlock_unlock(&sq->sqsl);\n }\n \n /**\n", "prefixes": [ "v5", "13/14" ] }