Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91577/?format=api
{ "id": 91577, "url": "https://patches.dpdk.org/api/patches/91577/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20210415140933.23185-1-dliu@iol.unh.edu/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20210415140933.23185-1-dliu@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dts/20210415140933.23185-1-dliu@iol.unh.edu", "date": "2021-04-15T14:09:32", "name": "Strip prompt by default in send_expect", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "22bda17416343eca6fef63fbb85008d952e30147", "submitter": { "id": 1818, "url": "https://patches.dpdk.org/api/people/1818/?format=api", "name": "dliu", "email": "dliu@iol.unh.edu" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20210415140933.23185-1-dliu@iol.unh.edu/mbox/", "series": [ { "id": 16416, "url": "https://patches.dpdk.org/api/series/16416/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=16416", "date": "2021-04-15T14:09:32", "name": "Strip prompt by default in send_expect", "version": 1, "mbox": "https://patches.dpdk.org/series/16416/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/91577/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/91577/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48054A0C3F;\n\tThu, 15 Apr 2021 16:09:47 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 20C3D161C88;\n\tThu, 15 Apr 2021 16:09:47 +0200 (CEST)", "from mail-qk1-f180.google.com (mail-qk1-f180.google.com\n [209.85.222.180])\n by mails.dpdk.org (Postfix) with ESMTP id 2B4EF161C86\n for <dts@dpdk.org>; Thu, 15 Apr 2021 16:09:45 +0200 (CEST)", "by mail-qk1-f180.google.com with SMTP id d23so13211793qko.12\n for <dts@dpdk.org>; Thu, 15 Apr 2021 07:09:45 -0700 (PDT)", "from ubuntu.localdomain ([2606:4100:3880:1254::1053])\n by smtp.gmail.com with ESMTPSA id n136sm2006331qka.133.2021.04.15.07.09.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 15 Apr 2021 07:09:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu;\n s=unh-iol;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=4iXM0ZDkKtpWYei5bBrPuUh6dLt/tGM6oRBGS+MTYa8=;\n b=hgVyo65nRavrfNAcsvwrRm8Fd4JDxqvnK0UpDJwV0FHFv///3paXqbvfAcGvQH9uax\n Z8kcmIXLl9dG8tAPQ0wY/swWhaUKBfRCe1MCy6avPP7cDSESczU2qP2t6oM6MZD87OVs\n vzCy9EMShKrWIFrY9u34BpO9r22ucLpfpa0BI=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=4iXM0ZDkKtpWYei5bBrPuUh6dLt/tGM6oRBGS+MTYa8=;\n b=rwTvifFHSaREC89NxKen/IixjOz6rNbscIFBIplHnROrvcVoeUfPa59d84WgCJct0T\n VBPYofbYXlkOyo5lJCfMAVycDdhnnqlcI7er6dSNkmWqID4EFJ8dlqUzNnjAUCnxvGkY\n bz8ow7Ky/u60vPgg1XylqRQMlwZPdsiMQ36gU3u8BAMhiOueSNgfbw0jLpQHwd5wp78/\n b4zvLkzJAUR/Z4lnn6gz2OMYS/eALG7YkNEwjTOnXrbBRiLuD+/OVTE0Ml/8C+iin9lK\n KrWGJLU31bE9aCy/qnrj1jAlLz1wu1FNc+tXsr7QBy8OebEx36wPfdxdp1ARynOL2L7b\n dtuw==", "X-Gm-Message-State": "AOAM532Yro1Zy+y15FT6TeHyiwyp82kLp0WzlkXY+NK6h0WAUjXWVjMS\n 3uXLLsiy/TPFnv0StJ1mbkO4ZeOh321IP23o0MuCMnZgsHWc8DRqmdvYy82H0R8MJQJ6CSnPGvj\n xpd6EPpQZW5AIhteM0tmdX5Xe05pzKutZrKVb+W40kLEJE+Xt/MsxbNE=", "X-Google-Smtp-Source": "\n ABdhPJxPjzrk29vviyTbqtESvwLDtzDqbBLF01GjN2U+j9WqvAE26DL5eijS8iyQKcU8525exYcgQA==", "X-Received": "by 2002:ae9:df82:: with SMTP id\n t124mr3508359qkf.267.1618495784175;\n Thu, 15 Apr 2021 07:09:44 -0700 (PDT)", "From": "dliu <dliu@iol.unh.edu>", "To": "dts@dpdk.org", "Cc": "lijuan.tu@intel.com,\n\tOwen Hilyard <ohilyard@iol.unh.edu>", "Date": "Thu, 15 Apr 2021 10:09:32 -0400", "Message-Id": "<20210415140933.23185-1-dliu@iol.unh.edu>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dts] [PATCH] Strip prompt by default in send_expect", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "From: Owen Hilyard <ohilyard@iol.unh.edu>\n\nDuring investigation of timeout exceptions during performance testing, the\ncommunity lab found that trailing whitespace in run commands was the cause\nof some of the timeouts. This patch makes the Crb version of send_expect\nstrip whitespace from the expected string by default. It is possible to\ndisable this behavior should it be needed, but we expect that the majority\nof use-cases are matching non-whitespace characters.\n\nSigned-off-by: Owen Hilyard <ohilyard@iol.unh.edu>\n---\n framework/crb.py | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/framework/crb.py b/framework/crb.py\nindex e7c1cc1c..3964e213 100644\n--- a/framework/crb.py\n+++ b/framework/crb.py\n@@ -79,12 +79,19 @@ class Crb(object):\n self.alt_session = None\n \n def send_expect(self, cmds, expected, timeout=TIMEOUT,\n- alt_session=False, verify=False):\n+ alt_session=False, verify=False, trim_whitespace=True):\n \"\"\"\n Send commands to crb and return string before expected string. If\n there's no expected string found before timeout, TimeoutException will\n be raised.\n+\n+ By default, it will trim the whitespace from the expected string. This\n+ behavior can be turned off via the trim_whitespace argument.\n \"\"\"\n+\n+ if trim_whitespace:\n+ expected = expected.strip()\n+\n # sometimes there will be no alt_session like VM dut\n if alt_session and self.alt_session:\n return self.alt_session.session.send_expect(cmds, expected,\n", "prefixes": [] }