Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91573/?format=api
{ "id": 91573, "url": "https://patches.dpdk.org/api/patches/91573/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1618487412-26678-2-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618487412-26678-2-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618487412-26678-2-git-send-email-humin29@huawei.com", "date": "2021-04-15T11:50:11", "name": "[v3,1/2] telemetry: fix missing check for thread creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "79e6fe091b81e926ac32e24cfea3d341732d448d", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1618487412-26678-2-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16412, "url": "https://patches.dpdk.org/api/series/16412/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16412", "date": "2021-04-15T11:50:10", "name": "fix missing check for thread creation", "version": 3, "mbox": "https://patches.dpdk.org/series/16412/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/91573/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/91573/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EFFA5A0C3F;\n\tThu, 15 Apr 2021 13:50:17 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4B25B162208;\n\tThu, 15 Apr 2021 13:50:10 +0200 (CEST)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id 2417E162167\n for <dev@dpdk.org>; Thu, 15 Apr 2021 13:50:06 +0200 (CEST)", "from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FLcyM3wH8zpX7T;\n Thu, 15 Apr 2021 19:47:07 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id\n 14.3.498.0; Thu, 15 Apr 2021 19:49:56 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <ciara.power@intel.com>,\n <reshma.pattan@intel.com>, <david.marchand@redhat.com>", "Date": "Thu, 15 Apr 2021 19:50:11 +0800", "Message-ID": "<1618487412-26678-2-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618487412-26678-1-git-send-email-humin29@huawei.com>", "References": "<1618051453-21264-1-git-send-email-humin29@huawei.com>\n <1618487412-26678-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v3 1/2] telemetry: fix missing check for thread\n creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nAdd result check and message print out for thread creation after\nfailure.\n\nFixes: b80fe1805eee (\"telemetry: introduce backward compatibility\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n lib/librte_telemetry/telemetry.c | 30 +++++++++++++++++++++++++++---\n lib/librte_telemetry/telemetry_legacy.c | 10 ++++++++--\n 2 files changed, 35 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c\nindex 7e08afd..e6a99f3 100644\n--- a/lib/librte_telemetry/telemetry.c\n+++ b/lib/librte_telemetry/telemetry.c\n@@ -350,6 +350,7 @@ socket_listener(void *socket)\n {\n \twhile (1) {\n \t\tpthread_t th;\n+\t\tint rc;\n \t\tstruct socket *s = (struct socket *)socket;\n \t\tint s_accepted = accept(s->sock, NULL, NULL);\n \t\tif (s_accepted < 0) {\n@@ -366,7 +367,12 @@ socket_listener(void *socket)\n \t\t\t__atomic_add_fetch(s->num_clients, 1,\n \t\t\t\t\t__ATOMIC_RELAXED);\n \t\t}\n-\t\tpthread_create(&th, NULL, s->fn, (void *)(uintptr_t)s_accepted);\n+\t\trc = pthread_create(&th, NULL, s->fn, (void *)(uintptr_t)s_accepted);\n+\t\tif (rc != 0) {\n+\t\t\tTMTY_LOG(ERR, \"Error with create client thread\\n\");\n+\t\t\tclose(s_accepted);\n+\t\t\treturn NULL;\n+\t\t}\n \t\tpthread_detach(th);\n \t}\n \treturn NULL;\n@@ -425,6 +431,7 @@ static int\n telemetry_legacy_init(void)\n {\n \tpthread_t t_old;\n+\tint rc;\n \n \tif (num_legacy_callbacks == 1) {\n \t\tTMTY_LOG(WARNING, \"No legacy callbacks, legacy socket not created\\n\");\n@@ -440,7 +447,15 @@ telemetry_legacy_init(void)\n \tv1_socket.sock = create_socket(v1_socket.path);\n \tif (v1_socket.sock < 0)\n \t\treturn -1;\n-\tpthread_create(&t_old, NULL, socket_listener, &v1_socket);\n+\trc = pthread_create(&t_old, NULL, socket_listener, &v1_socket);\n+\tif (rc != 0) {\n+\t\tTMTY_LOG(ERR, \"Error with create thread for legacy socket\\n\");\n+\t\tclose(v1_socket.sock);\n+\t\tv1_socket.sock = -1;\n+\t\tunlink(v1_socket.path);\n+\t\tv1_socket.path[0] = '\\0';\n+\t\treturn -1;\n+\t}\n \tpthread_setaffinity_np(t_old, sizeof(*thread_cpuset), thread_cpuset);\n \n \tTMTY_LOG(DEBUG, \"Legacy telemetry socket initialized ok\\n\");\n@@ -451,6 +466,7 @@ static int\n telemetry_v2_init(void)\n {\n \tpthread_t t_new;\n+\tint rc;\n \n \tv2_socket.num_clients = &v2_clients;\n \trte_telemetry_register_cmd(\"/\", list_commands,\n@@ -469,7 +485,15 @@ telemetry_v2_init(void)\n \tv2_socket.sock = create_socket(v2_socket.path);\n \tif (v2_socket.sock < 0)\n \t\treturn -1;\n-\tpthread_create(&t_new, NULL, socket_listener, &v2_socket);\n+\trc = pthread_create(&t_new, NULL, socket_listener, &v2_socket);\n+\tif (rc != 0) {\n+\t\tTMTY_LOG(ERR, \"Error with create thread for socket\");\n+\t\tclose(v2_socket.sock);\n+\t\tv2_socket.sock = -1;\n+\t\tunlink(v2_socket.path);\n+\t\tv2_socket.path[0] = '\\0';\n+\t\treturn -1;\n+\t}\n \tpthread_setaffinity_np(t_new, sizeof(*thread_cpuset), thread_cpuset);\n \tatexit(unlink_sockets);\n \ndiff --git a/lib/librte_telemetry/telemetry_legacy.c b/lib/librte_telemetry/telemetry_legacy.c\nindex 5e9af37..fd242bf 100644\n--- a/lib/librte_telemetry/telemetry_legacy.c\n+++ b/lib/librte_telemetry/telemetry_legacy.c\n@@ -83,6 +83,7 @@ register_client(const char *cmd __rte_unused, const char *params,\n \tpthread_t th;\n \tchar data[BUF_SIZE];\n \tint fd;\n+\tint rc;\n \tstruct sockaddr_un addrs;\n #endif /* !RTE_EXEC_ENV_WINDOWS */\n \n@@ -112,8 +113,13 @@ register_client(const char *cmd __rte_unused, const char *params,\n \t\tclose(fd);\n \t\treturn -1;\n \t}\n-\tpthread_create(&th, NULL, &legacy_client_handler,\n-\t\t\t(void *)(uintptr_t)fd);\n+\trc = pthread_create(&th, NULL, &legacy_client_handler,\n+\t\t\t\t(void *)(uintptr_t)fd);\n+\tif (rc != 0) {\n+\t\tperror(\"Failed to create legacy client thread\\n\");\n+\t\tclose(fd);\n+\t\treturn -1;\n+\t}\n #endif /* !RTE_EXEC_ENV_WINDOWS */\n \treturn 0;\n }\n", "prefixes": [ "v3", "1/2" ] }