Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91572/?format=api
{ "id": 91572, "url": "https://patches.dpdk.org/api/patches/91572/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1618487412-26678-3-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618487412-26678-3-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618487412-26678-3-git-send-email-humin29@huawei.com", "date": "2021-04-15T11:50:12", "name": "[v3,2/2] test: fix missing check for thread creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2ad302249b4088f43af4f3ec3c43d4b00e3ce378", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1618487412-26678-3-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16412, "url": "https://patches.dpdk.org/api/series/16412/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16412", "date": "2021-04-15T11:50:10", "name": "fix missing check for thread creation", "version": 3, "mbox": "https://patches.dpdk.org/series/16412/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/91572/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/91572/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B6425A0C3F;\n\tThu, 15 Apr 2021 13:50:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9579916217A;\n\tThu, 15 Apr 2021 13:50:08 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 7946E16216E\n for <dev@dpdk.org>; Thu, 15 Apr 2021 13:50:05 +0200 (CEST)", "from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FLcyL6CrzzPqpb;\n Thu, 15 Apr 2021 19:47:06 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id\n 14.3.498.0; Thu, 15 Apr 2021 19:49:56 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <ciara.power@intel.com>,\n <reshma.pattan@intel.com>, <david.marchand@redhat.com>", "Date": "Thu, 15 Apr 2021 19:50:12 +0800", "Message-ID": "<1618487412-26678-3-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618487412-26678-1-git-send-email-humin29@huawei.com>", "References": "<1618051453-21264-1-git-send-email-humin29@huawei.com>\n <1618487412-26678-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v3 2/2] test: fix missing check for thread\n creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nThere was a call for thread create function without result check.\nAdd result check and message print out after failure.\n\nFixes: 086eb64db39e (\"test/pdump: add unit test for pdump library\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n app/test/process.h | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/process.h b/app/test/process.h\nindex 27f1b1c..2a0a8da 100644\n--- a/app/test/process.h\n+++ b/app/test/process.h\n@@ -48,6 +48,7 @@ process_dup(const char *const argv[], int numargs, const char *env_value)\n #ifdef RTE_LIB_PDUMP\n #ifdef RTE_NET_RING\n \tpthread_t thread;\n+\tint rc;\n #endif\n #endif\n \n@@ -126,8 +127,11 @@ process_dup(const char *const argv[], int numargs, const char *env_value)\n \t/* parent process does a wait */\n #ifdef RTE_LIB_PDUMP\n #ifdef RTE_NET_RING\n-\tif ((strcmp(env_value, \"run_pdump_server_tests\") == 0))\n-\t\tpthread_create(&thread, NULL, &send_pkts, NULL);\n+\tif ((strcmp(env_value, \"run_pdump_server_tests\") == 0)) {\n+\t\trc = pthread_create(&thread, NULL, &send_pkts, NULL);\n+\t\tif (rc != 0)\n+\t\t\trte_panic(\"Cannot start send pkts thread\\n\");\n+\t}\n #endif\n #endif\n \n", "prefixes": [ "v3", "2/2" ] }