Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91549/?format=api
{ "id": 91549, "url": "https://patches.dpdk.org/api/patches/91549/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1618475721-43792-1-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618475721-43792-1-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618475721-43792-1-git-send-email-humin29@huawei.com", "date": "2021-04-15T08:35:21", "name": "[v3] net/hns3: rename Rx burst API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0aff0fe7c17d49bb6151aa5013683ec5bc040322", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1618475721-43792-1-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16401, "url": "https://patches.dpdk.org/api/series/16401/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16401", "date": "2021-04-15T08:35:21", "name": "[v3] net/hns3: rename Rx burst API", "version": 3, "mbox": "https://patches.dpdk.org/series/16401/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/91549/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/91549/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B0AD9A0A0C;\n\tThu, 15 Apr 2021 10:35:11 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7E897162101;\n\tThu, 15 Apr 2021 10:35:11 +0200 (CEST)", "from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by mails.dpdk.org (Postfix) with ESMTP id 387EF1620FF\n for <dev@dpdk.org>; Thu, 15 Apr 2021 10:35:10 +0200 (CEST)", "from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FLXf91hZKzB0hR\n for <dev@dpdk.org>; Thu, 15 Apr 2021 16:32:49 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id\n 14.3.498.0; Thu, 15 Apr 2021 16:35:04 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Thu, 15 Apr 2021 16:35:21 +0800", "Message-ID": "<1618475721-43792-1-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618314611-47978-11-git-send-email-humin29@huawei.com>", "References": "<1618314611-47978-11-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v3] net/hns3: rename Rx burst API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nCurrently, user could use runtime config \"rx_func_hint=simple\" to\nselect the hns3_recv_pkts API, but the API's name get from\nrte_eth_rx_burst_mode_get is \"Scalar\" which has not reflected \"simple\".\n\nSo this patch renames hns3_recv_pkts to hns3_recv_pkts_simple, and\nalso change it's name which gets from rte_eth_rx_burst_mode_get to\n\"Scalar Simple\" to maintain conceptual consistency.\n\nFixes: 521ab3e93361 (\"net/hns3: add simple Rx path\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\nAcked-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nv3:\n* Modify commit info.\n\nv2:\n* Revert \"Scalar Scattered\".\n---\n drivers/net/hns3/hns3_rxtx.c | 18 ++++++++++--------\n drivers/net/hns3/hns3_rxtx.h | 4 ++--\n 2 files changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex ce5d852..bc107d0 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -1991,7 +1991,7 @@ hns3_dev_supported_ptypes_get(struct rte_eth_dev *dev)\n \t\tRTE_PTYPE_UNKNOWN\n \t};\n \n-\tif (dev->rx_pkt_burst == hns3_recv_pkts ||\n+\tif (dev->rx_pkt_burst == hns3_recv_pkts_simple ||\n \t dev->rx_pkt_burst == hns3_recv_scattered_pkts ||\n \t dev->rx_pkt_burst == hns3_recv_pkts_vec ||\n \t dev->rx_pkt_burst == hns3_recv_pkts_vec_sve)\n@@ -2366,7 +2366,9 @@ hns3_rx_alloc_buffer(struct hns3_rx_queue *rxq)\n }\n \n uint16_t\n-hns3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n+hns3_recv_pkts_simple(void *rx_queue,\n+\t\t struct rte_mbuf **rx_pkts,\n+\t\t uint16_t nb_pkts)\n {\n \tvolatile struct hns3_desc *rx_ring; /* RX ring (desc) */\n \tvolatile struct hns3_desc *rxdp; /* pointer of the current desc */\n@@ -2742,10 +2744,10 @@ hns3_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,\n \t\teth_rx_burst_t pkt_burst;\n \t\tconst char *info;\n \t} burst_infos[] = {\n-\t\t{ hns3_recv_pkts,\t\t\"Scalar\" },\n+\t\t{ hns3_recv_pkts_simple,\t\"Scalar Simple\" },\n \t\t{ hns3_recv_scattered_pkts,\t\"Scalar Scattered\" },\n-\t\t{ hns3_recv_pkts_vec,\t\t\"Vector Neon\" },\n-\t\t{ hns3_recv_pkts_vec_sve,\t\"Vector Sve\" },\n+\t\t{ hns3_recv_pkts_vec,\t\t\"Vector Neon\" },\n+\t\t{ hns3_recv_pkts_vec_sve,\t\"Vector Sve\" },\n \t};\n \n \teth_rx_burst_t pkt_burst = dev->rx_pkt_burst;\n@@ -2792,14 +2794,14 @@ hns3_get_rx_function(struct rte_eth_dev *dev)\n \tif (hns->rx_func_hint == HNS3_IO_FUNC_HINT_SVE && sve_allowed)\n \t\treturn hns3_recv_pkts_vec_sve;\n \tif (hns->rx_func_hint == HNS3_IO_FUNC_HINT_SIMPLE && simple_allowed)\n-\t\treturn hns3_recv_pkts;\n+\t\treturn hns3_recv_pkts_simple;\n \tif (hns->rx_func_hint == HNS3_IO_FUNC_HINT_COMMON)\n \t\treturn hns3_recv_scattered_pkts;\n \n \tif (vec_allowed)\n \t\treturn hns3_recv_pkts_vec;\n \tif (simple_allowed)\n-\t\treturn hns3_recv_pkts;\n+\t\treturn hns3_recv_pkts_simple;\n \n \treturn hns3_recv_scattered_pkts;\n }\n@@ -4433,7 +4435,7 @@ hns3_dev_rx_descriptor_status(void *rx_queue, uint16_t offset)\n \trxdp = &rxq->rx_ring[desc_id];\n \tbd_base_info = rte_le_to_cpu_32(rxdp->rx.bd_base_info);\n \tdev = &rte_eth_devices[rxq->port_id];\n-\tif (dev->rx_pkt_burst == hns3_recv_pkts ||\n+\tif (dev->rx_pkt_burst == hns3_recv_pkts_simple ||\n \t dev->rx_pkt_burst == hns3_recv_scattered_pkts) {\n \t\tif (offset >= rxq->nb_rx_desc - rxq->rx_free_hold)\n \t\t\treturn RTE_ETH_RX_DESC_UNAVAIL;\ndiff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3/hns3_rxtx.h\nindex 6689397..d4ac12e 100644\n--- a/drivers/net/hns3/hns3_rxtx.h\n+++ b/drivers/net/hns3/hns3_rxtx.h\n@@ -680,8 +680,8 @@ int hns3_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id);\n int hns3_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id);\n int hns3_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id);\n int hns3_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id);\n-uint16_t hns3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n-\t\t\tuint16_t nb_pkts);\n+uint16_t hns3_recv_pkts_simple(void *rx_queue, struct rte_mbuf **rx_pkts,\n+\t\t\t\tuint16_t nb_pkts);\n uint16_t hns3_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\t\t uint16_t nb_pkts);\n uint16_t hns3_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n", "prefixes": [ "v3" ] }