Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91475/?format=api
{ "id": 91475, "url": "https://patches.dpdk.org/api/patches/91475/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210414220651.28691-1-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210414220651.28691-1-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210414220651.28691-1-dmitry.kozliuk@gmail.com", "date": "2021-04-14T22:06:47", "name": "[v10,0/4] eal/windows: do not expose POSIX symbols", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210414220651.28691-1-dmitry.kozliuk@gmail.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/91475/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/91475/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 77A9BA0A02;\n\tThu, 15 Apr 2021 00:07:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EBEB740687;\n\tThu, 15 Apr 2021 00:07:01 +0200 (CEST)", "from mail-lj1-f171.google.com (mail-lj1-f171.google.com\n [209.85.208.171])\n by mails.dpdk.org (Postfix) with ESMTP id 3FD1040685\n for <dev@dpdk.org>; Thu, 15 Apr 2021 00:07:00 +0200 (CEST)", "by mail-lj1-f171.google.com with SMTP id p23so21234686ljn.0\n for <dev@dpdk.org>; Wed, 14 Apr 2021 15:07:00 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id m28sm271489lfo.278.2021.04.14.15.06.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 14 Apr 2021 15:06:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=uyMn7/rwF0HrJDXaTB5z1mQxRlzgT/jox4KXjQyahDY=;\n b=uLCR4Aztj6Agz43p0Im3toXBTokandt0uT5DZDbusUuFXVTJK+6kySThlzndtJPEGL\n Lwk8GoFPJJNdOtw48smdWx8lWZlfmc++kFsEwGbnvWo78fgU73TaAXCooIfH3vda/uLz\n ni10KMN+p9G5iTz+qXOcTq/yqfMWWy1bcTPgQe5RuD4se5vamJr6wRl0FkfGbEGV35v/\n y0x13DP355T+RM5Yg/i6DWd7ktLw9WSjZgpHtmwapCYFws9jeLT/TmeUp/Ay1G8c3gn9\n IKvm9hGFKQtEN6zXpeuzSt0jPf6eJDjhO5iqKeKY51VqyT7gI0umjJw35kBctRWrpNLf\n /7fQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=uyMn7/rwF0HrJDXaTB5z1mQxRlzgT/jox4KXjQyahDY=;\n b=qXIB2SB7FAuvzyzOM0WrvAZNI+7PRmjd4RcojWwzSihm5Z+Gq3fJQje2/OVV8lAowj\n dY8kz2CqzPEUpZeibAVQxZvNHlkRnGF+qojlw+CDLNCojtDJoxMarJj7k9udmXwUODkC\n yAIecQnui/onxMlZesh29UnjCKO5m0VgFk+tCbrgzBT4wCSsHhHWxSKU+9MblNyP8lXZ\n US7xS4EpL3vlx5ZIelkhDVWfMY5VJJeIAKDmt6RyWJ3V63oQrhY0IVKd5LB/kxXL5tTo\n BVPFgis8QfuOU3srp1xuyitQmCts1/3zRed0zOH0VN13oDyN6ZwZUxGk31UQFXRIOQnT\n 4h2w==", "X-Gm-Message-State": "AOAM530JC3M5qp4LsmOJfUGsjFnPda3ViFYp8SlbvWmqupOw143FXug+\n +68wav2Aw6E33HPyIXrimZn3ht2GS6QHvA==", "X-Google-Smtp-Source": "\n ABdhPJzoRf5cQZA77lMRxBy6o+ZibDhLtrbS2WAKCrIxYDFSUFcVqCBVGAvQGIqVEd4i28VKPrwz8A==", "X-Received": "by 2002:a2e:88c6:: with SMTP id a6mr73644ljk.87.1618438019434;\n Wed, 14 Apr 2021 15:06:59 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "Date": "Thu, 15 Apr 2021 01:06:47 +0300", "Message-Id": "<20210414220651.28691-1-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.3", "In-Reply-To": "<20210410224732.20234-1-dmitry.kozliuk@gmail.com>", "References": "<20210410224732.20234-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v10 0/4] eal/windows: do not expose POSIX symbols", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On Windows, EAL contains two sets of functions and macros for POSIX\ncompatibility: <rte_os.h> and a networking shim (socket headers).\nThe latter conflicts with system headers and should not exist.\nExposing the former from EAL can break consumer own POSIX compatibility\nlayer and is against standards in general. Hide these symbols from\nexternal consumers, while keeping them available for DPDK code.\n\nv10:\n * Fix examples that build on Windows.\nv9:\n * Fix missing <rte_os_shim.h> include in rte_common_log.c.\n (This will happen again. Going to add a checkpatch test\n after this series is merged.)\n\nDmitry Kozlyuk (4):\n eal/windows: hide asprintf() shim\n eal: make OS shims internal\n net: work around s_addr macro on Windows\n net: provide IP-related API on any OS\n\n drivers/bus/pci/private.h | 4 +-\n drivers/bus/vdev/vdev_private.h | 2 +\n drivers/common/mlx5/mlx5_common.h | 1 +\n drivers/net/i40e/i40e_ethdev.c | 1 +\n drivers/net/i40e/i40e_fdir.c | 1 +\n drivers/net/mlx5/mlx5.h | 1 -\n drivers/net/mlx5/mlx5_flow.c | 4 +-\n drivers/net/mlx5/mlx5_flow.h | 3 +-\n drivers/net/mlx5/mlx5_mac.c | 1 -\n examples/cmdline/commands.c | 5 --\n examples/cmdline/parse_obj_list.c | 2 -\n examples/flow_filtering/main.c | 1 -\n examples/l2fwd/main.c | 1 -\n examples/link_status_interrupt/main.c | 1 -\n examples/service_cores/main.c | 4 +-\n lib/librte_cmdline/cmdline.c | 5 --\n lib/librte_cmdline/cmdline_os_windows.c | 2 -\n lib/librte_cmdline/cmdline_parse.c | 2 -\n lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 --\n lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 --\n lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +-\n lib/librte_cmdline/cmdline_private.h | 1 +\n lib/librte_cmdline/cmdline_socket.c | 4 -\n lib/librte_eal/common/eal_common_config.c | 1 -\n lib/librte_eal/common/eal_common_errno.c | 4 +\n lib/librte_eal/common/eal_common_log.c | 1 +\n lib/librte_eal/common/eal_common_options.c | 2 +-\n lib/librte_eal/common/eal_common_timer.c | 4 +-\n lib/librte_eal/common/eal_internal_cfg.h | 1 +\n lib/librte_eal/common/eal_private.h | 11 +++\n lib/librte_eal/freebsd/include/rte_os_shim.h | 14 +++\n lib/librte_eal/linux/include/rte_os_shim.h | 14 +++\n lib/librte_eal/windows/eal.c | 30 +++++++\n lib/librte_eal/windows/eal_hugepages.c | 1 -\n lib/librte_eal/windows/eal_lcore.c | 1 -\n lib/librte_eal/windows/eal_memalloc.c | 1 -\n lib/librte_eal/windows/include/arpa/inet.h | 30 -------\n lib/librte_eal/windows/include/netinet/in.h | 38 --------\n lib/librte_eal/windows/include/netinet/ip.h | 10 ---\n lib/librte_eal/windows/include/rte_os.h | 92 +-------------------\n lib/librte_eal/windows/include/rte_os_shim.h | 36 ++++++++\n lib/librte_eal/windows/include/sys/socket.h | 24 -----\n lib/librte_ethdev/ethdev_private.h | 2 +\n lib/librte_ethdev/rte_ethdev.c | 12 +--\n lib/librte_ethdev/rte_ethdev_core.h | 1 -\n lib/librte_kvargs/rte_kvargs.c | 1 +\n lib/librte_net/rte_ether.h | 26 ++++--\n lib/librte_net/rte_ip.h | 7 ++\n lib/librte_net/rte_net.c | 1 +\n 49 files changed, 167 insertions(+), 258 deletions(-)\n create mode 100644 lib/librte_eal/freebsd/include/rte_os_shim.h\n create mode 100644 lib/librte_eal/linux/include/rte_os_shim.h\n delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h\n delete mode 100644 lib/librte_eal/windows/include/netinet/in.h\n delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h\n create mode 100644 lib/librte_eal/windows/include/rte_os_shim.h\n delete mode 100644 lib/librte_eal/windows/include/sys/socket.h", "diff": null, "prefixes": [ "v10", "0/4" ] }