Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91254/?format=api
{ "id": 91254, "url": "https://patches.dpdk.org/api/patches/91254/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1618321639-57642-10-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618321639-57642-10-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618321639-57642-10-git-send-email-humin29@huawei.com", "date": "2021-04-13T13:47:19", "name": "[9/9] net/hns3: add the configuration of fixed speed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "aa34a0ff8d6e1cca45aed2027977e1b6f30db05f", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1618321639-57642-10-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16336, "url": "https://patches.dpdk.org/api/series/16336/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16336", "date": "2021-04-13T13:47:11", "name": "support speed capability and autoneg report", "version": 1, "mbox": "https://patches.dpdk.org/series/16336/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/91254/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/91254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03DB3A0524;\n\tTue, 13 Apr 2021 15:47:30 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D0A5B160FD5;\n\tTue, 13 Apr 2021 15:47:11 +0200 (CEST)", "from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by mails.dpdk.org (Postfix) with ESMTP id D4A32160FC5\n for <dev@dpdk.org>; Tue, 13 Apr 2021 15:47:06 +0200 (CEST)", "from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FKRgY3VXCzlXpd\n for <dev@dpdk.org>; Tue, 13 Apr 2021 21:45:13 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id\n 14.3.498.0; Tue, 13 Apr 2021 21:47:02 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Tue, 13 Apr 2021 21:47:19 +0800", "Message-ID": "<1618321639-57642-10-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618321639-57642-1-git-send-email-humin29@huawei.com>", "References": "<1618321639-57642-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 9/9] net/hns3: add the configuration of fixed\n speed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThis patch adds the configuration of fixed speed for the PF device.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 144 ++++++++++++++++++++++++++++++++++++++---\n 1 file changed, 135 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 6262bf0..d5e2901 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2473,12 +2473,6 @@ hns3_dev_configure(struct rte_eth_dev *dev)\n \t}\n \n \thw->adapter_state = HNS3_NIC_CONFIGURING;\n-\tif (conf->link_speeds & ETH_LINK_SPEED_FIXED) {\n-\t\thns3_err(hw, \"setting link speed/duplex not supported\");\n-\t\tret = -EINVAL;\n-\t\tgoto cfg_err;\n-\t}\n-\n \tif ((uint32_t)mq_mode & ETH_MQ_RX_DCB_FLAG) {\n \t\tret = hns3_check_dcb_cfg(dev);\n \t\tif (ret)\n@@ -5271,6 +5265,130 @@ hns3_uninit_pf(struct rte_eth_dev *eth_dev)\n \thw->io_base = NULL;\n }\n \n+static uint32_t\n+hns3_convert_link_speeds2bitmap_copper(uint32_t link_speeds)\n+{\n+\tuint32_t speed_bit;\n+\n+\tswitch (link_speeds & ~ETH_LINK_SPEED_FIXED) {\n+\tcase ETH_LINK_SPEED_10M:\n+\t\tspeed_bit = HNS3_PHY_LINK_SPEED_10M_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_10M_HD:\n+\t\tspeed_bit = HNS3_PHY_LINK_SPEED_10M_HD_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_100M:\n+\t\tspeed_bit = HNS3_PHY_LINK_SPEED_100M_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_100M_HD:\n+\t\tspeed_bit = HNS3_PHY_LINK_SPEED_100M_HD_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_1G:\n+\t\tspeed_bit = HNS3_PHY_LINK_SPEED_1000M_BIT;\n+\t\tbreak;\n+\tdefault:\n+\t\tspeed_bit = 0;\n+\t\tbreak;\n+\t}\n+\n+\treturn speed_bit;\n+}\n+\n+static uint32_t\n+hns3_convert_link_speeds2bitmap_fiber(uint32_t link_speeds)\n+{\n+\tuint32_t speed_bit;\n+\n+\tswitch (link_speeds & ~ETH_LINK_SPEED_FIXED) {\n+\tcase ETH_LINK_SPEED_1G:\n+\t\tspeed_bit = HNS3_FIBER_LINK_SPEED_1G_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_10G:\n+\t\tspeed_bit = HNS3_FIBER_LINK_SPEED_10G_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_25G:\n+\t\tspeed_bit = HNS3_FIBER_LINK_SPEED_25G_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_40G:\n+\t\tspeed_bit = HNS3_FIBER_LINK_SPEED_40G_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_50G:\n+\t\tspeed_bit = HNS3_FIBER_LINK_SPEED_50G_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_100G:\n+\t\tspeed_bit = HNS3_FIBER_LINK_SPEED_100G_BIT;\n+\t\tbreak;\n+\tcase ETH_LINK_SPEED_200G:\n+\t\tspeed_bit = HNS3_FIBER_LINK_SPEED_200G_BIT;\n+\t\tbreak;\n+\tdefault:\n+\t\tspeed_bit = 0;\n+\t\tbreak;\n+\t}\n+\n+\treturn speed_bit;\n+}\n+\n+static int\n+hns3_check_port_speed(struct hns3_hw *hw, uint32_t link_speeds)\n+{\n+\tstruct hns3_mac *mac = &hw->mac;\n+\tuint32_t supported_speed = mac->supported_speed;\n+\tuint32_t speed_bit = 0;\n+\n+\tif (mac->media_type == HNS3_MEDIA_TYPE_COPPER)\n+\t\tspeed_bit = hns3_convert_link_speeds2bitmap_copper(link_speeds);\n+\telse if (mac->media_type == HNS3_MEDIA_TYPE_FIBER)\n+\t\tspeed_bit = hns3_convert_link_speeds2bitmap_fiber(link_speeds);\n+\n+\tif (!(speed_bit & supported_speed)) {\n+\t\thns3_err(hw, \"link_speeds(0x%x) exceeds the supported speed capability or is incorrect.\",\n+\t\t\t link_speeds);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static inline uint32_t\n+hns3_get_link_speed(uint32_t link_speeds)\n+{\n+\tuint32_t speed = ETH_SPEED_NUM_NONE;\n+\n+\tif (link_speeds & ETH_LINK_SPEED_10M ||\n+\t link_speeds & ETH_LINK_SPEED_10M_HD)\n+\t\tspeed = ETH_SPEED_NUM_10M;\n+\tif (link_speeds & ETH_LINK_SPEED_100M ||\n+\t link_speeds & ETH_LINK_SPEED_100M_HD)\n+\t\tspeed = ETH_SPEED_NUM_100M;\n+\tif (link_speeds & ETH_LINK_SPEED_1G)\n+\t\tspeed = ETH_SPEED_NUM_1G;\n+\tif (link_speeds & ETH_LINK_SPEED_10G)\n+\t\tspeed = ETH_SPEED_NUM_10G;\n+\tif (link_speeds & ETH_LINK_SPEED_25G)\n+\t\tspeed = ETH_SPEED_NUM_25G;\n+\tif (link_speeds & ETH_LINK_SPEED_40G)\n+\t\tspeed = ETH_SPEED_NUM_40G;\n+\tif (link_speeds & ETH_LINK_SPEED_50G)\n+\t\tspeed = ETH_SPEED_NUM_50G;\n+\tif (link_speeds & ETH_LINK_SPEED_100G)\n+\t\tspeed = ETH_SPEED_NUM_100G;\n+\tif (link_speeds & ETH_LINK_SPEED_200G)\n+\t\tspeed = ETH_SPEED_NUM_200G;\n+\n+\treturn speed;\n+}\n+\n+static uint8_t\n+hns3_get_link_duplex(uint32_t link_speeds)\n+{\n+\tif ((link_speeds & ETH_LINK_SPEED_10M_HD) ||\n+\t (link_speeds & ETH_LINK_SPEED_100M_HD))\n+\t\treturn ETH_LINK_HALF_DUPLEX;\n+\telse\n+\t\treturn ETH_LINK_FULL_DUPLEX;\n+}\n+\n static int\n hns3_set_copper_port_link_speed(struct hns3_hw *hw,\n \t\t\t\tstruct hns3_set_link_speed_cfg *cfg)\n@@ -5298,6 +5416,9 @@ hns3_set_copper_port_link_speed(struct hns3_hw *hw,\n \t\t\t\t HNS3_PHY_LINK_SPEED_100M_BIT |\n \t\t\t\t HNS3_PHY_LINK_SPEED_100M_HD_BIT |\n \t\t\t\t HNS3_PHY_LINK_SPEED_1000M_BIT;\n+\t} else {\n+\t\treq->speed = cfg->speed;\n+\t\treq->duplex = cfg->duplex;\n \t}\n \n \treturn hns3_cmd_send(hw, desc, HNS3_PHY_PARAM_CFG_BD_NUM);\n@@ -5358,7 +5479,7 @@ hns3_set_fiber_port_link_speed(struct hns3_hw *hw,\n \t\treturn 0;\n \t}\n \n-\treturn 0;\n+\treturn hns3_cfg_mac_speed_dup(hw, cfg->speed, cfg->duplex);\n }\n \n static int\n@@ -5397,13 +5518,18 @@ hns3_apply_link_speed(struct hns3_hw *hw)\n {\n \tstruct rte_eth_conf *conf = &hw->data->dev_conf;\n \tstruct hns3_set_link_speed_cfg cfg;\n+\tint ret;\n \n \tmemset(&cfg, 0, sizeof(struct hns3_set_link_speed_cfg));\n \tcfg.autoneg = (conf->link_speeds == ETH_LINK_SPEED_AUTONEG) ?\n \t\t\tETH_LINK_AUTONEG : ETH_LINK_FIXED;\n \tif (cfg.autoneg != ETH_LINK_AUTONEG) {\n-\t\thns3_err(hw, \"device doesn't support to force link speed.\");\n-\t\treturn -EOPNOTSUPP;\n+\t\tret = hns3_check_port_speed(hw, conf->link_speeds);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n+\t\tcfg.speed = hns3_get_link_speed(conf->link_speeds);\n+\t\tcfg.duplex = hns3_get_link_duplex(conf->link_speeds);\n \t}\n \n \treturn hns3_set_port_link_speed(hw, &cfg);\n", "prefixes": [ "9/9" ] }