Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/910/?format=api
{ "id": 910, "url": "https://patches.dpdk.org/api/patches/910/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1413965977-15165-3-git-send-email-jingjing.wu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1413965977-15165-3-git-send-email-jingjing.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1413965977-15165-3-git-send-email-jingjing.wu@intel.com", "date": "2014-10-22T08:19:36", "name": "[dpdk-dev,v2,2/3] i40e: ctrl_pkt filter implementation in i40e pmd driver", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b3735626b2a52a41e3c07c78ae23b048d6d9fa47", "submitter": { "id": 47, "url": "https://patches.dpdk.org/api/people/47/?format=api", "name": "Jingjing Wu", "email": "jingjing.wu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1413965977-15165-3-git-send-email-jingjing.wu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/910/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/910/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F24917E9E;\n\tWed, 22 Oct 2014 10:12:17 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id D038F7E7B\n\tfor <dev@dpdk.org>; Wed, 22 Oct 2014 10:12:15 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 22 Oct 2014 01:19:13 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 22 Oct 2014 01:20:20 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id s9M8KHLA004971;\n\tWed, 22 Oct 2014 16:20:17 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid s9M8KF7C015216; Wed, 22 Oct 2014 16:20:17 +0800", "(from wujingji@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s9M8KFXw015212; \n\tWed, 22 Oct 2014 16:20:15 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,767,1406617200\"; d=\"scan'208\";a=\"593610890\"", "From": "Jingjing Wu <jingjing.wu@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 22 Oct 2014 16:19:36 +0800", "Message-Id": "<1413965977-15165-3-git-send-email-jingjing.wu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1413965977-15165-1-git-send-email-jingjing.wu@intel.com>", "References": "<1411628369-29532-1-git-send-email-jingjing.wu@intel.com>\n\t<1413965977-15165-1-git-send-email-jingjing.wu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/3] i40e: ctrl_pkt filter implementation in\n\ti40e pmd driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "implement control packet filter, support add and delete operations.\nIt can assign packets to specific queue or vsi by filtering with mac\naddress and ethertype or only ethertype on both rx and tx directions.\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 138 +++++++++++++++++++++++++++++++++++++-\n 1 file changed, 136 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex 3b75f0f..943b01a 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -186,6 +186,12 @@ static int i40e_dev_rss_hash_update(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_rss_conf *rss_conf);\n static int i40e_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_rss_conf *rss_conf);\n+static int i40e_ctrl_pkt_filter_set(struct i40e_pf *pf,\n+\t\t\tstruct rte_ctrl_pkt_filter *cp_filter,\n+\t\t\tbool add);\n+static int i40e_ctrl_pkt_filter_handle(struct i40e_pf *pf,\n+\t\t\t\tenum rte_filter_op filter_op,\n+\t\t\t\tvoid *arg);\n static int i40e_dev_filter_ctrl(struct rte_eth_dev *dev,\n \t\t\t\tenum rte_filter_type filter_type,\n \t\t\t\tenum rte_filter_op filter_op,\n@@ -4145,20 +4151,148 @@ i40e_pf_config_mq_rx(struct i40e_pf *pf)\n \treturn 0;\n }\n \n+/* Look up vsi by vsi_id */\n+static struct i40e_vsi *\n+i40e_vsi_lookup_by_id(struct i40e_vsi *uplink_vsi, uint16_t id)\n+{\n+\tstruct i40e_vsi *vsi = NULL;\n+\tstruct i40e_vsi_list *vsi_list;\n+\n+\tif (uplink_vsi == NULL)\n+\t\treturn NULL;\n+\n+\tif (uplink_vsi->vsi_id == id)\n+\t\treturn vsi;\n+\n+\t/* if VSI has child to attach*/\n+\tif (uplink_vsi->veb) {\n+\t\tTAILQ_FOREACH(vsi_list, &uplink_vsi->veb->head, list) {\n+\t\t\tvsi = i40e_vsi_lookup_by_id(vsi_list->vsi, id);\n+\t\t\tif (vsi)\n+\t\t\t\treturn vsi;\n+\t\t}\n+\t}\n+\treturn NULL;\n+}\n+\n+/*\n+ * Configure control packet filter, which can director packet by filtering\n+ * with mac address and ether_type or only ether_type\n+ */\n+static int\n+i40e_ctrl_pkt_filter_set(struct i40e_pf *pf,\n+\t\t\tstruct rte_ctrl_pkt_filter *cp_filter,\n+\t\t\tbool add)\n+{\n+\tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n+\tstruct i40e_control_filter_stats stats;\n+\tstruct i40e_vsi *vsi = NULL;\n+\tuint16_t seid;\n+\tuint16_t flags = 0;\n+\tint ret;\n+\n+\tif (cp_filter->ether_type == ETHER_TYPE_IPv4 ||\n+\t\tcp_filter->ether_type == ETHER_TYPE_IPv6) {\n+\t\tPMD_DRV_LOG(ERR, \"unsupported ether_type(0x%04x) in\"\n+\t\t\t\" control packet filter.\", cp_filter->ether_type);\n+\t\treturn -EINVAL;\n+\t}\n+\tif (cp_filter->ether_type == ETHER_TYPE_VLAN)\n+\t\tPMD_DRV_LOG(WARNING, \"filter vlan ether_type in first tag is\"\n+\t\t\t\" not supported.\");\n+\n+\tif (cp_filter->dest_id == 0)\n+\t\t/* Use LAN VSI Id if not programmed by user */\n+\t\tvsi = pf->main_vsi;\n+\telse {\n+\t\tvsi = i40e_vsi_lookup_by_id(pf->main_vsi, cp_filter->dest_id);\n+\t\tif (vsi == NULL || vsi->type == I40E_VSI_FDIR) {\n+\t\t\tPMD_DRV_LOG(ERR, \"VSI arg is invalid\\n\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t}\n+\n+\tseid = vsi->seid;\n+\tmemset(&stats, 0, sizeof(stats));\n+\n+\tif (cp_filter->flags & RTE_CONTROL_PACKET_FLAGS_TX)\n+\t\tflags |= I40E_AQC_ADD_CONTROL_PACKET_FLAGS_TX;\n+\tif (cp_filter->flags & RTE_CONTROL_PACKET_FLAGS_IGNORE_MAC)\n+\t\tflags |= I40E_AQC_ADD_CONTROL_PACKET_FLAGS_IGNORE_MAC;\n+\tif (cp_filter->flags & RTE_CONTROL_PACKET_FLAGS_TO_QUEUE)\n+\t\tflags |= I40E_AQC_ADD_CONTROL_PACKET_FLAGS_TO_QUEUE;\n+\tif (cp_filter->flags & RTE_CONTROL_PACKET_FLAGS_DROP)\n+\t\tflags |= I40E_AQC_ADD_CONTROL_PACKET_FLAGS_DROP;\n+\n+\tret = i40e_aq_add_rem_control_packet_filter(hw,\n+\t\t\tcp_filter->mac_addr.addr_bytes,\n+\t\t\tcp_filter->ether_type, flags,\n+\t\t\tseid, cp_filter->queue, add, &stats, NULL);\n+\n+\tPMD_DRV_LOG(INFO, \"add/rem control packet filter, return %d,\"\n+\t\t\t \" mac_etype_used = %u, etype_used = %u,\"\n+\t\t\t \" mac_etype_free = %u, etype_free = %u\\n\",\n+\t\t\t ret, stats.mac_etype_used, stats.etype_used,\n+\t\t\t stats.mac_etype_free, stats.etype_free);\n+\tif (ret < 0)\n+\t\treturn -ENOSYS;\n+\treturn 0;\n+}\n+\n+/*\n+ * Handle operations for control packte filter type.\n+ */\n+static int\n+i40e_ctrl_pkt_filter_handle(struct i40e_pf *pf,\n+\t\t\t\tenum rte_filter_op filter_op,\n+\t\t\t\tvoid *arg)\n+{\n+\tint ret = 0;\n+\n+\tif (arg == NULL && filter_op != RTE_ETH_FILTER_NOP) {\n+\t\tPMD_DRV_LOG(ERR, \"arg shouldn't be NULL for operation %u\\n\",\n+\t\t\t filter_op);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tswitch (filter_op) {\n+\tcase RTE_ETH_FILTER_NOP:\n+\t\tret = 0;\n+\t\tbreak;\n+\tcase RTE_ETH_FILTER_ADD:\n+\t\tret = i40e_ctrl_pkt_filter_set(pf,\n+\t\t\t(struct rte_ctrl_pkt_filter *)arg,\n+\t\t\tTRUE);\n+\t\tbreak;\n+\tcase RTE_ETH_FILTER_DELETE:\n+\t\tret = i40e_ctrl_pkt_filter_set(pf,\n+\t\t\t(struct rte_ctrl_pkt_filter *)arg,\n+\t\t\tFALSE);\n+\t\tbreak;\n+\tdefault:\n+\t\tPMD_DRV_LOG(ERR, \"unsupported operation %u\\n\", filter_op);\n+\t\tret = -ENOSYS;\n+\t\tbreak;\n+\t}\n+\treturn ret;\n+}\n+\n static int\n i40e_dev_filter_ctrl(struct rte_eth_dev *dev,\n \t\t enum rte_filter_type filter_type,\n \t\t enum rte_filter_op filter_op,\n \t\t void *arg)\n {\n+\tstruct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n \tint ret = 0;\n-\t(void)filter_op;\n-\t(void)arg;\n \n \tif (dev == NULL)\n \t\treturn -EINVAL;\n \n \tswitch (filter_type) {\n+\tcase RTE_ETH_FILTER_CTRL_PKT:\n+\t\tret = i40e_ctrl_pkt_filter_handle(pf, filter_op, arg);\n+\t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(WARNING, \"Filter type (%d) not supported\",\n \t\t\t\t\t\t\tfilter_type);\n", "prefixes": [ "dpdk-dev", "v2", "2/3" ] }