Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90989/?format=api
{ "id": 90989, "url": "https://patches.dpdk.org/api/patches/90989/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210410005143.28686-1-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210410005143.28686-1-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210410005143.28686-1-ivan.malov@oktetlabs.ru", "date": "2021-04-10T00:51:43", "name": "common/sfc_efx/base: fix indication of MAE encap. support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fcd060d2ef4b9e2105237b994eab14eb3c359fe1", "submitter": { "id": 869, "url": "https://patches.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210410005143.28686-1-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 16254, "url": "https://patches.dpdk.org/api/series/16254/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16254", "date": "2021-04-10T00:51:43", "name": "common/sfc_efx/base: fix indication of MAE encap. support", "version": 1, "mbox": "https://patches.dpdk.org/series/16254/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/90989/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/90989/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 99F78A0547;\n\tSat, 10 Apr 2021 02:51:56 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5D33C141117;\n\tSat, 10 Apr 2021 02:51:56 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id B607340688;\n Sat, 10 Apr 2021 02:51:54 +0200 (CEST)", "from localhost.localdomain (unknown [188.242.7.54])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 312697F57C;\n Sat, 10 Apr 2021 03:51:54 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 312697F57C", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1618015914;\n bh=su4oT7RNklG8q9EzT654eeVYukYJQRj9GGsN7Vw+9II=;\n h=From:To:Cc:Subject:Date;\n b=SMpg/QpNqS857uiIL34EOgo2ewuuw8c/rOsQatpeWW4jUUkTco7v5wxh4qhb4uJe6\n bCFYQ39gFg3isYhcRfOWeViM31eFXq+3LUAEtiCRH+TCBxKipp04LwKtmJcmXz1cv5\n Pn/4/fR+iyBh5njAS2i3OvDA8qXcazdDHSu94aiw=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>", "Date": "Sat, 10 Apr 2021 03:51:43 +0300", "Message-Id": "<20210410005143.28686-1-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] common/sfc_efx/base: fix indication of MAE\n encap. support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The indication fields in the MCDI response are individual\nbits, but the current code mistakenly compares the larger\ndword with 1. This breaks encap. type discovery. Fix that.\n\nFixes: 891408c45a63 (\"common/sfc_efx/base: indicate MAE support for encapsulation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx_mae.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx_mae.c b/drivers/common/sfc_efx/base/efx_mae.c\nindex e6156102d..80fe155d0 100644\n--- a/drivers/common/sfc_efx/base/efx_mae.c\n+++ b/drivers/common/sfc_efx/base/efx_mae.c\n@@ -46,17 +46,20 @@ efx_mae_get_capabilities(\n \n \tmaep->em_encap_types_supported = 0;\n \n-\tif (MCDI_OUT_DWORD(req, MAE_GET_CAPS_OUT_ENCAP_TYPE_VXLAN) == 1) {\n+\tif (MCDI_OUT_DWORD_FIELD(req, MAE_GET_CAPS_OUT_ENCAP_TYPES_SUPPORTED,\n+\t MAE_GET_CAPS_OUT_ENCAP_TYPE_VXLAN) != 0) {\n \t\tmaep->em_encap_types_supported |=\n \t\t (1U << EFX_TUNNEL_PROTOCOL_VXLAN);\n \t}\n \n-\tif (MCDI_OUT_DWORD(req, MAE_GET_CAPS_OUT_ENCAP_TYPE_GENEVE) == 1) {\n+\tif (MCDI_OUT_DWORD_FIELD(req, MAE_GET_CAPS_OUT_ENCAP_TYPES_SUPPORTED,\n+\t MAE_GET_CAPS_OUT_ENCAP_TYPE_GENEVE) != 0) {\n \t\tmaep->em_encap_types_supported |=\n \t\t (1U << EFX_TUNNEL_PROTOCOL_GENEVE);\n \t}\n \n-\tif (MCDI_OUT_DWORD(req, MAE_GET_CAPS_OUT_ENCAP_TYPE_NVGRE) == 1) {\n+\tif (MCDI_OUT_DWORD_FIELD(req, MAE_GET_CAPS_OUT_ENCAP_TYPES_SUPPORTED,\n+\t MAE_GET_CAPS_OUT_ENCAP_TYPE_NVGRE) != 0) {\n \t\tmaep->em_encap_types_supported |=\n \t\t (1U << EFX_TUNNEL_PROTOCOL_NVGRE);\n \t}\n", "prefixes": [] }