Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90669/?format=api
{ "id": 90669, "url": "https://patches.dpdk.org/api/patches/90669/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210406131137.1732110-4-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210406131137.1732110-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210406131137.1732110-4-thomas@monjalon.net", "date": "2021-04-06T13:11:36", "name": "[v6,3/4] log: catch invalid level option number", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6fca345678d0a58ddd46fc763352420971c429f4", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210406131137.1732110-4-thomas@monjalon.net/mbox/", "series": [ { "id": 16129, "url": "https://patches.dpdk.org/api/series/16129/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16129", "date": "2021-04-06T13:11:33", "name": "log level enhancements", "version": 6, "mbox": "https://patches.dpdk.org/series/16129/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/90669/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/90669/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2258A0546;\n\tTue, 6 Apr 2021 15:12:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A3DE4140F5D;\n\tTue, 6 Apr 2021 15:11:54 +0200 (CEST)", "from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com\n [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id D5017140F3E\n for <dev@dpdk.org>; Tue, 6 Apr 2021 15:11:51 +0200 (CEST)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id 7EAD95C009F;\n Tue, 6 Apr 2021 09:11:51 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Tue, 06 Apr 2021 09:11:51 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id C87B724005C;\n Tue, 6 Apr 2021 09:11:50 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm3; bh=zQz8ZcofkXN67\n fgoxI9rvLy38vrHic5K38f7t1jD3U8=; b=VTpKRPVlIczBiONGXytu0PMDroozg\n sIYmXqL/CTZF59Sx/tU7v43+mNSvyTlhpajXI0MhqqiZYy1P+yCKPYZg4Fex9BXM\n jbh5Llixl+iEJHqvKQZqFBPAWcamAA8mKaHLz9CDwdOx2NjXhP6t15YqUxmGiVB5\n SuuSWoW3/kguOGuk/N3GGu2cqXzz1z7d0RQX1gAKUUzAGKdBPgNUWnGDXj601uKb\n WK692/dhdPuHBp86hEuCPdM06+5h2XKFJeKmc8ObEo7MAk5qSXD0tg0waKXvilLG\n 34hspVjSq1G/xmy4bPy6lwMVCq3onGlyeQnLgMhDZ1l5dJ9zM8fb85+fA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=zQz8ZcofkXN67fgoxI9rvLy38vrHic5K38f7t1jD3U8=; b=F0KH9Bnq\n q6WzCQln+WRfnSzLga6sjW5VXGQzy52WEWHLKExDNbia1MQ1IidkMf+pMeTi8bkp\n M/ghsVlRWIs4vGlm2RcvTVbyPaPHhrP4YyWjQ6yHZRjNJHAPv6Bi7RSN5a3gkJ1h\n W9GtMwcdwvCBSm7FK4kAgHD1X2KQ4ImTTJuzdP+VEOrtXERnYc8Bc9/u/jVCkrnX\n ptuUeKVF7JkoJMoNDueBgXnYvSrPxLskN7XXA7HL2e0m0lou4828f+HEnLLtAu+v\n eMiWUe+2Bw0WaXJbyk6Uu5MqaSLpMO8vYHpBtA8YK/+ZYFYcfN656X2NQbZdMA68\n YVH66OA5lYe50w==" ], "X-ME-Sender": "<xms:F15sYMeG_a-ITU8QaQMxxkdxiMEkA4Jz6Jd2kYQUIZKwnGlLawzflQ>\n <xme:F15sYONIc8-CglkVXbCZk9Cts7oVX0R7G4ydIibA088Rc-8LgiSGShdM-EzfyJF7g\n MAjpHkJwYjQMkwU0A>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledrudejhedgtdejucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:F15sYNhSNuqCth-3ImGOdcG7r-B0uAx6IEDCKDrNcNmqn2JK-eRP-w>\n <xmx:F15sYB_Cknus8e6T7dE_GLV93s8KfUvKBxroVCqOpmnHkWSeTed4vQ>\n <xmx:F15sYItFvIor0BtlrKedati4G-JKJZTeBEW3fI98jcuMxyjfZkNOJQ>\n <xmx:F15sYFVSTn9Ty1GP2zKE7nQdymfC__A2exCfiNQucgoz2jovl1jbYQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Date": "Tue, 6 Apr 2021 15:11:36 +0200", "Message-Id": "<20210406131137.1732110-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210406131137.1732110-1-thomas@monjalon.net>", "References": "<20210405193000.1113542-1-thomas@monjalon.net>\n <20210406131137.1732110-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 3/4] log: catch invalid level option number", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The parsing check for invalid log level was not trying to catch\nirrelevant numeric values.\nA log level 0 becomes a failure in parsing so it can be caught early.\nA log level higher than the max (8) is accepted with a warning message.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n lib/librte_eal/common/eal_common_options.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 38b72fb665..7075a051b8 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -1289,10 +1289,15 @@ eal_parse_log_level(const char *arg)\n \t}\n \n \tpriority = eal_parse_log_priority(level);\n-\tif (priority < 0) {\n-\t\tfprintf(stderr, \"invalid log priority: %s\\n\", level);\n+\tif (priority <= 0) {\n+\t\tfprintf(stderr, \"Invalid log level: %s\\n\", level);\n \t\tgoto fail;\n \t}\n+\tif (priority > (int)RTE_LOG_MAX) {\n+\t\tfprintf(stderr, \"Log level %d higher than maximum (%d)\\n\",\n+\t\t\t\tpriority, RTE_LOG_MAX);\n+\t\tpriority = RTE_LOG_MAX;\n+\t}\n \n \tif (regex) {\n \t\tif (rte_log_set_level_regexp(regex, priority) < 0) {\n", "prefixes": [ "v6", "3/4" ] }