Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90218/?format=api
{ "id": 90218, "url": "https://patches.dpdk.org/api/patches/90218/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210331095254.2454439-8-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210331095254.2454439-8-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210331095254.2454439-8-qi.z.zhang@intel.com", "date": "2021-03-31T09:52:53", "name": "[v6,7/8] net/ixgbe: refine debug build option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "10f9f8e6726f6089c8e576f2261cd558d6cce8e2", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210331095254.2454439-8-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 16008, "url": "https://patches.dpdk.org/api/series/16008/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16008", "date": "2021-03-31T09:52:46", "name": "ether: refine debug build option", "version": 6, "mbox": "https://patches.dpdk.org/series/16008/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/90218/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/90218/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 34231A034F;\n\tWed, 31 Mar 2021 11:49:58 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 51DAF140EA3;\n\tWed, 31 Mar 2021 11:49:34 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 78D48140E5E\n for <dev@dpdk.org>; Wed, 31 Mar 2021 11:49:30 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 31 Mar 2021 02:49:30 -0700", "from dpdk51.sh.intel.com ([10.67.111.142])\n by fmsmga002.fm.intel.com with ESMTP; 31 Mar 2021 02:49:27 -0700" ], "IronPort-SDR": [ "\n N9S8XHVz1KBoxTvE7dyMN9Owe81/M32Lx5dLC+IQTS0bvJ9dl30tK2igY3QUEhocq6dSaiD+DC\n lWlIli+Z3rcg==", "\n 5DLR1NqPd8JfFuvenHpCxU/wbQyQ6PH/ut4cKIMh3FLM9trQvigel5Ka/PeVavrNMGOD511Ydr\n PkddiC4s4rRQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9939\"; a=\"191448582\"", "E=Sophos;i=\"5.81,293,1610438400\"; d=\"scan'208\";a=\"191448582\"", "E=Sophos;i=\"5.81,293,1610438400\"; d=\"scan'208\";a=\"445603504\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com,\n xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com,\n jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com,\n Qi Zhang <qi.z.zhang@intel.com>", "Date": "Wed, 31 Mar 2021 17:52:53 +0800", "Message-Id": "<20210331095254.2454439-8-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210331095254.2454439-1-qi.z.zhang@intel.com>", "References": "<20210310121626.2019863-1-qi.z.zhang@intel.com>\n <20210331095254.2454439-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 7/8] net/ixgbe: refine debug build option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1. replace RTE_LIBRTE_IXGBE_DEBUG_RX with RTE_ETHDEV_DEBUG_RX.\n2. replace RTE_LIBRTE_IXGBE_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX.\n3. merge RTE_LIBRTE_IXGBE_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG\n into RTE_ETHDEV_DEBUG_TX\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 7 +---\n drivers/net/ixgbe/ixgbe_logs.h | 13 +------\n drivers/net/ixgbe/ixgbe_rxtx.c | 64 ++++++++++++++++----------------\n 3 files changed, 36 insertions(+), 48 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 31faff066c..2d308be48a 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -8452,12 +8452,9 @@ RTE_PMD_REGISTER_PARAM_STRING(net_ixgbe_vf,\n RTE_LOG_REGISTER(ixgbe_logtype_init, pmd.net.ixgbe.init, NOTICE);\n RTE_LOG_REGISTER(ixgbe_logtype_driver, pmd.net.ixgbe.driver, NOTICE);\n \n-#ifdef RTE_LIBRTE_IXGBE_DEBUG_RX\n+#ifdef RTE_ETHDEV_DEBUG_RX\n RTE_LOG_REGISTER(ixgbe_logtype_rx, pmd.net.ixgbe.rx, DEBUG);\n #endif\n-#ifdef RTE_LIBRTE_IXGBE_DEBUG_TX\n+#ifdef RTE_ETHDEV_DEBUG_TX\n RTE_LOG_REGISTER(ixgbe_logtype_tx, pmd.net.ixgbe.tx, DEBUG);\n #endif\n-#ifdef RTE_LIBRTE_IXGBE_DEBUG_TX_FREE\n-RTE_LOG_REGISTER(ixgbe_logtype_tx_free, pmd.net.ixgbe.tx_free, DEBUG);\n-#endif\ndiff --git a/drivers/net/ixgbe/ixgbe_logs.h b/drivers/net/ixgbe/ixgbe_logs.h\nindex 2a279d1098..00ef797ca1 100644\n--- a/drivers/net/ixgbe/ixgbe_logs.h\n+++ b/drivers/net/ixgbe/ixgbe_logs.h\n@@ -12,7 +12,7 @@ extern int ixgbe_logtype_init;\n \n #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, \" >>\")\n \n-#ifdef RTE_LIBRTE_IXGBE_DEBUG_RX\n+#ifdef RTE_ETHDEV_DEBUG_RX\n extern int ixgbe_logtype_rx;\n #define PMD_RX_LOG(level, fmt, args...)\t\t\t\\\n \trte_log(RTE_LOG_ ## level, ixgbe_logtype_rx,\t\\\n@@ -21,7 +21,7 @@ extern int ixgbe_logtype_rx;\n #define PMD_RX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n-#ifdef RTE_LIBRTE_IXGBE_DEBUG_TX\n+#ifdef RTE_ETHDEV_DEBUG_TX\n extern int ixgbe_logtype_tx;\n #define PMD_TX_LOG(level, fmt, args...)\t\t\t\\\n \trte_log(RTE_LOG_ ## level, ixgbe_logtype_tx,\t\\\n@@ -30,15 +30,6 @@ extern int ixgbe_logtype_tx;\n #define PMD_TX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n-#ifdef RTE_LIBRTE_IXGBE_DEBUG_TX_FREE\n-extern int ixgbe_logtype_tx_free;\n-#define PMD_TX_FREE_LOG(level, fmt, args...)\t\t\t\\\n-\trte_log(RTE_LOG_ ## level, ixgbe_logtype_tx_free,\t\\\n-\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n-#else\n-#define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)\n-#endif\n-\n extern int ixgbe_logtype_driver;\n #define PMD_DRV_LOG_RAW(level, fmt, args...) \\\n \trte_log(RTE_LOG_ ## level, ixgbe_logtype_driver, \"%s(): \" fmt, \\\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 7d23bab290..d69f36e977 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -583,11 +583,11 @@ ixgbe_xmit_cleanup(struct ixgbe_tx_queue *txq)\n \tdesc_to_clean_to = sw_ring[desc_to_clean_to].last_id;\n \tstatus = txr[desc_to_clean_to].wb.status;\n \tif (!(status & rte_cpu_to_le_32(IXGBE_TXD_STAT_DD))) {\n-\t\tPMD_TX_FREE_LOG(DEBUG,\n-\t\t\t\t\"TX descriptor %4u is not done\"\n-\t\t\t\t\"(port=%d queue=%d)\",\n-\t\t\t\tdesc_to_clean_to,\n-\t\t\t\ttxq->port_id, txq->queue_id);\n+\t\tPMD_TX_LOG(DEBUG,\n+\t\t\t \"TX descriptor %4u is not done\"\n+\t\t\t \"(port=%d queue=%d)\",\n+\t\t\t desc_to_clean_to,\n+\t\t\t txq->port_id, txq->queue_id);\n \t\t/* Failed to clean any descriptors, better luck next time */\n \t\treturn -(1);\n \t}\n@@ -600,11 +600,11 @@ ixgbe_xmit_cleanup(struct ixgbe_tx_queue *txq)\n \t\tnb_tx_to_clean = (uint16_t)(desc_to_clean_to -\n \t\t\t\t\t\tlast_desc_cleaned);\n \n-\tPMD_TX_FREE_LOG(DEBUG,\n-\t\t\t\"Cleaning %4u TX descriptors: %4u to %4u \"\n-\t\t\t\"(port=%d queue=%d)\",\n-\t\t\tnb_tx_to_clean, last_desc_cleaned, desc_to_clean_to,\n-\t\t\ttxq->port_id, txq->queue_id);\n+\tPMD_TX_LOG(DEBUG,\n+\t\t \"Cleaning %4u TX descriptors: %4u to %4u \"\n+\t\t \"(port=%d queue=%d)\",\n+\t\t nb_tx_to_clean, last_desc_cleaned, desc_to_clean_to,\n+\t\t txq->port_id, txq->queue_id);\n \n \t/*\n \t * The last descriptor to clean is done, so that means all the\n@@ -750,12 +750,12 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t * nb_used better be less than or equal to txq->tx_rs_thresh\n \t\t */\n \t\tif (nb_used > txq->nb_tx_free) {\n-\t\t\tPMD_TX_FREE_LOG(DEBUG,\n-\t\t\t\t\t\"Not enough free TX descriptors \"\n-\t\t\t\t\t\"nb_used=%4u nb_free=%4u \"\n-\t\t\t\t\t\"(port=%d queue=%d)\",\n-\t\t\t\t\tnb_used, txq->nb_tx_free,\n-\t\t\t\t\ttxq->port_id, txq->queue_id);\n+\t\t\tPMD_TX_LOG(DEBUG,\n+\t\t\t\t \"Not enough free TX descriptors \"\n+\t\t\t\t \"nb_used=%4u nb_free=%4u \"\n+\t\t\t\t \"(port=%d queue=%d)\",\n+\t\t\t\t nb_used, txq->nb_tx_free,\n+\t\t\t\t txq->port_id, txq->queue_id);\n \n \t\t\tif (ixgbe_xmit_cleanup(txq) != 0) {\n \t\t\t\t/* Could not clean any descriptors */\n@@ -766,17 +766,17 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \t\t\t/* nb_used better be <= txq->tx_rs_thresh */\n \t\t\tif (unlikely(nb_used > txq->tx_rs_thresh)) {\n-\t\t\t\tPMD_TX_FREE_LOG(DEBUG,\n-\t\t\t\t\t\"The number of descriptors needed to \"\n-\t\t\t\t\t\"transmit the packet exceeds the \"\n-\t\t\t\t\t\"RS bit threshold. This will impact \"\n-\t\t\t\t\t\"performance.\"\n-\t\t\t\t\t\"nb_used=%4u nb_free=%4u \"\n-\t\t\t\t\t\"tx_rs_thresh=%4u. \"\n-\t\t\t\t\t\"(port=%d queue=%d)\",\n-\t\t\t\t\tnb_used, txq->nb_tx_free,\n-\t\t\t\t\ttxq->tx_rs_thresh,\n-\t\t\t\t\ttxq->port_id, txq->queue_id);\n+\t\t\t\tPMD_TX_LOG(DEBUG,\n+\t\t\t\t\t \"The number of descriptors needed to \"\n+\t\t\t\t\t \"transmit the packet exceeds the \"\n+\t\t\t\t\t \"RS bit threshold. This will impact \"\n+\t\t\t\t\t \"performance.\"\n+\t\t\t\t\t \"nb_used=%4u nb_free=%4u \"\n+\t\t\t\t\t \"tx_rs_thresh=%4u. \"\n+\t\t\t\t\t \"(port=%d queue=%d)\",\n+\t\t\t\t\t nb_used, txq->nb_tx_free,\n+\t\t\t\t\t txq->tx_rs_thresh,\n+\t\t\t\t\t txq->port_id, txq->queue_id);\n \t\t\t\t/*\n \t\t\t\t * Loop here until there are enough TX\n \t\t\t\t * descriptors or until the ring cannot be\n@@ -920,10 +920,10 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \t\t/* Set RS bit only on threshold packets' last descriptor */\n \t\tif (txq->nb_tx_used >= txq->tx_rs_thresh) {\n-\t\t\tPMD_TX_FREE_LOG(DEBUG,\n-\t\t\t\t\t\"Setting RS bit on TXD id=\"\n-\t\t\t\t\t\"%4u (port=%d queue=%d)\",\n-\t\t\t\t\ttx_last, txq->port_id, txq->queue_id);\n+\t\t\tPMD_TX_LOG(DEBUG,\n+\t\t\t\t \"Setting RS bit on TXD id=\"\n+\t\t\t\t \"%4u (port=%d queue=%d)\",\n+\t\t\t\t tx_last, txq->port_id, txq->queue_id);\n \n \t\t\tcmd_type_len |= IXGBE_TXD_CMD_RS;\n \n@@ -995,7 +995,7 @@ ixgbe_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\treturn i;\n \t\t}\n \n-#ifdef RTE_LIBRTE_ETHDEV_DEBUG\n+#ifdef RTE_ETHDEV_DEBUG_TX\n \t\tret = rte_validate_tx_offload(m);\n \t\tif (ret != 0) {\n \t\t\trte_errno = -ret;\n", "prefixes": [ "v6", "7/8" ] }