Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90150/?format=api
{ "id": 90150, "url": "https://patches.dpdk.org/api/patches/90150/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20210331093410.505773-7-lijuan.tu@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20210331093410.505773-7-lijuan.tu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20210331093410.505773-7-lijuan.tu@intel.com", "date": "2021-03-31T09:34:10", "name": "[v2,6/6] tests/nic_single_core_perf: revise rx desc size", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "243a639d83e407f63cb72bb8aad009351aa5b2f1", "submitter": { "id": 1098, "url": "https://patches.dpdk.org/api/people/1098/?format=api", "name": "Tu, Lijuan", "email": "lijuan.tu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20210331093410.505773-7-lijuan.tu@intel.com/mbox/", "series": [ { "id": 15988, "url": "https://patches.dpdk.org/api/series/15988/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=15988", "date": "2021-03-31T09:34:04", "name": "revise tests/nic_signle_core_perf", "version": 2, "mbox": "https://patches.dpdk.org/series/15988/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/90150/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/90150/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6CECCA034F;\n\tWed, 31 Mar 2021 03:35:40 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 68014140DCA;\n\tWed, 31 Mar 2021 03:35:40 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 24FE8140DC0\n for <dts@dpdk.org>; Wed, 31 Mar 2021 03:35:38 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Mar 2021 18:35:38 -0700", "from dpdk-icelake-perf.sh.intel.com ([10.67.118.199])\n by fmsmga002.fm.intel.com with ESMTP; 30 Mar 2021 18:35:37 -0700" ], "IronPort-SDR": [ "\n zXC3BDO94JlOLr+JXyV7dpsiftUhgbWBstWgoi8IMl7+AhgDFqP2TVyqcOPRIM45qYTe6sqnII\n TefgjwdVnD/w==", "\n dQOzAtvz6EaXA+uNZ8aCoK1W+yCtWCHWI5QyYqJZIUv0S8hIFERmK8TtslljuN8vTiLrozp2TT\n +IcH1uolNitA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9939\"; a=\"277070341\"", "E=Sophos;i=\"5.81,291,1610438400\"; d=\"scan'208\";a=\"277070341\"", "E=Sophos;i=\"5.81,291,1610438400\"; d=\"scan'208\";a=\"445418623\"" ], "X-ExtLoop1": "1", "From": "Lijuan Tu <lijuan.tu@intel.com>", "To": "dliu@iol.unh.edu,\n\tohilyard@iol.unh.edu,\n\talialnu@nvidia.com", "Cc": "dts@dpdk.org,\n\tLijuan Tu <lijuan.tu@intel.com>", "Date": "Wed, 31 Mar 2021 09:34:10 +0000", "Message-Id": "<20210331093410.505773-7-lijuan.tu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210331093410.505773-1-lijuan.tu@intel.com>", "References": "<20210331093410.505773-1-lijuan.tu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dts] [v2 6/6] tests/nic_single_core_perf: revise rx desc size", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "rx_desc_16byte uses 'y' indicates the rx descriptor size to 16B, and\nother string for 32B. but 'y' is a reserved string in INI, misuse it\nwill casuse the wirte-back configurattion file can't be read correctly.\nso rename rx_desc_16byte to rx_desc_size and the type is integer.\n\nSigned-off-by: Lijuan Tu <lijuan.tu@intel.com>\n---\n conf/nic_single_core_perf.cfg | 4 +++-\n tests/TestSuite_nic_single_core_perf.py | 17 +++++++++--------\n 2 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/conf/nic_single_core_perf.cfg b/conf/nic_single_core_perf.cfg\nindex 72b8c533..7970995e 100644\n--- a/conf/nic_single_core_perf.cfg\n+++ b/conf/nic_single_core_perf.cfg\n@@ -5,6 +5,8 @@\n # numbers, and the pattern is\n # {'frame size': ['descriptor number #1', 'descriptor number #2']}\n #\n+# - rx_desc_size defines the rx descriptor size which is 16B or 32B.\n+#\n # - throughput_stat_sample_interval defines interval of get throughput\n # statistics (second). If not set, it is 5 seconds by default.\n #\n@@ -39,7 +41,7 @@\n update_expected = True\n test_parameters = {'1C/1T': {64: [512, 2048]},\n '1C/2T': {64: [512, 2048]}}\n-rx_desc_16byte = 'y'\n+rx_desc_size = 16\n test_duration = 60\n throughput_stat_sample_interval = 2\n accepted_tolerance = 0.05\ndiff --git a/tests/TestSuite_nic_single_core_perf.py b/tests/TestSuite_nic_single_core_perf.py\nindex 8606f599..ee022054 100644\n--- a/tests/TestSuite_nic_single_core_perf.py\n+++ b/tests/TestSuite_nic_single_core_perf.py\n@@ -58,13 +58,15 @@ class TestNicSingleCorePerf(TestCase):\n \"Not required NIC \")\n self.headers_size = HEADER_SIZE['eth'] + HEADER_SIZE['ip']\n \n- self.rx_desc = self.get_suite_cfg()['rx_desc_16byte']\n- if 'y' == self.rx_desc:\n+ self.rx_desc_size = self.get_suite_cfg().get('rx_desc_size', 32)\n+ err_msg = \"Rx desc only has 16B and 32B size, %d is not valid\" % self.rx_desc_size\n+ self.verify(self.rx_desc_size == 16 or self.rx_desc_size == 32, err_msg)\n+ if self.rx_desc_size == 16:\n # Update DPDK config file and rebuild to get best perf on fortville\n if self.nic in [\"fortville_25g\", \"fortville_spirit\"]:\n- self.dut.set_build_options({'RTE_LIBRTE_I40E_16BYTE_RX_DESC': self.rx_desc})\n+ self.dut.set_build_options({'RTE_LIBRTE_I40E_16BYTE_RX_DESC': 'y'})\n elif self.nic in [\"columbiaville_100g\", \"columbiaville_25g\", \"columbiaville_25gx2\"]:\n- self.dut.set_build_options({'RTE_LIBRTE_ICE_16BYTE_RX_DESC': self.rx_desc})\n+ self.dut.set_build_options({'RTE_LIBRTE_ICE_16BYTE_RX_DESC': 'y'})\n self.dut.build_install_dpdk(self.target)\n \n # Based on h/w type, choose how many ports to use\n@@ -417,11 +419,10 @@ class TestNicSingleCorePerf(TestCase):\n Run after each test suite.\n \"\"\"\n # resume setting\n- if 'y' == self.rx_desc:\n- self.rx_desc = 'n'\n+ if self.rx_desc_size == 16:\n if self.nic in [\"fortville_25g\", \"fortville_spirit\"]:\n- self.dut.set_build_options({'RTE_LIBRTE_I40E_16BYTE_RX_DESC': self.rx_desc})\n+ self.dut.set_build_options({'RTE_LIBRTE_I40E_16BYTE_RX_DESC': 'n'})\n elif self.nic in [\"columbiaville_100g\", \"columbiaville_25g\", \"columbiaville_25gx2\"]:\n- self.dut.set_build_options({'RTE_LIBRTE_ICE_16BYTE_RX_DESC': self.rx_desc})\n+ self.dut.set_build_options({'RTE_LIBRTE_ICE_16BYTE_RX_DESC': 'n'})\n self.dut.build_install_dpdk(self.target)\n self.dut.kill_all()\n", "prefixes": [ "v2", "6/6" ] }