Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89903/?format=api
{ "id": 89903, "url": "https://patches.dpdk.org/api/patches/89903/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1616748961-11239-2-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1616748961-11239-2-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1616748961-11239-2-git-send-email-humin29@huawei.com", "date": "2021-03-26T08:56:00", "name": "[1/2] net/hns3: fix code check warning", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f5510ca3ea83b468e0f0c4a5da72d38c46eba265", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1616748961-11239-2-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 15902, "url": "https://patches.dpdk.org/api/series/15902/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15902", "date": "2021-03-26T08:56:00", "name": "Support PTP for hns3 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/15902/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/89903/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/89903/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4C532A0A02;\n\tFri, 26 Mar 2021 09:55:41 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0A24340685;\n\tFri, 26 Mar 2021 09:55:41 +0100 (CET)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id A24A04067B\n for <dev@dpdk.org>; Fri, 26 Mar 2021 09:55:39 +0100 (CET)", "from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F6G3P3GGGz19JkX\n for <dev@dpdk.org>; Fri, 26 Mar 2021 16:53:37 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id\n 14.3.498.0; Fri, 26 Mar 2021 16:55:34 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@intel.com>", "Date": "Fri, 26 Mar 2021 16:56:00 +0800", "Message-ID": "<1616748961-11239-2-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1616748961-11239-1-git-send-email-humin29@huawei.com>", "References": "<1616748961-11239-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 1/2] net/hns3: fix code check warning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixed cyclomatic complexity about MTU\nin device configure process.\n\nFixes: 1f5ca0b460cd (\"net/hns3: support some device operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 61 +++++++++++++++++++++++++-----------------\n 1 file changed, 37 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex b7bfac8..b985447 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2373,6 +2373,40 @@ hns3_init_ring_with_vector(struct hns3_hw *hw)\n }\n \n static int\n+hns3_refresh_mtu(struct rte_eth_dev *dev, struct rte_eth_conf *conf)\n+{\n+\tstruct hns3_adapter *hns = dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tuint32_t max_rx_pkt_len;\n+\tuint16_t mtu;\n+\tint ret;\n+\n+\tif (!(conf->rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME))\n+\t\treturn 0;\n+\n+\t/*\n+\t * If jumbo frames are enabled, MTU needs to be refreshed\n+\t * according to the maximum RX packet length.\n+\t */\n+\tmax_rx_pkt_len = conf->rxmode.max_rx_pkt_len;\n+\tif (max_rx_pkt_len > HNS3_MAX_FRAME_LEN ||\n+\t max_rx_pkt_len <= HNS3_DEFAULT_FRAME_LEN) {\n+\t\thns3_err(hw, \"maximum Rx packet length must be greater than %u \"\n+\t\t\t \"and no more than %u when jumbo frame enabled.\",\n+\t\t\t (uint16_t)HNS3_DEFAULT_FRAME_LEN,\n+\t\t\t (uint16_t)HNS3_MAX_FRAME_LEN);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tmtu = (uint16_t)HNS3_PKTLEN_TO_MTU(max_rx_pkt_len);\n+\tret = hns3_dev_mtu_set(dev, mtu);\n+\tif (ret)\n+\t\treturn ret;\n+\tdev->data->mtu = mtu;\n+\n+\treturn 0;\n+}\n+static int\n hns3_dev_configure(struct rte_eth_dev *dev)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n@@ -2382,8 +2416,6 @@ hns3_dev_configure(struct rte_eth_dev *dev)\n \tuint16_t nb_rx_q = dev->data->nb_rx_queues;\n \tuint16_t nb_tx_q = dev->data->nb_tx_queues;\n \tstruct rte_eth_rss_conf rss_conf;\n-\tuint32_t max_rx_pkt_len;\n-\tuint16_t mtu;\n \tbool gro_en;\n \tint ret;\n \n@@ -2431,28 +2463,9 @@ hns3_dev_configure(struct rte_eth_dev *dev)\n \t\t\tgoto cfg_err;\n \t}\n \n-\t/*\n-\t * If jumbo frames are enabled, MTU needs to be refreshed\n-\t * according to the maximum RX packet length.\n-\t */\n-\tif (conf->rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n-\t\tmax_rx_pkt_len = conf->rxmode.max_rx_pkt_len;\n-\t\tif (max_rx_pkt_len > HNS3_MAX_FRAME_LEN ||\n-\t\t max_rx_pkt_len <= HNS3_DEFAULT_FRAME_LEN) {\n-\t\t\thns3_err(hw, \"maximum Rx packet length must be greater \"\n-\t\t\t\t \"than %u and less than %u when jumbo frame enabled.\",\n-\t\t\t\t (uint16_t)HNS3_DEFAULT_FRAME_LEN,\n-\t\t\t\t (uint16_t)HNS3_MAX_FRAME_LEN);\n-\t\t\tret = -EINVAL;\n-\t\t\tgoto cfg_err;\n-\t\t}\n-\n-\t\tmtu = (uint16_t)HNS3_PKTLEN_TO_MTU(max_rx_pkt_len);\n-\t\tret = hns3_dev_mtu_set(dev, mtu);\n-\t\tif (ret)\n-\t\t\tgoto cfg_err;\n-\t\tdev->data->mtu = mtu;\n-\t}\n+\tret = hns3_refresh_mtu(dev, conf);\n+\tif (ret)\n+\t\tgoto cfg_err;\n \n \tret = hns3_dev_configure_vlan(dev);\n \tif (ret)\n", "prefixes": [ "1/2" ] }