Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8985/?format=api
{ "id": 8985, "url": "https://patches.dpdk.org/api/patches/8985/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1447880321-16187-1-git-send-email-3chas3@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1447880321-16187-1-git-send-email-3chas3@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1447880321-16187-1-git-send-email-3chas3@gmail.com", "date": "2015-11-18T20:58:41", "name": "[dpdk-dev] bnx2x: set Ethernet address type during transmit for VF's", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "94bfa925436df8ad71894a4cea01d03263e50c43", "submitter": { "id": 341, "url": "https://patches.dpdk.org/api/people/341/?format=api", "name": "Chas Williams", "email": "3chas3@gmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1447880321-16187-1-git-send-email-3chas3@gmail.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8985/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8985/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CA1848D85;\n\tWed, 18 Nov 2015 21:58:49 +0100 (CET)", "from mail-qg0-f42.google.com (mail-qg0-f42.google.com\n\t[209.85.192.42]) by dpdk.org (Postfix) with ESMTP id 9490E5AA0\n\tfor <dev@dpdk.org>; Wed, 18 Nov 2015 21:58:48 +0100 (CET)", "by qgad10 with SMTP id d10so38096586qga.3\n\tfor <dev@dpdk.org>; Wed, 18 Nov 2015 12:58:48 -0800 (PST)", "from foobar.home (pool-71-163-182-126.washdc.fios.verizon.net.\n\t[71.163.182.126]) by smtp.gmail.com with ESMTPSA id\n\t74sm1432318qha.41.2015.11.18.12.58.47\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 18 Nov 2015 12:58:47 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id;\n\tbh=cFP9OD2NT356nPWtoqut61MqpdWDGsteHKDYPvKE2F4=;\n\tb=gEbPEBt/fYR+/BuRJAItNiOQ6L0/As4wMDABNa6XVRKmLCuBWVgL79PPt3hogQRj3B\n\tIq/hFQcrAUs841i1oTX1xC6+p1N9vUfzKUS9qCis/0SVZty9wNxZWzuXofusvbG9dhhZ\n\t64wdwohLmZPK2EEo+KTFafKGOEX/+8JtN84zNVr6LnKa8RHOqGFBheqct/xlaL0MEmiD\n\tQFFZmJZAPph3q/gkK3+illf+yq9L0DTPEmYmlh7m/IhO4wPm6slpl5/XsqV/XjQ1vctv\n\tavRsQgLyIr5g4wPRW2nx3+CqlRasClbVNACajVXTnxfzMNYnoG3iP1picB23XWSTbvnk\n\t3zWQ==", "X-Received": "by 10.140.162.214 with SMTP id i205mr3949205qhi.32.1447880328040;\n\tWed, 18 Nov 2015 12:58:48 -0800 (PST)", "From": "Chas Williams <3chas3@gmail.com>", "To": "dev@dpdk.org", "Date": "Wed, 18 Nov 2015 15:58:41 -0500", "Message-Id": "<1447880321-16187-1-git-send-email-3chas3@gmail.com>", "X-Mailer": "git-send-email 2.1.0", "Subject": "[dpdk-dev] [PATCH] bnx2x: set Ethernet address type during transmit\n\tfor VF's", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The original was always setting unicast. While here, clean up some\nother references that also point into the Ethernet header.\n\nSigned-off-by: Chas Williams <3chas3@gmail.com>\n---\n drivers/net/bnx2x/bnx2x.c | 23 +++++++++++++++--------\n drivers/net/bnx2x/ecore_hsi.h | 5 +++--\n 2 files changed, 18 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c\nindex 76444eb..294711f 100644\n--- a/drivers/net/bnx2x/bnx2x.c\n+++ b/drivers/net/bnx2x/bnx2x.c\n@@ -2177,25 +2177,32 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq, struct rte_mbuf **m_head, int m_p\n \t\tbd_prod = NEXT_TX_BD(bd_prod);\n \t\tif (IS_VF(sc)) {\n \t\t\tstruct eth_tx_parse_bd_e2 *tx_parse_bd;\n-\t\t\tuint8_t *data = rte_pktmbuf_mtod(m0, uint8_t *);\n+\t\t\tconst struct ether_hdr *eh = rte_pktmbuf_mtod(m0, struct ether_hdr *);\n+\t\t\tuint8_t mac_type = UNICAST_ADDRESS;\n \n \t\t\ttx_parse_bd =\n \t\t\t &txq->tx_ring[TX_BD(bd_prod, txq)].parse_bd_e2;\n+\t\t\tif (is_multicast_ether_addr(&eh->d_addr)) {\n+\t\t\t\tif (is_broadcast_ether_addr(&eh->d_addr))\n+\t\t\t\t\tmac_type = BROADCAST_ADDRESS;\n+\t\t\t\telse\n+\t\t\t\t\tmac_type = MULTICAST_ADDRESS;\n+\t\t\t}\n \t\t\ttx_parse_bd->parsing_data =\n-\t\t\t (1 << ETH_TX_PARSE_BD_E2_ETH_ADDR_TYPE_SHIFT);\n+\t\t\t (mac_type << ETH_TX_PARSE_BD_E2_ETH_ADDR_TYPE_SHIFT);\n \n \t\t\trte_memcpy(&tx_parse_bd->data.mac_addr.dst_hi,\n-\t\t\t\t &data[0], 2);\n+\t\t\t\t &eh->d_addr.addr_bytes[0], 2);\n \t\t\trte_memcpy(&tx_parse_bd->data.mac_addr.dst_mid,\n-\t\t\t\t &data[2], 2);\n+\t\t\t\t &eh->d_addr.addr_bytes[2], 2);\n \t\t\trte_memcpy(&tx_parse_bd->data.mac_addr.dst_lo,\n-\t\t\t\t &data[4], 2);\n+\t\t\t\t &eh->d_addr.addr_bytes[4], 2);\n \t\t\trte_memcpy(&tx_parse_bd->data.mac_addr.src_hi,\n-\t\t\t\t &data[6], 2);\n+\t\t\t\t &eh->s_addr.addr_bytes[0], 2);\n \t\t\trte_memcpy(&tx_parse_bd->data.mac_addr.src_mid,\n-\t\t\t\t &data[8], 2);\n+\t\t\t\t &eh->s_addr.addr_bytes[2], 2);\n \t\t\trte_memcpy(&tx_parse_bd->data.mac_addr.src_lo,\n-\t\t\t\t &data[10], 2);\n+\t\t\t\t &eh->s_addr.addr_bytes[4], 2);\n \n \t\t\ttx_parse_bd->data.mac_addr.dst_hi =\n \t\t\t rte_cpu_to_be_16(tx_parse_bd->data.mac_addr.dst_hi);\ndiff --git a/drivers/net/bnx2x/ecore_hsi.h b/drivers/net/bnx2x/ecore_hsi.h\nindex a4ed9b5..6c11c5a 100644\n--- a/drivers/net/bnx2x/ecore_hsi.h\n+++ b/drivers/net/bnx2x/ecore_hsi.h\n@@ -4029,7 +4029,7 @@ struct double_regpair\n \n \n /*\n- * Ethernet address typesm used in ethernet tx BDs\n+ * Ethernet address types used in ethernet tx BDs\n */\n enum eth_addr_type\n {\n@@ -4037,7 +4037,8 @@ enum eth_addr_type\n \tUNICAST_ADDRESS,\n \tMULTICAST_ADDRESS,\n \tBROADCAST_ADDRESS,\n-\tMAX_ETH_ADDR_TYPE};\n+\tMAX_ETH_ADDR_TYPE\n+};\n \n \n /*\n", "prefixes": [ "dpdk-dev" ] }