Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89220/?format=api
{ "id": 89220, "url": "https://patches.dpdk.org/api/patches/89220/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210316105149.110904-4-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210316105149.110904-4-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210316105149.110904-4-jiawenwu@trustnetic.com", "date": "2021-03-16T10:51:45", "name": "[v2,3/7] net/txgbe: move firmware version get function to base code", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1a730d6ee0e2ad1afc40db460d64be308b8cac13", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210316105149.110904-4-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 15691, "url": "https://patches.dpdk.org/api/series/15691/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15691", "date": "2021-03-16T10:51:42", "name": "txgbe backplane AN training", "version": 2, "mbox": "https://patches.dpdk.org/series/15691/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/89220/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/89220/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 92DF8A054F;\n\tTue, 16 Mar 2021 11:52:23 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9440824288C;\n\tTue, 16 Mar 2021 11:52:03 +0100 (CET)", "from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166])\n by mails.dpdk.org (Postfix) with ESMTP id 2EB5E4069F\n for <dev@dpdk.org>; Tue, 16 Mar 2021 11:51:56 +0100 (CET)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Tue, 16 Mar 2021 18:51:50 +0800 (CST)" ], "X-QQ-mid": "bizesmtp11t1615891911tbhfzmzm", "X-QQ-SSF": "01400000002000C0E000B00A0000000", "X-QQ-FEAT": "xeo957adDlbpeQPnu4BaM2j+32rAXatbcZtL/5seTVwPfPJtRolqE8g0MAeg0\n jfMRhVR6KeKhYBLcvQN2QYkYgOkAq71e3C+iW4aBHBISp9mFdgT1nrcrGkArIV6GE3/DvsM\n R+VfcnP47rJLFAq+0XAUgWcHq7fJDQnmRuhCoQccrub09WN72YFiOTuxKIGLg38OWYSLxRx\n H/RprDzRtH/ukErcZyMtAvwRkGqXOmBVfIiji/qqFnGj4G/Si4YkCkjfmUurULcxRpKxm5j\n Jn78xBV+QLUMibA51IYPe4ZzutxhrdFsiIMmcDKcZ1eK8FMz9QT/cXr9WPGxvcTlZAR9AkG\n QJtzdYcQWSz+i42/78u+tf9KPTP0TWCqcUlBuLW", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Tue, 16 Mar 2021 18:51:45 +0800", "Message-Id": "<20210316105149.110904-4-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210316105149.110904-1-jiawenwu@trustnetic.com>", "References": "<20210316105149.110904-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 3/7] net/txgbe: move firmware version get\n function to base code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Move firmware version get function to base code,\nand store firmware version in PHY info.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/base/txgbe_dummy.h | 6 ++++++\n drivers/net/txgbe/base/txgbe_hw.c | 4 ++++\n drivers/net/txgbe/base/txgbe_phy.c | 12 ++++++++++++\n drivers/net/txgbe/base/txgbe_phy.h | 1 +\n drivers/net/txgbe/base/txgbe_type.h | 2 ++\n drivers/net/txgbe/txgbe_ethdev.c | 5 +----\n 6 files changed, 26 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/base/txgbe_dummy.h b/drivers/net/txgbe/base/txgbe_dummy.h\nindex c9f2e7893..b62501d65 100644\n--- a/drivers/net/txgbe/base/txgbe_dummy.h\n+++ b/drivers/net/txgbe/base/txgbe_dummy.h\n@@ -424,6 +424,11 @@ static inline s32 txgbe_phy_check_link_dummy(struct txgbe_hw *TUP0, u32 *TUP1,\n {\n \treturn TXGBE_ERR_OPS_DUMMY;\n }\n+static inline s32 txgbe_get_phy_fw_version_dummy(struct txgbe_hw *TUP0,\n+\t\t\t\t\tu32 *TUP1)\n+{\n+\treturn TXGBE_ERR_OPS_DUMMY;\n+}\n static inline s32 txgbe_phy_read_i2c_byte_dummy(struct txgbe_hw *TUP0, u8 TUP1,\n \t\t\t\t\tu8 TUP2, u8 *TUP3)\n {\n@@ -628,6 +633,7 @@ static inline void txgbe_init_ops_dummy(struct txgbe_hw *hw)\n \thw->phy.setup_link = txgbe_phy_setup_link_dummy;\n \thw->phy.setup_link_speed = txgbe_phy_setup_link_speed_dummy;\n \thw->phy.check_link = txgbe_phy_check_link_dummy;\n+\thw->phy.get_fw_version = txgbe_get_phy_fw_version_dummy;\n \thw->phy.read_i2c_byte = txgbe_phy_read_i2c_byte_dummy;\n \thw->phy.write_i2c_byte = txgbe_phy_write_i2c_byte_dummy;\n \thw->phy.read_i2c_sff8472 = txgbe_phy_read_i2c_sff8472_dummy;\ndiff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/txgbe/base/txgbe_hw.c\nindex 81efb6444..26562f50d 100644\n--- a/drivers/net/txgbe/base/txgbe_hw.c\n+++ b/drivers/net/txgbe/base/txgbe_hw.c\n@@ -323,6 +323,9 @@ s32 txgbe_init_hw(struct txgbe_hw *hw)\n \n \tDEBUGFUNC(\"txgbe_init_hw\");\n \n+\t/* Get firmware version */\n+\thw->phy.get_fw_version(hw, &hw->fw_version);\n+\n \t/* Reset the hardware */\n \tstatus = hw->mac.reset_hw(hw);\n \tif (status == 0 || status == TXGBE_ERR_SFP_NOT_PRESENT) {\n@@ -2774,6 +2777,7 @@ s32 txgbe_init_ops_pf(struct txgbe_hw *hw)\n \tphy->write_reg_mdi = txgbe_write_phy_reg_mdi;\n \tphy->setup_link = txgbe_setup_phy_link;\n \tphy->setup_link_speed = txgbe_setup_phy_link_speed;\n+\tphy->get_fw_version = txgbe_get_phy_fw_version;\n \tphy->read_i2c_byte = txgbe_read_i2c_byte;\n \tphy->write_i2c_byte = txgbe_write_i2c_byte;\n \tphy->read_i2c_sff8472 = txgbe_read_i2c_sff8472;\ndiff --git a/drivers/net/txgbe/base/txgbe_phy.c b/drivers/net/txgbe/base/txgbe_phy.c\nindex 37c41099f..1ca6e35a4 100644\n--- a/drivers/net/txgbe/base/txgbe_phy.c\n+++ b/drivers/net/txgbe/base/txgbe_phy.c\n@@ -558,6 +558,18 @@ s32 txgbe_setup_phy_link_speed(struct txgbe_hw *hw,\n \treturn 0;\n }\n \n+s32 txgbe_get_phy_fw_version(struct txgbe_hw *hw, u32 *fw_version)\n+{\n+\tu16 eeprom_verh, eeprom_verl;\n+\n+\thw->rom.readw_sw(hw, TXGBE_EEPROM_VERSION_H, &eeprom_verh);\n+\thw->rom.readw_sw(hw, TXGBE_EEPROM_VERSION_L, &eeprom_verl);\n+\n+\t*fw_version = (eeprom_verh << 16) | eeprom_verl;\n+\n+\treturn 0;\n+}\n+\n /**\n * txgbe_get_copper_speeds_supported - Get copper link speeds from phy\n * @hw: pointer to hardware structure\ndiff --git a/drivers/net/txgbe/base/txgbe_phy.h b/drivers/net/txgbe/base/txgbe_phy.h\nindex 5aec1d28f..4a5b90077 100644\n--- a/drivers/net/txgbe/base/txgbe_phy.h\n+++ b/drivers/net/txgbe/base/txgbe_phy.h\n@@ -340,6 +340,7 @@ s32 txgbe_setup_phy_link(struct txgbe_hw *hw);\n s32 txgbe_setup_phy_link_speed(struct txgbe_hw *hw,\n \t\t\t\t u32 speed,\n \t\t\t\t bool autoneg_wait_to_complete);\n+s32 txgbe_get_phy_fw_version(struct txgbe_hw *hw, u32 *fw_version);\n s32 txgbe_get_copper_link_capabilities(struct txgbe_hw *hw,\n \t\t\t\t\t u32 *speed,\n \t\t\t\t\t bool *autoneg);\ndiff --git a/drivers/net/txgbe/base/txgbe_type.h b/drivers/net/txgbe/base/txgbe_type.h\nindex 008fcb25b..89d68d81f 100644\n--- a/drivers/net/txgbe/base/txgbe_type.h\n+++ b/drivers/net/txgbe/base/txgbe_type.h\n@@ -647,6 +647,7 @@ struct txgbe_phy_info {\n \ts32 (*setup_link_speed)(struct txgbe_hw *hw, u32 speed,\n \t\t\t\tbool autoneg_wait_to_complete);\n \ts32 (*check_link)(struct txgbe_hw *hw, u32 *speed, bool *link_up);\n+\ts32 (*get_fw_version)(struct txgbe_hw *hw, u32 *fw_version);\n \ts32 (*read_i2c_byte)(struct txgbe_hw *hw, u8 byte_offset,\n \t\t\t\tu8 dev_addr, u8 *data);\n \ts32 (*write_i2c_byte)(struct txgbe_hw *hw, u8 byte_offset,\n@@ -783,6 +784,7 @@ struct txgbe_hw {\n \tu16 nb_rx_queues;\n \tu16 nb_tx_queues;\n \n+\tu32 fw_version;\n \tu32 mode;\n \tenum txgbe_link_status {\n \t\tTXGBE_LINK_STATUS_NONE = 0,\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex cc7270a1c..f951ecf4d 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -2570,14 +2570,11 @@ static int\n txgbe_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)\n {\n \tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n-\tu16 eeprom_verh, eeprom_verl;\n \tu32 etrack_id;\n \tint ret;\n \n-\thw->rom.readw_sw(hw, TXGBE_EEPROM_VERSION_H, &eeprom_verh);\n-\thw->rom.readw_sw(hw, TXGBE_EEPROM_VERSION_L, &eeprom_verl);\n+\thw->phy.get_fw_version(hw, &etrack_id);\n \n-\tetrack_id = (eeprom_verh << 16) | eeprom_verl;\n \tret = snprintf(fw_version, fw_size, \"0x%08x\", etrack_id);\n \n \tret += 1; /* add the size of '\\0' */\n", "prefixes": [ "v2", "3/7" ] }